All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Yoni Bettan <ybettan@redhat.com>, qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH V2 0/3] Formatted INFO files to fit Markdown (.md) format.
Date: Tue, 4 Sep 2018 14:44:17 -0500	[thread overview]
Message-ID: <b735a977-9591-e6c3-3e82-91db5da00188@redhat.com> (raw)
In-Reply-To: <20180902175401.8195-1-ybettan@redhat.com>

On 09/02/2018 12:53 PM, Yoni Bettan wrote:
> This patch make INFO files (e.g. README, CODING_STYLE and HACKING) much more
> readable when watched from GitHub GUI.
> 
> ./VERSION, ./MAINTAINERS were leave untouched otherwise
> ./scripts/get_maintainer.pl breaks.
> 
> ./COPYING, ./LICENSE ./COPYING.LIB were leave untouched because it look likes
> they come from GNU and not QEMU.
> 
> Visualization of the change can be found at
> https://github.com/ybettan/qemu/tree/md.
> NOTE:
> This last part of the message should be removed from the commit message
> since I will remove the 'md' branch from my fork if the patch is
> accepted.

I'm a bit late to the thread, but wanted to point out this tangent:

Note that the cover letter is not committed into git, so a disclaimer 
about removing the last paragraph of the cover letter is pointless.

Had this been an actual commit message, it's best to stick such 
disclaimers (which are useful to reviewers, but not to long-term git 
log) after the --- that separates the actual commit message from the 
patch (as 'git am' will automatically strip such disclaimers when a 
maintainer takes in your patch for merging through their tree).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

      parent reply	other threads:[~2018-09-04 19:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-02 17:53 [Qemu-devel] [PATCH V2 0/3] Formatted INFO files to fit Markdown (.md) format Yoni Bettan
2018-09-02 17:53 ` [Qemu-devel] [PATCH V2 1/3] README.md : Formatted " Yoni Bettan
2018-09-03  9:43   ` Daniel P. Berrangé
2018-09-02 17:54 ` [Qemu-devel] [PATCH V2 2/3] CODING_STYLE.md " Yoni Bettan
2018-09-02 17:54 ` [Qemu-devel] [PATCH V2 3/3] HACKING.md " Yoni Bettan
2018-09-03  9:45 ` [Qemu-devel] [PATCH V2 0/3] Formatted INFO files " Daniel P. Berrangé
2018-09-04 19:44 ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b735a977-9591-e6c3-3e82-91db5da00188@redhat.com \
    --to=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=ybettan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.