From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Joseph, Anoob" Subject: Re: [PATCH v3 01/32] common/cpt: add common logging support Date: Mon, 8 Oct 2018 18:37:17 +0530 Message-ID: References: <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com> <1538744363-30340-1-git-send-email-anoob.joseph@caviumnetworks.com> <1538744363-30340-2-git-send-email-anoob.joseph@caviumnetworks.com> <2582518.r5GVpR4kJk@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Akhil Goyal , Pablo de Lara , Ankur Dwivedi , Jerin Jacob , Narayana Prasad , Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj To: Thomas Monjalon Return-path: Received: from NAM05-CO1-obe.outbound.protection.outlook.com (mail-eopbgr720051.outbound.protection.outlook.com [40.107.72.51]) by dpdk.org (Postfix) with ESMTP id 3D39B1B10D for ; Mon, 8 Oct 2018 15:06:19 +0200 (CEST) In-Reply-To: <2582518.r5GVpR4kJk@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, On 08-10-2018 17:57, Thomas Monjalon wrote: > External Email > > 05/10/2018 14:58, Anoob Joseph: >> +Cavium OCTEON TX >> +M: Anoob Joseph >> +F: drivers/common/cpt/ > What is the real wording for this device family? > Sometimes I read OcteonTX with lowercases and no space, > sometimes OCTEONTX without space, sometimes OCTEON TX. > > Another note: You should differentiate ethdev and cryptodev devices, > at least in the maintainer file. > We have nicvf, zipvf, ssovf, timvf. OCTEON TX (with the space) is the registered name of the chip. nicvf, zipvf, ssovf, timvf are all multiple blocks on the device and previous drivers were named that way. CPT is the similar name for the crypto block. Jerin is planning for a common naming convention for the blocks on the same family. Different blocks would be named crypto_octeontx, event_octeontx etc, to denote that they are all part of the same device. We had to omit the space (between OCTEON & TX), since it would complicate the name for the directories. OcteonTX is a wrong convention. It would be fixed going ahead. > I suggest to add "crypto" to the name of this section. This entry is already under "Crypto Drivers". So do we need a separate mention of "crypto"? Anoob