From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A28E0C433B4 for ; Wed, 19 May 2021 01:39:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FFA861361 for ; Wed, 19 May 2021 01:39:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233674AbhESBlP (ORCPT ); Tue, 18 May 2021 21:41:15 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:2975 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231689AbhESBlO (ORCPT ); Tue, 18 May 2021 21:41:14 -0400 Received: from dggems702-chm.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FlFpq3PQ0zBvSp; Wed, 19 May 2021 09:37:07 +0800 (CST) Received: from dggeme703-chm.china.huawei.com (10.1.199.99) by dggems702-chm.china.huawei.com (10.3.19.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 19 May 2021 09:39:53 +0800 Received: from [10.174.176.110] (10.174.176.110) by dggeme703-chm.china.huawei.com (10.1.199.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 19 May 2021 09:39:53 +0800 Subject: Re: [PATCH 5/5] mm/swap: simplify the code of find_get_incore_page() To: Matthew Wilcox , Andrew Morton CC: , References: <20210518135352.3705306-1-linmiaohe@huawei.com> <20210518135352.3705306-6-linmiaohe@huawei.com> <20210518141304.c09cd8762e3f3d16a722444c@linux-foundation.org> From: Miaohe Lin Message-ID: Date: Wed, 19 May 2021 09:39:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.176.110] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggeme703-chm.china.huawei.com (10.1.199.99) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/19 5:34, Matthew Wilcox wrote: > On Tue, May 18, 2021 at 02:13:04PM -0700, Andrew Morton wrote: >> On Tue, 18 May 2021 15:33:54 +0100 Matthew Wilcox wrote: >> >>> On Tue, May 18, 2021 at 09:53:52PM +0800, Miaohe Lin wrote: >>>> pagecache_get_page() can do find_subpage() for us if we do not specify >>>> FGP_HEAD. No functional change intended. >>> >>> Please, no. This interferes with the folio work. >> >> In what way? Can't the folio patches simply revert this or suitably >> alter it? > > Of course, it's just software. Anything can just be modified. I don't > see the point of putting in a cleanup patch that creates a conflict with > important work. I could hold this patch out until folio work is done if you ask for it. Thanks. > . >