From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99890C3DA7A for ; Fri, 6 Jan 2023 09:25:06 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 37BEA14191; Fri, 6 Jan 2023 10:24:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 37BEA14191 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1672997104; bh=/guuqpYUGNjdXQuLjNqMSHdBTlf67T4+XuF5fMg8NmA=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=ufuBW0nzm9gjh4dWFNePpGxbbRLpv43Y6ZZghAoS0BcsYp02eSP3iXGXNibxwlO8b 6XceEf+acoV0Tak9o4wKW1rB2XWUHIDoFlQlRWfC77tqYBDUU3y8agTVJFizB/Cy5O 7xbT40iU28sB1qazAsJ5AznzsE4geKhbNc3i41wk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E5FADF80238; Fri, 6 Jan 2023 10:24:13 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 222D1F80238; Fri, 6 Jan 2023 10:24:13 +0100 (CET) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 60448F80238 for ; Fri, 6 Jan 2023 10:24:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 60448F80238 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=YTbpxPT1 Received: by mail-wm1-x333.google.com with SMTP id fm16-20020a05600c0c1000b003d96fb976efso3110278wmb.3 for ; Fri, 06 Jan 2023 01:24:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SK0dKOCEBiaYKVTOvhAS22+z7lpa7ZgsHoskRIRAsZc=; b=YTbpxPT1ydolX/yLiyHmyWQXFkrm76SJhztxoGBZX3lIpxBbCW/ue7DCp6AtCG9DnI yDu9AD5+xqLyvsC9TSBoQKdQ9H73q+SPg6W/D1yGKk9StZfYlZ356SvmshsHoSVv9T/G jcQCIcvTHcsT8gJzeQef+d+nGR2q7gASrn1Fnln5Ejp3+lsENDxg3CSPvXp3/HOeXJR2 2c0EEDx94X+WkfyNLGtsqwJWAOy/1HgVcQ7bE31mSDXNobClaQBXBsi+xaQSZBqTl170 5pFD3NtwDVWjJgbyBkqox87NKkY2JxhMgxnyplkoH304Bcyq9Q9YImAqgJslqXIV434U Cb7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SK0dKOCEBiaYKVTOvhAS22+z7lpa7ZgsHoskRIRAsZc=; b=O0mCQkLnrW1zqBeYqJK1CzeKxdVG+vWWKz2Jkt1/KLx4b7VulSxCxoUiBDxFa6mxP3 uAxxrlu5znzuUZW8wsWbbiHls7lTKJXwVYAEOG+nydqM7iuWINeniZGwd8HottKBQdDS sxoY1KqDxtR8QjW7DYgFA+F51N7MDzU3BLL9D/UE4JlsfkqPwFCAo5t/mDTCAmML39TA 38lj0wrrAm9ggUNIZNwqfeluPvUugfMTWd9VX0RGGhdc2KuLaMEWAR8YUe8brMi/XW+2 lNbnW17qhrS7MnA3s4S9n46bY2BwmlPVfKtqiUpJF0GJi+KyPWgu6Z2Rgz2foAtXanYs 714g== X-Gm-Message-State: AFqh2kqRDlURCFK0tiUH3/zAcYl3GrSqhL3JqEALlVPR+02Vk/St2hVC 7fHf3w2RKRhHM0wjJDURe1J3sg== X-Google-Smtp-Source: AMrXdXvUXP1CXYiwjVxyNq2t/+oSyvDqLJuGkimxPKQaOx1jLGDORGChSn+kZ/MZBKQgytJdm7fmrA== X-Received: by 2002:a05:600c:798:b0:3d3:5737:3b0f with SMTP id z24-20020a05600c079800b003d357373b0fmr47698542wmo.36.1672997049322; Fri, 06 Jan 2023 01:24:09 -0800 (PST) Received: from [192.168.1.102] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id k4-20020a05600c1c8400b003d22528decesm6453805wms.43.2023.01.06.01.24.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 01:24:08 -0800 (PST) Message-ID: Date: Fri, 6 Jan 2023 10:24:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] ARM: dts: vfxxx: Swap SAI DMA order Content-Language: en-US To: Lucas Stach , Marek Vasut , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Rob Herring References: <20230105144145.165010-1-marex@denx.de> <20230105144145.165010-2-marex@denx.de> <5c2f0bba0a3a9d846cdfbcf7529759327d895810.camel@pengutronix.de> From: Krzysztof Kozlowski In-Reply-To: <5c2f0bba0a3a9d846cdfbcf7529759327d895810.camel@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shengjiu Wang , Peng Fan , Markus Niebel , Richard Zhu , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, Alexander Stein , Adam Ford , Richard Cochran , Paul Elder , Liam Girdwood , Stefan Agner , Joakim Zhang , Mark Brown , Laurent Pinchart , Pengutronix Kernel Team , Shawn Guo , Tim Harvey , Fabio Estevam , Sascha Hauer , NXP Linux Team Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 06/01/2023 10:18, Lucas Stach wrote: > Am Donnerstag, dem 05.01.2023 um 15:41 +0100 schrieb Marek Vasut: >> Swap the SAI dmas and dma-names to match the order documented in >> Documentation/devicetree/bindings/sound/fsl,sai.yaml >> No functional change. >> > While I'm not opposing this patch, I find this class of changes a bit > odd. The *-names properties are there so the properties they are naming > can be in any order in the DT without impacting the lookup. Enforcing a > fixed order for named properties just feels odd. DT requires fixed order regardless of '-names' property. '-names' are not there to fulfill "can be in any order", but merely a helper. > > Not sure if the schema validation could take this into account or if > there is any policy in place already by the DT maintainer that we still > want to enforce the same order in the DTs as in the bindings. The order in DTS must obviously match bindings, however here both are changed, so what is exactly your concern? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F192C3DA7A for ; Fri, 6 Jan 2023 09:27:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2DzUqdIO+kAciB6xhr3JPUQLPohwZ2ouAU5JEpOIA38=; b=j/Ly5SbLV+oHnb 5ahpqVhb2BBIvF2uIhiZkJjtrvHmKlzcOVRhpQ2JL10zjKygcxbQ9ObpkCHKCPXesOojsiNlLYuK3 UjzhrOYeAZNWngm8l4xDQo+dqcS5mBMD2CTdH4oeFCILsju5w1pQQ+koBOnqcKyZ8aisLw8XT+IlS A4hMlMGHlXUiZmlzZj6rJViHQ3S3KMRxkIcFJIFzbprf+OCcChNdM5ZL1YSicaKHztlXX4WWin/Uz 2c0402HlAX7wKK5Z5YXVEQElVgbT5Onj+XR3AZwMlbEnPqyv7rjYwDJccyyCvGcN0ezorz7kDsLaF 2lzAnssuN8zwecKlOjuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDizG-0070u3-IH; Fri, 06 Jan 2023 09:26:06 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDixQ-006zkU-41 for linux-arm-kernel@lists.infradead.org; Fri, 06 Jan 2023 09:24:13 +0000 Received: by mail-wm1-x333.google.com with SMTP id o15so645984wmr.4 for ; Fri, 06 Jan 2023 01:24:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SK0dKOCEBiaYKVTOvhAS22+z7lpa7ZgsHoskRIRAsZc=; b=YTbpxPT1ydolX/yLiyHmyWQXFkrm76SJhztxoGBZX3lIpxBbCW/ue7DCp6AtCG9DnI yDu9AD5+xqLyvsC9TSBoQKdQ9H73q+SPg6W/D1yGKk9StZfYlZ356SvmshsHoSVv9T/G jcQCIcvTHcsT8gJzeQef+d+nGR2q7gASrn1Fnln5Ejp3+lsENDxg3CSPvXp3/HOeXJR2 2c0EEDx94X+WkfyNLGtsqwJWAOy/1HgVcQ7bE31mSDXNobClaQBXBsi+xaQSZBqTl170 5pFD3NtwDVWjJgbyBkqox87NKkY2JxhMgxnyplkoH304Bcyq9Q9YImAqgJslqXIV434U Cb7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SK0dKOCEBiaYKVTOvhAS22+z7lpa7ZgsHoskRIRAsZc=; b=kxTANN2sdVmsHmiqouSYFCIPgioNLypo4YerfRnJwCCrlSOeUwVpJXQE+XfBuf65xp cLtcKFI+qsLhfWLcv1e9K9cGtYD9xLcLmnKf7ApiyVQ9YQnsALj0AZFFJ9ktOmTM3JBK M5kBbI0acUeNigUPqKFxO6mpS8p3u87B8viqx1QI8X/dWFOoh/BNQQEjiA3WmR7IsH3+ y3Bgf9rzLPoEfpbevOsWNl/CNB7mBFE1xMvch81FprZZyxqsBCLJdu7TTWuOt6gmdk8K 4MSd4JxQdB7evINNRxDjy9HGgZxq5HEqyZtkUiAM18IQCBb6ew8L/sY4t1BZxP7+W2DH yLpg== X-Gm-Message-State: AFqh2krdQl8gNk8AzZkvelrprjvBN7czKCIVMSMtcgmxhI4OH+4cXKoK wj3LN5xrTPJ3j8o04y8CO6fdbpNWjk2unX0o X-Google-Smtp-Source: AMrXdXvUXP1CXYiwjVxyNq2t/+oSyvDqLJuGkimxPKQaOx1jLGDORGChSn+kZ/MZBKQgytJdm7fmrA== X-Received: by 2002:a05:600c:798:b0:3d3:5737:3b0f with SMTP id z24-20020a05600c079800b003d357373b0fmr47698542wmo.36.1672997049322; Fri, 06 Jan 2023 01:24:09 -0800 (PST) Received: from [192.168.1.102] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id k4-20020a05600c1c8400b003d22528decesm6453805wms.43.2023.01.06.01.24.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 01:24:08 -0800 (PST) Message-ID: Date: Fri, 6 Jan 2023 10:24:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] ARM: dts: vfxxx: Swap SAI DMA order Content-Language: en-US To: Lucas Stach , Marek Vasut , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Rob Herring Cc: Adam Ford , Alexander Stein , Fabio Estevam , Joakim Zhang , Laurent Pinchart , Liam Girdwood , Mark Brown , Markus Niebel , NXP Linux Team , Paul Elder , Peng Fan , Pengutronix Kernel Team , Richard Cochran , Richard Zhu , Sascha Hauer , Shawn Guo , Shengjiu Wang , Stefan Agner , Tim Harvey , alsa-devel@alsa-project.org, devicetree@vger.kernel.org References: <20230105144145.165010-1-marex@denx.de> <20230105144145.165010-2-marex@denx.de> <5c2f0bba0a3a9d846cdfbcf7529759327d895810.camel@pengutronix.de> From: Krzysztof Kozlowski In-Reply-To: <5c2f0bba0a3a9d846cdfbcf7529759327d895810.camel@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230106_012412_220652_CE86B06F X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/01/2023 10:18, Lucas Stach wrote: > Am Donnerstag, dem 05.01.2023 um 15:41 +0100 schrieb Marek Vasut: >> Swap the SAI dmas and dma-names to match the order documented in >> Documentation/devicetree/bindings/sound/fsl,sai.yaml >> No functional change. >> > While I'm not opposing this patch, I find this class of changes a bit > odd. The *-names properties are there so the properties they are naming > can be in any order in the DT without impacting the lookup. Enforcing a > fixed order for named properties just feels odd. DT requires fixed order regardless of '-names' property. '-names' are not there to fulfill "can be in any order", but merely a helper. > > Not sure if the schema validation could take this into account or if > there is any policy in place already by the DT maintainer that we still > want to enforce the same order in the DTs as in the bindings. The order in DTS must obviously match bindings, however here both are changed, so what is exactly your concern? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA74C5479D for ; Fri, 6 Jan 2023 09:34:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232967AbjAFJeU (ORCPT ); Fri, 6 Jan 2023 04:34:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233429AbjAFJeB (ORCPT ); Fri, 6 Jan 2023 04:34:01 -0500 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C9EC81117 for ; Fri, 6 Jan 2023 01:26:08 -0800 (PST) Received: by mail-wm1-f44.google.com with SMTP id g10so661174wmo.1 for ; Fri, 06 Jan 2023 01:26:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SK0dKOCEBiaYKVTOvhAS22+z7lpa7ZgsHoskRIRAsZc=; b=YTbpxPT1ydolX/yLiyHmyWQXFkrm76SJhztxoGBZX3lIpxBbCW/ue7DCp6AtCG9DnI yDu9AD5+xqLyvsC9TSBoQKdQ9H73q+SPg6W/D1yGKk9StZfYlZ356SvmshsHoSVv9T/G jcQCIcvTHcsT8gJzeQef+d+nGR2q7gASrn1Fnln5Ejp3+lsENDxg3CSPvXp3/HOeXJR2 2c0EEDx94X+WkfyNLGtsqwJWAOy/1HgVcQ7bE31mSDXNobClaQBXBsi+xaQSZBqTl170 5pFD3NtwDVWjJgbyBkqox87NKkY2JxhMgxnyplkoH304Bcyq9Q9YImAqgJslqXIV434U Cb7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SK0dKOCEBiaYKVTOvhAS22+z7lpa7ZgsHoskRIRAsZc=; b=1DEnbgQcp130qQr4rxupCkZCdmtMwOr5qRmoZEx7FbApOCC33BGmMHrqyr42mGnRnj 4r9zJjlwORzrB9YiiQ6x3HwXCVVSzDh6f1hAX2EYjkegTcY/4RYyh5n7foq7xW9aV1Vr Ziy5U3linzFhvUCspIctCjjk3rOM2Ns49uDV7A7OchHnLkwzJZJwLpiU0o8NncsCM3Id cLp/ljfvoycELgU8DTZTygnNJ1xvKYJxlVRd3iJOhzoJ338NrKfCp2i0gzZqCPHby34p ENaPpb353NA+QUpn4JBsNst32YwxnfYuQiVR7qMhcxBibycCoObWtnLxQoq9e9rm/IHU Yjag== X-Gm-Message-State: AFqh2kpSI9gxcTDFeC+c5v3KtjCac80+nbLtsJe56j0sYh4WyNjM3V7O u7ooWz7jFhhQjlSk4Fbguc3abw== X-Google-Smtp-Source: AMrXdXvUXP1CXYiwjVxyNq2t/+oSyvDqLJuGkimxPKQaOx1jLGDORGChSn+kZ/MZBKQgytJdm7fmrA== X-Received: by 2002:a05:600c:798:b0:3d3:5737:3b0f with SMTP id z24-20020a05600c079800b003d357373b0fmr47698542wmo.36.1672997049322; Fri, 06 Jan 2023 01:24:09 -0800 (PST) Received: from [192.168.1.102] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id k4-20020a05600c1c8400b003d22528decesm6453805wms.43.2023.01.06.01.24.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 01:24:08 -0800 (PST) Message-ID: Date: Fri, 6 Jan 2023 10:24:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 2/2] ARM: dts: vfxxx: Swap SAI DMA order Content-Language: en-US To: Lucas Stach , Marek Vasut , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Rob Herring Cc: Adam Ford , Alexander Stein , Fabio Estevam , Joakim Zhang , Laurent Pinchart , Liam Girdwood , Mark Brown , Markus Niebel , NXP Linux Team , Paul Elder , Peng Fan , Pengutronix Kernel Team , Richard Cochran , Richard Zhu , Sascha Hauer , Shawn Guo , Shengjiu Wang , Stefan Agner , Tim Harvey , alsa-devel@alsa-project.org, devicetree@vger.kernel.org References: <20230105144145.165010-1-marex@denx.de> <20230105144145.165010-2-marex@denx.de> <5c2f0bba0a3a9d846cdfbcf7529759327d895810.camel@pengutronix.de> From: Krzysztof Kozlowski In-Reply-To: <5c2f0bba0a3a9d846cdfbcf7529759327d895810.camel@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/01/2023 10:18, Lucas Stach wrote: > Am Donnerstag, dem 05.01.2023 um 15:41 +0100 schrieb Marek Vasut: >> Swap the SAI dmas and dma-names to match the order documented in >> Documentation/devicetree/bindings/sound/fsl,sai.yaml >> No functional change. >> > While I'm not opposing this patch, I find this class of changes a bit > odd. The *-names properties are there so the properties they are naming > can be in any order in the DT without impacting the lookup. Enforcing a > fixed order for named properties just feels odd. DT requires fixed order regardless of '-names' property. '-names' are not there to fulfill "can be in any order", but merely a helper. > > Not sure if the schema validation could take this into account or if > there is any policy in place already by the DT maintainer that we still > want to enforce the same order in the DTs as in the bindings. The order in DTS must obviously match bindings, however here both are changed, so what is exactly your concern? Best regards, Krzysztof