From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE352ECE566 for ; Thu, 20 Sep 2018 21:31:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8AE4821523 for ; Thu, 20 Sep 2018 21:31:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G+7fdUkx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AE4821523 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388182AbeIUDRU (ORCPT ); Thu, 20 Sep 2018 23:17:20 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:40485 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726582AbeIUDRU (ORCPT ); Thu, 20 Sep 2018 23:17:20 -0400 Received: by mail-ed1-f68.google.com with SMTP id j62-v6so9049294edd.7; Thu, 20 Sep 2018 14:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Est8v2373tinwBQefZFdg7OgY9nY0UuaJ8fd3EQzsyk=; b=G+7fdUkxGve6A8FLTBmS/feQpMe8svlQnj2L5dK0iAcKZ+MY1talgDEHfIs8OdQpbV NxSUXbZS84vUWTpwZVgb9Mm4Zca9SHvNrNKrX0Xp6kJMKrSurdUg5m5J9NrEU9WxXEYM sQM/oikn4yynH/AGjeqAnlViGY/9fTlTewzQyAJhKxFL/Qdr/gRv6wLaGaWpWFQj0caS 2JMDFYUQDi24AUidJDwOjkUBmg66tCygfe9pWYobEPfigL5fbGBa/m9VWV29A18HC3In xpzjruarFQctktF/ATTKQaqu91fUorLV9i+XUUaodD+Wp76hG+GbiKEOqEUUvfhA7AVU ZCzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Est8v2373tinwBQefZFdg7OgY9nY0UuaJ8fd3EQzsyk=; b=bTKBX7SZTLbzyi1a1WIaPHqWivh8geBF+YLVkokQ6EN5B/5o1LdG9j72/SO7Qn+BvK vOE9S9QEzLMbfPBS4zx3cWoeNLI0fUO9YcdMSH3/vqG/mMTXg9qhpTbDm2XV7KMqim1K Ppedbai28SQ3kdnMv53siIfiqYUQ3i7hr7PMRGMnT+aylsR/PDuGV8q2joQKCVUIqPxw Cr2UMlkON0fEvWC+1x9OeAyzUC7khQbmqEF897aG7RGL+6zB8LTcCa3Lf49uMqvgOmgv Qjs13AsTLqldCXXcKHzfk6eS5YWoYjaj1mtGtvr1UDzCKnyAfDeiI24E/PGGpHyA1vbT GNDA== X-Gm-Message-State: APzg51CHcZPIjY0k1SdqV4TLHyWkw2Yj2bS6hoX9N0NbjtEcAYS2smEw fXXYDeEZvXw88MUnNVjjKGA= X-Google-Smtp-Source: ANB0VdYLfaVaiI4y7CQI3FOOS39KEWbEsSZiHUucopiA1C72FosBLDxLSAcNXkDWL4UbjdDN75T9vw== X-Received: by 2002:a50:8646:: with SMTP id 6-v6mr543457edt.259.1537479107944; Thu, 20 Sep 2018 14:31:47 -0700 (PDT) Received: from [10.67.50.87] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id x48-v6sm2395483edm.18.2018.09.20.14.31.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Sep 2018 14:31:46 -0700 (PDT) Subject: Re: [PATCH v5 04/12] PCI: brcmstb: add dma-range mapping for inbound traffic To: Ard Biesheuvel Cc: Jim Quinlan , Linux Kernel Mailing List , Lorenzo Pieralisi , linux-pci , BCM Kernel Feedback , Gregory Fong , Bjorn Helgaas , Brian Norris , Christoph Hellwig , linux-arm-kernel References: <1537367527-20773-1-git-send-email-jim2101024@gmail.com> <1537367527-20773-5-git-send-email-jim2101024@gmail.com> <7fa897cf-4d58-c63f-afdd-a3ec5a6a56bf@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== Message-ID: Date: Thu, 20 Sep 2018 14:31:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/20/2018 02:04 PM, Ard Biesheuvel wrote: > On 20 September 2018 at 13:55, Florian Fainelli wrote: >> On 09/19/2018 07:19 PM, Ard Biesheuvel wrote: >>> On 19 September 2018 at 07:31, Jim Quinlan wrote: >>>> The Broadcom STB PCIe host controller is intimately related to the >>>> memory subsystem. This close relationship adds complexity to how cpu >>>> system memory is mapped to PCIe memory. Ideally, this mapping is an >>>> identity mapping, or an identity mapping off by a constant. Not so in >>>> this case. >>>> >>>> Consider the Broadcom reference board BCM97445LCC_4X8 which has 6 GB >>>> of system memory. Here is how the PCIe controller maps the >>>> system memory to PCIe memory: >>>> >>>> memc0-a@[ 0....3fffffff] <=> pci@[ 0....3fffffff] >>>> memc0-b@[100000000...13fffffff] <=> pci@[ 40000000....7fffffff] >>>> memc1-a@[ 40000000....7fffffff] <=> pci@[ 80000000....bfffffff] >>>> memc1-b@[300000000...33fffffff] <=> pci@[ c0000000....ffffffff] >>>> memc2-a@[ 80000000....bfffffff] <=> pci@[100000000...13fffffff] >>>> memc2-b@[c00000000...c3fffffff] <=> pci@[140000000...17fffffff] >>>> >>> >>> So is describing this as >>> >>> dma-ranges = <0x0 0x0 0x0 0x0 0x0 0x40000000>, >>> <0x0 0x40000000 0x1 0x0 0x0 0x40000000>, >>> <0x0 0x80000000 0x0 0x40000000 0x0 0x40000000>, >>> <0x0 0xc0000000 0x3 0x0 0x0 0x40000000>, >>> <0x1 0x0 0x0 0x80000000 0x0 0x40000000>, >>> <0x1 0x40000000 0x0 0xc0000000 0x0 0x40000000>; >>> >>> not working for you? I haven't tried this myself, but since DT permits >>> describing the inbound mappings this way, we should fix the code if it >>> doesn't work at the moment. >> >> You mean encoding the memory controller index in the first cell? If that >> works, that's indeed a much cleaner solution, though is it standard >> compliant in any form? > > No those are just memory addresses (although I may have screwed up the > order). From Documentation/devicetree/booting-without-of.txt: > > """ > Optional property: > - dma-ranges: encoded as arbitrary number of triplets of > (child-bus-address, parent-bus-address, length). Each triplet specified > describes a contiguous DMA address range. > """ > Then I am confused by your comment, that's what this patch does, it adds support for reading "dma-ranges" from Device Tree and setting up inbound windows using that. The only caveat is that because the PCIe root complex has some ties with the memory bus architecture it is connected to (SCB in our case) there is still a requirement to know the translation between a given physical address and its backing memory controller/aperture. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: f.fainelli@gmail.com (Florian Fainelli) Date: Thu, 20 Sep 2018 14:31:36 -0700 Subject: [PATCH v5 04/12] PCI: brcmstb: add dma-range mapping for inbound traffic In-Reply-To: References: <1537367527-20773-1-git-send-email-jim2101024@gmail.com> <1537367527-20773-5-git-send-email-jim2101024@gmail.com> <7fa897cf-4d58-c63f-afdd-a3ec5a6a56bf@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/20/2018 02:04 PM, Ard Biesheuvel wrote: > On 20 September 2018 at 13:55, Florian Fainelli wrote: >> On 09/19/2018 07:19 PM, Ard Biesheuvel wrote: >>> On 19 September 2018 at 07:31, Jim Quinlan wrote: >>>> The Broadcom STB PCIe host controller is intimately related to the >>>> memory subsystem. This close relationship adds complexity to how cpu >>>> system memory is mapped to PCIe memory. Ideally, this mapping is an >>>> identity mapping, or an identity mapping off by a constant. Not so in >>>> this case. >>>> >>>> Consider the Broadcom reference board BCM97445LCC_4X8 which has 6 GB >>>> of system memory. Here is how the PCIe controller maps the >>>> system memory to PCIe memory: >>>> >>>> memc0-a@[ 0....3fffffff] <=> pci@[ 0....3fffffff] >>>> memc0-b@[100000000...13fffffff] <=> pci@[ 40000000....7fffffff] >>>> memc1-a@[ 40000000....7fffffff] <=> pci@[ 80000000....bfffffff] >>>> memc1-b@[300000000...33fffffff] <=> pci@[ c0000000....ffffffff] >>>> memc2-a@[ 80000000....bfffffff] <=> pci@[100000000...13fffffff] >>>> memc2-b@[c00000000...c3fffffff] <=> pci@[140000000...17fffffff] >>>> >>> >>> So is describing this as >>> >>> dma-ranges = <0x0 0x0 0x0 0x0 0x0 0x40000000>, >>> <0x0 0x40000000 0x1 0x0 0x0 0x40000000>, >>> <0x0 0x80000000 0x0 0x40000000 0x0 0x40000000>, >>> <0x0 0xc0000000 0x3 0x0 0x0 0x40000000>, >>> <0x1 0x0 0x0 0x80000000 0x0 0x40000000>, >>> <0x1 0x40000000 0x0 0xc0000000 0x0 0x40000000>; >>> >>> not working for you? I haven't tried this myself, but since DT permits >>> describing the inbound mappings this way, we should fix the code if it >>> doesn't work at the moment. >> >> You mean encoding the memory controller index in the first cell? If that >> works, that's indeed a much cleaner solution, though is it standard >> compliant in any form? > > No those are just memory addresses (although I may have screwed up the > order). From Documentation/devicetree/booting-without-of.txt: > > """ > Optional property: > - dma-ranges: encoded as arbitrary number of triplets of > (child-bus-address, parent-bus-address, length). Each triplet specified > describes a contiguous DMA address range. > """ > Then I am confused by your comment, that's what this patch does, it adds support for reading "dma-ranges" from Device Tree and setting up inbound windows using that. The only caveat is that because the PCIe root complex has some ties with the memory bus architecture it is connected to (SCB in our case) there is still a requirement to know the translation between a given physical address and its backing memory controller/aperture. -- Florian