All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: Alberto Garcia <berto@igalia.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>,
	Anton Nefedov <anton.nefedov@virtuozzo.com>,
	"Denis V . Lunev" <den@openvz.org>
Subject: [Qemu-devel] [PATCH v4 09/39] qcow2: Remove BDS parameter from qcow2_cache_clean_unused()
Date: Mon,  5 Feb 2018 16:33:09 +0200	[thread overview]
Message-ID: <b74f17591af52f201de0ea3a3b2dd0a81932334d.1517840876.git.berto@igalia.com> (raw)
In-Reply-To: <cover.1517840876.git.berto@igalia.com>
In-Reply-To: <cover.1517840876.git.berto@igalia.com>

This function was only using the BlockDriverState parameter to pass it
to qcow2_cache_table_release(). This is no longer necessary so this
parameter can be removed.

Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
 block/qcow2-cache.c | 2 +-
 block/qcow2.c       | 4 ++--
 block/qcow2.h       | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c
index 6f17a28635..03b3e03c6c 100644
--- a/block/qcow2-cache.c
+++ b/block/qcow2-cache.c
@@ -93,7 +93,7 @@ static inline bool can_clean_entry(Qcow2Cache *c, int i)
         t->lru_counter <= c->cache_clean_lru_counter;
 }
 
-void qcow2_cache_clean_unused(BlockDriverState *bs, Qcow2Cache *c)
+void qcow2_cache_clean_unused(Qcow2Cache *c)
 {
     int i = 0;
     while (i < c->size) {
diff --git a/block/qcow2.c b/block/qcow2.c
index 8e64c12605..e2d4bf7ad5 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -704,8 +704,8 @@ static void cache_clean_timer_cb(void *opaque)
 {
     BlockDriverState *bs = opaque;
     BDRVQcow2State *s = bs->opaque;
-    qcow2_cache_clean_unused(bs, s->l2_table_cache);
-    qcow2_cache_clean_unused(bs, s->refcount_block_cache);
+    qcow2_cache_clean_unused(s->l2_table_cache);
+    qcow2_cache_clean_unused(s->refcount_block_cache);
     timer_mod(s->cache_clean_timer, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) +
               (int64_t) s->cache_clean_interval * 1000);
 }
diff --git a/block/qcow2.h b/block/qcow2.h
index e0c429aef2..7e2781ffa4 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -646,7 +646,7 @@ int qcow2_cache_set_dependency(BlockDriverState *bs, Qcow2Cache *c,
     Qcow2Cache *dependency);
 void qcow2_cache_depends_on_flush(Qcow2Cache *c);
 
-void qcow2_cache_clean_unused(BlockDriverState *bs, Qcow2Cache *c);
+void qcow2_cache_clean_unused(Qcow2Cache *c);
 int qcow2_cache_empty(BlockDriverState *bs, Qcow2Cache *c);
 
 int qcow2_cache_get(BlockDriverState *bs, Qcow2Cache *c, uint64_t offset,
-- 
2.11.0

  parent reply	other threads:[~2018-02-05 14:49 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 14:33 [Qemu-devel] [PATCH v4 00/39] Allow configuring the qcow2 L2 cache entry size Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 01/39] qcow2: Fix documentation of get_cluster_table() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 02/39] qcow2: Add table size field to Qcow2Cache Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 03/39] qcow2: Remove BDS parameter from qcow2_cache_get_table_addr() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 04/39] qcow2: Remove BDS parameter from qcow2_cache_get_table_idx() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 05/39] qcow2: Remove BDS parameter from qcow2_cache_table_release() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 06/39] qcow2: Remove BDS parameter from qcow2_cache_entry_mark_dirty() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 07/39] qcow2: Remove BDS parameter from qcow2_cache_put() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 08/39] qcow2: Remove BDS parameter from qcow2_cache_destroy() Alberto Garcia
2018-02-05 14:33 ` Alberto Garcia [this message]
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 10/39] qcow2: Remove BDS parameter from qcow2_cache_discard() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 11/39] qcow2: Remove BDS parameter from qcow2_cache_is_table_offset() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 12/39] qcow2: Add offset_to_l1_index() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 13/39] qcow2: Add l2_slice_size field to BDRVQcow2State Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 14/39] qcow2: Add offset_to_l2_slice_index() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 15/39] qcow2: Update l2_load() to support L2 slices Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 16/39] qcow2: Prepare l2_allocate() for adding L2 slice support Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 17/39] qcow2: Update l2_allocate() to support L2 slices Alberto Garcia
2018-02-05 15:38   ` Max Reitz
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 18/39] qcow2: Refactor get_cluster_table() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 19/39] qcow2: Update get_cluster_table() to support L2 slices Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 20/39] qcow2: Update qcow2_get_cluster_offset() " Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 21/39] qcow2: Update qcow2_alloc_cluster_link_l2() " Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 22/39] qcow2: Update handle_copied() " Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 23/39] qcow2: Update handle_alloc() " Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 24/39] qcow2: Update discard_single_l2() " Alberto Garcia
2018-02-13 14:39   ` Eric Blake
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 25/39] qcow2: Update zero_single_l2() " Alberto Garcia
2018-02-13 14:40   ` Eric Blake
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 26/39] qcow2: Prepare qcow2_update_snapshot_refcount() for adding L2 slice support Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 27/39] qcow2: Update qcow2_update_snapshot_refcount() to support L2 slices Alberto Garcia
2018-02-05 15:44   ` Max Reitz
2018-02-13 14:50   ` Eric Blake
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 28/39] qcow2: Read refcount before L2 table in expand_zero_clusters_in_l1() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 29/39] qcow2: Prepare expand_zero_clusters_in_l1() for adding L2 slice support Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 30/39] qcow2: Update expand_zero_clusters_in_l1() to support L2 slices Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 31/39] qcow2: Update qcow2_truncate() " Alberto Garcia
2018-02-05 15:47   ` Max Reitz
2018-02-13 14:52   ` Eric Blake
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 32/39] qcow2: Rename l2_table in qcow2_alloc_compressed_cluster_offset() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 33/39] qcow2: Rename l2_table in count_contiguous_clusters() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 34/39] qcow2: Rename l2_table in count_contiguous_clusters_unallocated() Alberto Garcia
2018-02-13 12:25   ` Kevin Wolf
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 35/39] qcow2: Rename l2_table in count_cow_clusters() Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 36/39] qcow2: Allow configuring the L2 slice size Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 37/39] iotests: Test valid values of l2-cache-entry-size Alberto Garcia
2018-02-13 12:32   ` Kevin Wolf
2018-02-13 12:36     ` Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 38/39] iotests: Test downgrading an image using a small L2 slice size Alberto Garcia
2018-02-05 14:33 ` [Qemu-devel] [PATCH v4 39/39] iotests: Add l2-cache-entry-size to iotest 137 Alberto Garcia
2018-02-05 16:31 ` [Qemu-devel] [PATCH v4 00/39] Allow configuring the qcow2 L2 cache entry size Max Reitz
2018-02-13 12:33   ` Kevin Wolf
2018-02-13 14:49 ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b74f17591af52f201de0ea3a3b2dd0a81932334d.1517840876.git.berto@igalia.com \
    --to=berto@igalia.com \
    --cc=anton.nefedov@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.