Re: [Qemu-devel] [PATCH v2 2/5] qemu-options: Bail out on unsupported options instead of silently ignoring them

From: Thomas Huth <thuth@redhat.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Michal Privoznik <mprivozn@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/5] qemu-options: Bail out on unsupported options instead of silently ignoring them
Date: Wed, 16 May 2018 18:51:32 +0200	[thread overview]
Message-ID: <b75b0a14-b118-6f29-9050-d291e18ac165@redhat.com> (raw)
In-Reply-To: <20180516164900.GA32582@perard.uk.xensource.com>

On 16.05.2018 18:49, Anthony PERARD wrote:
> On Fri, May 04, 2018 at 07:01:07PM +0200, Thomas Huth wrote:
>> diff --git a/vl.c b/vl.c
>> index 806eec2..457e93b 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -4042,7 +4042,10 @@ int main(int argc, char **argv, char **envp)
>>                  }
>>                  break;
>>              default:
>> -                os_parse_cmd_args(popt->index, optarg);
>> +                if (os_parse_cmd_args(popt->index, optarg)) {
>> +                    error_report("Option not supported in this build");
>> +                    exit(1);
>> +                }
> 
> I think that report false errors, I've got:
> qemu-system-i386: -no-user-config: Option not supported in this build

Yes, sorry for that. Patch is already on the way:

https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg02972.html

 Thomas