All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86: Ensure asm/proto.h can be included stand-alone
@ 2021-04-11  8:12 Jan Kiszka
  2021-04-12 11:15 ` [tip: x86/cleanups] x86/asm: " tip-bot2 for Jan Kiszka
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2021-04-11  8:12 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
	Linux Kernel Mailing List

From: Jan Kiszka <jan.kiszka@siemens.com>

Avoids

../arch/x86/include/asm/proto.h:14:30: warning: ‘struct task_struct’ declared inside parameter list will not be visible outside of this definition or declaration
 long do_arch_prctl_64(struct task_struct *task, int option, unsigned long arg2);
                              ^~~~~~~~~~~
../arch/x86/include/asm/proto.h:40:34: warning: ‘struct task_struct’ declared inside parameter list will not be visible outside of this definition or declaration
 long do_arch_prctl_common(struct task_struct *task, int option,
                                  ^~~~~~~~~~~

if linux/sched.h hasn't be included previously.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 arch/x86/include/asm/proto.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/include/asm/proto.h b/arch/x86/include/asm/proto.h
index b6a9d51d1d79..8c5d1910a848 100644
--- a/arch/x86/include/asm/proto.h
+++ b/arch/x86/include/asm/proto.h
@@ -4,6 +4,8 @@

 #include <asm/ldt.h>

+struct task_struct;
+
 /* misc architecture specific prototypes */

 void syscall_init(void);
--
2.26.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip: x86/cleanups] x86/asm: Ensure asm/proto.h can be included stand-alone
  2021-04-11  8:12 [PATCH] x86: Ensure asm/proto.h can be included stand-alone Jan Kiszka
@ 2021-04-12 11:15 ` tip-bot2 for Jan Kiszka
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Jan Kiszka @ 2021-04-12 11:15 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: Jan Kiszka, Borislav Petkov, x86, linux-kernel

The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID:     f7b21a0e41171d22296b897dac6e4c41d2a3643c
Gitweb:        https://git.kernel.org/tip/f7b21a0e41171d22296b897dac6e4c41d2a3643c
Author:        Jan Kiszka <jan.kiszka@siemens.com>
AuthorDate:    Sun, 11 Apr 2021 10:12:16 +02:00
Committer:     Borislav Petkov <bp@suse.de>
CommitterDate: Mon, 12 Apr 2021 13:12:46 +02:00

x86/asm: Ensure asm/proto.h can be included stand-alone

Fix:

  ../arch/x86/include/asm/proto.h:14:30: warning: ‘struct task_struct’ declared \
    inside parameter list will not be visible outside of this definition or declaration
  long do_arch_prctl_64(struct task_struct *task, int option, unsigned long arg2);
                               ^~~~~~~~~~~

  .../arch/x86/include/asm/proto.h:40:34: warning: ‘struct task_struct’ declared \
    inside parameter list will not be visible outside of this definition or declaration
   long do_arch_prctl_common(struct task_struct *task, int option,
                                    ^~~~~~~~~~~

if linux/sched.h hasn't be included previously. This fixes a build error
when this header is used outside of the kernel tree.

 [ bp: Massage commit message. ]

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/b76b4be3-cf66-f6b2-9a6c-3e7ef54f9845@web.de
---
 arch/x86/include/asm/proto.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/include/asm/proto.h b/arch/x86/include/asm/proto.h
index b6a9d51..8c5d191 100644
--- a/arch/x86/include/asm/proto.h
+++ b/arch/x86/include/asm/proto.h
@@ -4,6 +4,8 @@
 
 #include <asm/ldt.h>
 
+struct task_struct;
+
 /* misc architecture specific prototypes */
 
 void syscall_init(void);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-12 11:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-11  8:12 [PATCH] x86: Ensure asm/proto.h can be included stand-alone Jan Kiszka
2021-04-12 11:15 ` [tip: x86/cleanups] x86/asm: " tip-bot2 for Jan Kiszka

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.