From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96EECC433E0 for ; Thu, 2 Jul 2020 17:52:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7916020760 for ; Thu, 2 Jul 2020 17:52:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eCKvFL3y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726980AbgGBRwZ (ORCPT ); Thu, 2 Jul 2020 13:52:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727773AbgGBRwY (ORCPT ); Thu, 2 Jul 2020 13:52:24 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A456C08C5DF for ; Thu, 2 Jul 2020 10:52:24 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id l17so28081465wmj.0 for ; Thu, 02 Jul 2020 10:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oglYmDMJJsMPIXYV1ITcnNL4FWv5Lg95ZCqCfgcjHUs=; b=eCKvFL3ymp9ODmh1kib4C/AcPrCHfUe4eQkI84tWMNstC588Mcs/UzyYV+30IgEPIB lfn4BGs06fAPfloAK0p40cJ3BQEuYzsfHY7d9o5Wr4ZrXyQrqXhtnG6F3jFX42w8e/2m weKvXoukAneezHhMB60mGihkb8pcI/kk8sZmWoEft2bkOnM2yQyw4RX50kJPE3J+9MnN fQinPrGJq2HYROL7Dl9fLIK+uTW325NDPRzeAtAAM2vhot8J8DATGO6hnDZGucHe9Jjs qXs+mG8rCVEuhGXBHfDtewoYJIa2KlLkJMQg70p6vJf/FdlJAKW6C6ggeDUiANRQMAFK P1Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oglYmDMJJsMPIXYV1ITcnNL4FWv5Lg95ZCqCfgcjHUs=; b=Nd7g7UECq3YnQ8RVH9bJ/WafBXsjbOjtNOCDPekieBFvKFXu1Ob7coC0eikaKQECss K57iHFbHEsy9lSxMLOXVmBBX5kUlYazAyFtj6/WzMXdATv5qKiRR+pafn8McULjC4569 Q4ARRWNoh4RiHZGWEPTaMno0nsH9PlXHDJT3yOXxpf+n+Iznl9IiYRWh3Oj1qi0738ZU rMeG9IhZO5MBhB06ZRRNgcR2mtFkuRIHyhePgXdIPLWIeHGp6M7ye7XbZ7UmXilrBkEb KdALUP/VmZOehNYgbLQ6/6Tdb4VCwH3NYQPF3rfQyxZiIYBpFp+eZd4k6ddgo7dkrbXZ I4cA== X-Gm-Message-State: AOAM5338yUBRovbeNZ3ftMIFxN+/TSl6iggyhlaiVHr/XVA67nf4I7ZS a5XKDBm7NdGtT5uLGJWEcx+eVA== X-Google-Smtp-Source: ABdhPJwGnT2w1T0cKggQNb65VkNrkBamKBA/sNFXDWMPWvMyn5BHS1CuhDAFIDm0ZukJhYYRAkgr9A== X-Received: by 2002:a7b:c041:: with SMTP id u1mr34629911wmc.56.1593712342780; Thu, 02 Jul 2020 10:52:22 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:c88a:7b2b:a4a1:46d0? ([2a01:e34:ed2f:f020:c88a:7b2b:a4a1:46d0]) by smtp.googlemail.com with ESMTPSA id h2sm11232487wrw.62.2020.07.02.10.52.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2020 10:52:22 -0700 (PDT) Subject: Re: [PATCH v7 00/11] Stop monitoring disabled devices From: Daniel Lezcano To: Andrzej Pietrasiewicz , linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: "Rafael J . Wysocki" , Len Brown , Vishal Kulkarni , "David S . Miller" , Jiri Pirko , Ido Schimmel , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Kalle Valo , Peter Kaestle , Darren Hart , Andy Shevchenko , Sebastian Reichel , Miquel Raynal , Amit Kucheria , Support Opensource , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Heiko Stuebner , Orson Zhai , Baolin Wang , Chunyan Zhang , Zhang Rui , Allison Randal , Enrico Weigelt , Gayatri Kammela , Thomas Gleixner , Bartlomiej Zolnierkiewicz , kernel@collabora.com References: <20200629122925.21729-1-andrzej.p@collabora.com> <3d03d1a2-ac06-b69b-93cb-e0203be62c10@collabora.com> <47111821-d691-e71d-d740-e4325e290fa4@linaro.org> <4353a939-3f5e-8369-5bc0-ad8162b5ffc7@linaro.org> <73942aea-ae79-753c-fe90-d4a99423d548@collabora.com> <374dddd9-b600-3a30-d6c3-8cfcefc944d9@linaro.org> <5a28deb7-f307-8b03-faad-ab05cb8095d1@collabora.com> <8aeb4f51-1813-63c1-165b-06640af5968f@linaro.org> <685ef627-e377-bbf1-da11-7f7556ca2dd7@collabora.com> Message-ID: Date: Thu, 2 Jul 2020 19:52:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 02/07/2020 19:49, Daniel Lezcano wrote: [ ... ] >> Thanks! >> >> That confirms your suspicions. >> >> So the reason is that ->get_temp() is called while the mutex is held and >> thermal_zone_device_is_enabled() wants to take the same mutex. > > Yes, that's correct. > >> Is adding a comment to thermal_zone_device_is_enabled() to never call >> it while the mutex is held and adding another version of it which does >> not take the mutex ok? > > The thermal_zone_device_is_enabled() is only used in two places, acpi > and this imx driver, and given: > > 1. as soon as the mutex is released, there is no guarantee the thermal > zone won't be changed right after, the lock is pointless, thus the > information also. > > 2. from a design point of view, I don't see why a driver should know if > a thermal zone is disabled or not > > It would make sense to end with this function and do not give the > different drivers an opportunity to access this information. > > Why not add change_mode for the acpi in order to enable or disable the > events and for imx_thermal use irq_enabled flag instead of the thermal > zone mode? Moreover it is very unclear why this function is needed in > imx_get_temp(), and I suspect we should be able to get rid of it. If you agree with that you can send a patch on top of your series so I can test it fixes the imx platform. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH v7 00/11] Stop monitoring disabled devices Date: Thu, 2 Jul 2020 19:52:19 +0200 Message-ID: References: <20200629122925.21729-1-andrzej.p@collabora.com> <3d03d1a2-ac06-b69b-93cb-e0203be62c10@collabora.com> <47111821-d691-e71d-d740-e4325e290fa4@linaro.org> <4353a939-3f5e-8369-5bc0-ad8162b5ffc7@linaro.org> <73942aea-ae79-753c-fe90-d4a99423d548@collabora.com> <374dddd9-b600-3a30-d6c3-8cfcefc944d9@linaro.org> <5a28deb7-f307-8b03-faad-ab05cb8095d1@collabora.com> <8aeb4f51-1813-63c1-165b-06640af5968f@linaro.org> <685ef627-e377-bbf1-da11-7f7556ca2dd7@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-renesas-soc-owner@vger.kernel.org To: Andrzej Pietrasiewicz , linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: "Rafael J . Wysocki" , Len Brown , Vishal Kulkarni , "David S . Miller" , Jiri Pirko , Ido Schimmel , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Kalle Valo , Peter Kaestle , Darren Hart , Andy Shevchenko , Sebastian Reichel , Miquel Raynal , Amit Kucheria , Support Opensource , Shawn Guo List-Id: platform-driver-x86.vger.kernel.org On 02/07/2020 19:49, Daniel Lezcano wrote: [ ... ] >> Thanks! >> >> That confirms your suspicions. >> >> So the reason is that ->get_temp() is called while the mutex is held and >> thermal_zone_device_is_enabled() wants to take the same mutex. > > Yes, that's correct. > >> Is adding a comment to thermal_zone_device_is_enabled() to never call >> it while the mutex is held and adding another version of it which does >> not take the mutex ok? > > The thermal_zone_device_is_enabled() is only used in two places, acpi > and this imx driver, and given: > > 1. as soon as the mutex is released, there is no guarantee the thermal > zone won't be changed right after, the lock is pointless, thus the > information also. > > 2. from a design point of view, I don't see why a driver should know if > a thermal zone is disabled or not > > It would make sense to end with this function and do not give the > different drivers an opportunity to access this information. > > Why not add change_mode for the acpi in order to enable or disable the > events and for imx_thermal use irq_enabled flag instead of the thermal > zone mode? Moreover it is very unclear why this function is needed in > imx_get_temp(), and I suspect we should be able to get rid of it. If you agree with that you can send a patch on top of your series so I can test it fixes the imx platform. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74230C433DF for ; Thu, 2 Jul 2020 17:53:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42FDF20737 for ; Thu, 2 Jul 2020 17:53:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X57PM9zS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eCKvFL3y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42FDF20737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AaOZWSv+lDc0IK32HZEgwRMuqMUDT8KRveuxna+J9Q4=; b=X57PM9zS2SWTKRv8UlYW45KBy FfDLRE1y35YQqTLpqf9/289ytAfv+Mo7FvxaNFh5NU1X2Hy7QOufWbcQhcCe+vDsHgKe8uHZSHrQL bLTbyLXu53Ea86mP1IYCwDt06I0sSBDqVZSyPQluLkxj5UVBK0wxU3I7JQWu5Dw8YAqLy4vaBWcpW F9cWytlBsJElR9XHWEaliayiPzLhkmKU9veISf+jJF5KRbb5SdKtBX457QHrxh6Gv4PYChSCDEOJY iPtaVr7GyULG7yhvQDpCihuw87cSwl0Fkksk9uBzMcCd7pwTlp4Ub4PfQiATr2xOuBQ9uE9EnQaQN MTRFDdN1Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr3Ns-0004xK-Nb; Thu, 02 Jul 2020 17:52:28 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr3Nn-0004vF-QA for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 17:52:24 +0000 Received: by mail-wm1-x343.google.com with SMTP id l17so28081467wmj.0 for ; Thu, 02 Jul 2020 10:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oglYmDMJJsMPIXYV1ITcnNL4FWv5Lg95ZCqCfgcjHUs=; b=eCKvFL3ymp9ODmh1kib4C/AcPrCHfUe4eQkI84tWMNstC588Mcs/UzyYV+30IgEPIB lfn4BGs06fAPfloAK0p40cJ3BQEuYzsfHY7d9o5Wr4ZrXyQrqXhtnG6F3jFX42w8e/2m weKvXoukAneezHhMB60mGihkb8pcI/kk8sZmWoEft2bkOnM2yQyw4RX50kJPE3J+9MnN fQinPrGJq2HYROL7Dl9fLIK+uTW325NDPRzeAtAAM2vhot8J8DATGO6hnDZGucHe9Jjs qXs+mG8rCVEuhGXBHfDtewoYJIa2KlLkJMQg70p6vJf/FdlJAKW6C6ggeDUiANRQMAFK P1Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oglYmDMJJsMPIXYV1ITcnNL4FWv5Lg95ZCqCfgcjHUs=; b=neCp6kVv6/OFweS0WWVQ3GlLq1W68vkOO4yshLsq4uODbHMCWxnHO+sgL0pWVP7yKX 04YN5Oc5L/Zo6h/tJirxfx3+AUo2cmPXJbpDRPxcWFR1ppwnPZsFV42YQt1drjfcnk16 TevdW7evbcnxq70Jyx5KjHDV8Hg+yQ3/nFihepTvop2r3EsUqz1O5ym0jZ3PLTNACsEB 3qwmEsSR3o1bc92L3DZSHBO26gG6rq5WvPfCiB2UbcgAajedWpcRZ+nn412sD3KoRLxX GB9WIRxGSPvi7Syacbjm7T2VqsW4hN5+/nkAv/IQTLvoVwdW3UVj1EC5Dm9PlTcEgMZT p3pA== X-Gm-Message-State: AOAM530nM/O/zA4zj+almasmuWhr7S9LipRkIxegi/wTzE/kzDDPazve i4RfBSuqJMLk1M4ig3/DfLrh5A== X-Google-Smtp-Source: ABdhPJwGnT2w1T0cKggQNb65VkNrkBamKBA/sNFXDWMPWvMyn5BHS1CuhDAFIDm0ZukJhYYRAkgr9A== X-Received: by 2002:a7b:c041:: with SMTP id u1mr34629911wmc.56.1593712342780; Thu, 02 Jul 2020 10:52:22 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:c88a:7b2b:a4a1:46d0? ([2a01:e34:ed2f:f020:c88a:7b2b:a4a1:46d0]) by smtp.googlemail.com with ESMTPSA id h2sm11232487wrw.62.2020.07.02.10.52.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2020 10:52:22 -0700 (PDT) Subject: Re: [PATCH v7 00/11] Stop monitoring disabled devices From: Daniel Lezcano To: Andrzej Pietrasiewicz , linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20200629122925.21729-1-andrzej.p@collabora.com> <3d03d1a2-ac06-b69b-93cb-e0203be62c10@collabora.com> <47111821-d691-e71d-d740-e4325e290fa4@linaro.org> <4353a939-3f5e-8369-5bc0-ad8162b5ffc7@linaro.org> <73942aea-ae79-753c-fe90-d4a99423d548@collabora.com> <374dddd9-b600-3a30-d6c3-8cfcefc944d9@linaro.org> <5a28deb7-f307-8b03-faad-ab05cb8095d1@collabora.com> <8aeb4f51-1813-63c1-165b-06640af5968f@linaro.org> <685ef627-e377-bbf1-da11-7f7556ca2dd7@collabora.com> Message-ID: Date: Thu, 2 Jul 2020 19:52:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_135223_937940_51F18A79 X-CRM114-Status: GOOD ( 23.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emmanuel Grumbach , Heiko Stuebner , "Rafael J . Wysocki" , Vishal Kulkarni , Luca Coelho , Miquel Raynal , kernel@collabora.com, Fabio Estevam , Amit Kucheria , Chunyan Zhang , Bartlomiej Zolnierkiewicz , Allison Randal , NXP Linux Team , Darren Hart , Zhang Rui , Gayatri Kammela , Len Brown , Johannes Berg , Intel Linux Wireless , Sascha Hauer , Ido Schimmel , Baolin Wang , Jiri Pirko , Orson Zhai , Thomas Gleixner , Kalle Valo , Support Opensource , Enrico Weigelt , Peter Kaestle , Sebastian Reichel , Pengutronix Kernel Team , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Shawn Guo , "David S . Miller" , Andy Shevchenko Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDIvMDcvMjAyMCAxOTo0OSwgRGFuaWVsIExlemNhbm8gd3JvdGU6CgpbIC4uLiBdCgo+PiBU aGFua3MhCj4+Cj4+IFRoYXQgY29uZmlybXMgeW91ciBzdXNwaWNpb25zLgo+Pgo+PiBTbyB0aGUg cmVhc29uIGlzIHRoYXQgLT5nZXRfdGVtcCgpIGlzIGNhbGxlZCB3aGlsZSB0aGUgbXV0ZXggaXMg aGVsZCBhbmQKPj4gdGhlcm1hbF96b25lX2RldmljZV9pc19lbmFibGVkKCkgd2FudHMgdG8gdGFr ZSB0aGUgc2FtZSBtdXRleC4KPiAKPiBZZXMsIHRoYXQncyBjb3JyZWN0Lgo+IAo+PiBJcyBhZGRp bmcgYSBjb21tZW50IHRvIHRoZXJtYWxfem9uZV9kZXZpY2VfaXNfZW5hYmxlZCgpIHRvIG5ldmVy IGNhbGwKPj4gaXQgd2hpbGUgdGhlIG11dGV4IGlzIGhlbGQgYW5kIGFkZGluZyBhbm90aGVyIHZl cnNpb24gb2YgaXQgd2hpY2ggZG9lcwo+PiBub3QgdGFrZSB0aGUgbXV0ZXggb2s/Cj4gCj4gVGhl IHRoZXJtYWxfem9uZV9kZXZpY2VfaXNfZW5hYmxlZCgpIGlzIG9ubHkgdXNlZCBpbiB0d28gcGxh Y2VzLCBhY3BpCj4gYW5kIHRoaXMgaW14IGRyaXZlciwgYW5kIGdpdmVuOgo+IAo+IDEuIGFzIHNv b24gYXMgdGhlIG11dGV4IGlzIHJlbGVhc2VkLCB0aGVyZSBpcyBubyBndWFyYW50ZWUgdGhlIHRo ZXJtYWwKPiB6b25lIHdvbid0IGJlIGNoYW5nZWQgcmlnaHQgYWZ0ZXIsIHRoZSBsb2NrIGlzIHBv aW50bGVzcywgdGh1cyB0aGUKPiBpbmZvcm1hdGlvbiBhbHNvLgo+IAo+IDIuIGZyb20gYSBkZXNp Z24gcG9pbnQgb2YgdmlldywgSSBkb24ndCBzZWUgd2h5IGEgZHJpdmVyIHNob3VsZCBrbm93IGlm Cj4gYSB0aGVybWFsIHpvbmUgaXMgZGlzYWJsZWQgb3Igbm90Cj4gCj4gSXQgd291bGQgbWFrZSBz ZW5zZSB0byBlbmQgd2l0aCB0aGlzIGZ1bmN0aW9uIGFuZCBkbyBub3QgZ2l2ZSB0aGUKPiBkaWZm ZXJlbnQgZHJpdmVycyBhbiBvcHBvcnR1bml0eSB0byBhY2Nlc3MgdGhpcyBpbmZvcm1hdGlvbi4K PiAKPiBXaHkgbm90IGFkZCBjaGFuZ2VfbW9kZSBmb3IgdGhlIGFjcGkgaW4gb3JkZXIgdG8gZW5h YmxlIG9yIGRpc2FibGUgdGhlCj4gZXZlbnRzIGFuZCBmb3IgaW14X3RoZXJtYWwgdXNlIGlycV9l bmFibGVkIGZsYWcgaW5zdGVhZCBvZiB0aGUgdGhlcm1hbAo+IHpvbmUgbW9kZT8gTW9yZW92ZXIg aXQgaXMgdmVyeSB1bmNsZWFyIHdoeSB0aGlzIGZ1bmN0aW9uIGlzIG5lZWRlZCBpbgo+IGlteF9n ZXRfdGVtcCgpLCBhbmQgSSBzdXNwZWN0IHdlIHNob3VsZCBiZSBhYmxlIHRvIGdldCByaWQgb2Yg aXQuCgpJZiB5b3UgYWdyZWUgd2l0aCB0aGF0IHlvdSBjYW4gc2VuZCBhIHBhdGNoIG9uIHRvcCBv ZiB5b3VyIHNlcmllcyBzbyBJCmNhbiB0ZXN0IGl0IGZpeGVzIHRoZSBpbXggcGxhdGZvcm0uCgoK LS0gCjxodHRwOi8vd3d3LmxpbmFyby5vcmcvPiBMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBz b2Z0d2FyZSBmb3IgQVJNIFNvQ3MKCkZvbGxvdyBMaW5hcm86ICA8aHR0cDovL3d3dy5mYWNlYm9v ay5jb20vcGFnZXMvTGluYXJvPiBGYWNlYm9vayB8CjxodHRwOi8vdHdpdHRlci5jb20vIyEvbGlu YXJvb3JnPiBUd2l0dGVyIHwKPGh0dHA6Ly93d3cubGluYXJvLm9yZy9saW5hcm8tYmxvZy8+IEJs b2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK