From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDA06C2BB1D for ; Wed, 11 Mar 2020 19:19:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A93C220737 for ; Wed, 11 Mar 2020 19:19:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eZXdYYUO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731159AbgCKTTh (ORCPT ); Wed, 11 Mar 2020 15:19:37 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:33087 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730807AbgCKTTh (ORCPT ); Wed, 11 Mar 2020 15:19:37 -0400 Received: by mail-pj1-f68.google.com with SMTP id o21so1853951pjs.0; Wed, 11 Mar 2020 12:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pOjQrnVayTgdrET4gCgzOMQ7+VznZ1NPyMucBXzQRTg=; b=eZXdYYUO9MJk8vDBz2ohUHhTlFQ6OUvKe5NJC3wwMup1+78yjzPuD0a1yqr7kKDAzn R6bakE9D6+2lnyfG457Nwws4+THsXyHBMV88kQa77cHLpoisL/FI1o5FbYjjD+Cho972 a/pSRcvr7B/YCgFV1J8wk+jRpXIpqHPrPXkUbPz86UioJj5qwacgDmZn15UmH5MpjSIm NvmTKUXeA4shooBgG2EMsAcLL3Sm7nQ72CXnpIBnlTEibmiT3TrxdnaIeopIbHLfMDA9 iCdUKJsTETkc/0yFfjDjJIJEzpVlInD/58X/THAjQ3ciF01RAOk751kpX86fuzJRi0o3 d2OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pOjQrnVayTgdrET4gCgzOMQ7+VznZ1NPyMucBXzQRTg=; b=im5W9ds9G2tb1LIffJBVdjo6FKRMvXedDkQlplIvxaUJ4esXnjBBf5oX7ZwxCXFoVE HzYmeT4pzr23bXWFfiYSRKJLei+rZjPdG+9jlvSDk5xapH+5sWKkXC24OE83RWmLCYKz M8hyXx8pqaUsRdtjxRRGZurqiaJHB48v7Ge7quu+TTl2nZbcR0GdrrEFGYZDMnBXv5vs i9X17IAo9c3KxZmSuLABW59LRr+89QVL61Z9bKR/thNa7gIxKgiAQaCa15A/e6iMUGWv Nl2tLD9oXzGBpvpe0e9F/I0ORBL50IqXbfDhVl3Ng0rsXiehH/LBpZd5heuAVJvkdCSq 5JCA== X-Gm-Message-State: ANhLgQ1iaI6LB/7y8JS7HGrBD/rzJyzkhjJazNgNf6wi6R4WFqatEqc/ 1SwLRxxgs+L827Of+zo0UIU= X-Google-Smtp-Source: ADFU+vsSzPj8KundN3q85Ksdo5biFKHHfX+UdUbQyTZOldP1FMJEG8vyFDHt7yRgWjL+jYyHW5T0Zg== X-Received: by 2002:a17:90b:1a8b:: with SMTP id ng11mr201893pjb.173.1583954376003; Wed, 11 Mar 2020 12:19:36 -0700 (PDT) Received: from localhost.localdomain ([103.46.201.94]) by smtp.gmail.com with ESMTPSA id z17sm3792673pff.12.2020.03.11.12.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 12:19:35 -0700 (PDT) From: Aman Sharma Cc: amanharitsh123@gmail.com, Thomas Petazzoni , Lorenzo Pieralisi , Andrew Murray , Bjorn Helgaas , Linus Walleij , Ryder Lee , Karthikeyan Mitran , Hou Zhiqiang , Marc Gonzalez , Mans Rullgard , Matthias Brugger , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH 4/5] pci: handled return value of platform_get_irq correctly Date: Thu, 12 Mar 2020 00:49:05 +0530 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Aman Sharma --- drivers/pci/controller/pcie-tango.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-tango.c b/drivers/pci/controller/pcie-tango.c index 21a208da3f59..18c2c4313eb5 100644 --- a/drivers/pci/controller/pcie-tango.c +++ b/drivers/pci/controller/pcie-tango.c @@ -273,9 +273,9 @@ static int tango_pcie_probe(struct platform_device *pdev) writel_relaxed(0, pcie->base + SMP8759_ENABLE + offset); virq = platform_get_irq(pdev, 1); - if (virq <= 0) { + if (virq < 0) { dev_err(dev, "Failed to map IRQ\n"); - return -ENXIO; + return virq; } irq_dom = irq_domain_create_linear(fwnode, MSI_MAX, &dom_ops, pcie); -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 970E1C2BAEE for ; Wed, 11 Mar 2020 19:21:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A51720578 for ; Wed, 11 Mar 2020 19:21:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TYHtYb1j"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eZXdYYUO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A51720578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V3DD+EWnmBZC/k7cTn9myU86CqG9UXq10LZiYJ1go5Q=; b=TYHtYb1jSjtPNF /1c7sYVEmhjPtxOZwiWecO1uwm6/GFg0zLTW1nHcaJvIn/q3SMm0wrRM/phZkViSR5WB1tUXnycjR p8tNSCs3aEhsE7xf6UbpNJPJhYVhzt11XGqy+zGyKyIlpTmc42UmGNVsz2iGCN9IJWdxgch+oVw/8 PCrYZlWjP4Ic7g+viG9WEoM4N77v3+M8QJykwj3P7+qxLWm8/PgK/P4/qAnr8ivSwqTLqn15j3989 ybtoZhFzM5wp9zMhL6AGDJkeeyz3UWZiV5vu1BHF7cszIZacke+rXNATZlzSQkmWB9/UHwrKpWcj/ TS/bZG7TUki7S/qZhwjg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC6uU-00004r-DU; Wed, 11 Mar 2020 19:20:54 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC6tF-0006GI-JC; Wed, 11 Mar 2020 19:19:39 +0000 Received: by mail-pl1-x644.google.com with SMTP id w12so1524282pll.13; Wed, 11 Mar 2020 12:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pOjQrnVayTgdrET4gCgzOMQ7+VznZ1NPyMucBXzQRTg=; b=eZXdYYUO9MJk8vDBz2ohUHhTlFQ6OUvKe5NJC3wwMup1+78yjzPuD0a1yqr7kKDAzn R6bakE9D6+2lnyfG457Nwws4+THsXyHBMV88kQa77cHLpoisL/FI1o5FbYjjD+Cho972 a/pSRcvr7B/YCgFV1J8wk+jRpXIpqHPrPXkUbPz86UioJj5qwacgDmZn15UmH5MpjSIm NvmTKUXeA4shooBgG2EMsAcLL3Sm7nQ72CXnpIBnlTEibmiT3TrxdnaIeopIbHLfMDA9 iCdUKJsTETkc/0yFfjDjJIJEzpVlInD/58X/THAjQ3ciF01RAOk751kpX86fuzJRi0o3 d2OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pOjQrnVayTgdrET4gCgzOMQ7+VznZ1NPyMucBXzQRTg=; b=Opmn/W2hzzQ+5ZNi+BUApGZ5tpdzLGzq1ng5WBskTdTCYgPGRu/xpOOwI4Y0I+n697 HwT4XTeFAGAuS8LxsTZX3/Pm662jqcxD9tYWDslz5zEIORpI2czzuS2U9fuO7UE7YFyY wFSs4b+WTTuqafmSaXQ/fY092OxUCVuRpmKZ3F0g5BaZVBawA60JGRsI9vqJtmkDNxCp F6Kuvtqa8nCzpIGJeYIpncYuip7uPzBJ+rxSt79vs/B79OQ84hzg6PeGsjx/bXhNMKC0 OKo2c6BLhSdQpYHR2/VlnyLFxR42JohpnqekVejz6UAp/zYZXacu/QC2jdLEepBFzezH cC8A== X-Gm-Message-State: ANhLgQ1jhFYPxlw5Ir00MZPdGnivFQD0C7yxT6RwB3HB88PCSPLs59A8 qFJKH6YJlhgLth5f56PApnw= X-Google-Smtp-Source: ADFU+vsSzPj8KundN3q85Ksdo5biFKHHfX+UdUbQyTZOldP1FMJEG8vyFDHt7yRgWjL+jYyHW5T0Zg== X-Received: by 2002:a17:90b:1a8b:: with SMTP id ng11mr201893pjb.173.1583954376003; Wed, 11 Mar 2020 12:19:36 -0700 (PDT) Received: from localhost.localdomain ([103.46.201.94]) by smtp.gmail.com with ESMTPSA id z17sm3792673pff.12.2020.03.11.12.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 12:19:35 -0700 (PDT) From: Aman Sharma To: Subject: [PATCH 4/5] pci: handled return value of platform_get_irq correctly Date: Thu, 12 Mar 2020 00:49:05 +0530 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_121937_770634_732A3E14 X-CRM114-Status: GOOD ( 10.73 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Karthikeyan Mitran , Marc Gonzalez , linux-pci@vger.kernel.org, Linus Walleij , amanharitsh123@gmail.com, linux-kernel@vger.kernel.org, Matthias Brugger , Ryder Lee , linux-mediatek@lists.infradead.org, Thomas Petazzoni , Bjorn Helgaas , Mans Rullgard , Hou Zhiqiang , linux-arm-kernel@lists.infradead.org, Andrew Murray Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Signed-off-by: Aman Sharma --- drivers/pci/controller/pcie-tango.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-tango.c b/drivers/pci/controller/pcie-tango.c index 21a208da3f59..18c2c4313eb5 100644 --- a/drivers/pci/controller/pcie-tango.c +++ b/drivers/pci/controller/pcie-tango.c @@ -273,9 +273,9 @@ static int tango_pcie_probe(struct platform_device *pdev) writel_relaxed(0, pcie->base + SMP8759_ENABLE + offset); virq = platform_get_irq(pdev, 1); - if (virq <= 0) { + if (virq < 0) { dev_err(dev, "Failed to map IRQ\n"); - return -ENXIO; + return virq; } irq_dom = irq_domain_create_linear(fwnode, MSI_MAX, &dom_ops, pcie); -- 2.20.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED270C2BAEE for ; Wed, 11 Mar 2020 19:20:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA71D20578 for ; Wed, 11 Mar 2020 19:20:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SEHhF5xe"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eZXdYYUO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA71D20578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TOWUVmym5ttKyWI1hB42MPciSeVLpf/ygS2cFFZeYzw=; b=SEHhF5xezttXvk 4GPJNa0GxM1G2XewDSq3Z2DYF3klE5eZdZt9iVYW9g+xpYkKjvBE4ZmQ+N4qMkmnHNbDQzOoBE2lX gRfY51nXYz0RVMr8IvoFT9GP6w+Eg6wlofzcydr2SPqy6u72NJiN3YmXz/yCzeM9yFW+tOwMsIZjZ hEXyOJoGnrDrxebPL84hlgu2c6nc4Y9yGdaNp6Yxji0CQARRNT5dTjovP7WqRUoD8hCD4jFwk1I6v HkSpFrUlA9rKzHC30zhO/2EaZiITdyayZNyi9OrzqdBu+cYZ6C+aUtcstv/sGoyCYKS8wHP7ZzdK6 hxcds3WccoeLEvOiNePw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC6uI-0008HY-9e; Wed, 11 Mar 2020 19:20:42 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC6tF-0006GI-JC; Wed, 11 Mar 2020 19:19:39 +0000 Received: by mail-pl1-x644.google.com with SMTP id w12so1524282pll.13; Wed, 11 Mar 2020 12:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pOjQrnVayTgdrET4gCgzOMQ7+VznZ1NPyMucBXzQRTg=; b=eZXdYYUO9MJk8vDBz2ohUHhTlFQ6OUvKe5NJC3wwMup1+78yjzPuD0a1yqr7kKDAzn R6bakE9D6+2lnyfG457Nwws4+THsXyHBMV88kQa77cHLpoisL/FI1o5FbYjjD+Cho972 a/pSRcvr7B/YCgFV1J8wk+jRpXIpqHPrPXkUbPz86UioJj5qwacgDmZn15UmH5MpjSIm NvmTKUXeA4shooBgG2EMsAcLL3Sm7nQ72CXnpIBnlTEibmiT3TrxdnaIeopIbHLfMDA9 iCdUKJsTETkc/0yFfjDjJIJEzpVlInD/58X/THAjQ3ciF01RAOk751kpX86fuzJRi0o3 d2OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pOjQrnVayTgdrET4gCgzOMQ7+VznZ1NPyMucBXzQRTg=; b=Opmn/W2hzzQ+5ZNi+BUApGZ5tpdzLGzq1ng5WBskTdTCYgPGRu/xpOOwI4Y0I+n697 HwT4XTeFAGAuS8LxsTZX3/Pm662jqcxD9tYWDslz5zEIORpI2czzuS2U9fuO7UE7YFyY wFSs4b+WTTuqafmSaXQ/fY092OxUCVuRpmKZ3F0g5BaZVBawA60JGRsI9vqJtmkDNxCp F6Kuvtqa8nCzpIGJeYIpncYuip7uPzBJ+rxSt79vs/B79OQ84hzg6PeGsjx/bXhNMKC0 OKo2c6BLhSdQpYHR2/VlnyLFxR42JohpnqekVejz6UAp/zYZXacu/QC2jdLEepBFzezH cC8A== X-Gm-Message-State: ANhLgQ1jhFYPxlw5Ir00MZPdGnivFQD0C7yxT6RwB3HB88PCSPLs59A8 qFJKH6YJlhgLth5f56PApnw= X-Google-Smtp-Source: ADFU+vsSzPj8KundN3q85Ksdo5biFKHHfX+UdUbQyTZOldP1FMJEG8vyFDHt7yRgWjL+jYyHW5T0Zg== X-Received: by 2002:a17:90b:1a8b:: with SMTP id ng11mr201893pjb.173.1583954376003; Wed, 11 Mar 2020 12:19:36 -0700 (PDT) Received: from localhost.localdomain ([103.46.201.94]) by smtp.gmail.com with ESMTPSA id z17sm3792673pff.12.2020.03.11.12.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 12:19:35 -0700 (PDT) From: Aman Sharma To: Subject: [PATCH 4/5] pci: handled return value of platform_get_irq correctly Date: Thu, 12 Mar 2020 00:49:05 +0530 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_121937_770634_732A3E14 X-CRM114-Status: GOOD ( 10.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Karthikeyan Mitran , Marc Gonzalez , linux-pci@vger.kernel.org, Linus Walleij , amanharitsh123@gmail.com, linux-kernel@vger.kernel.org, Matthias Brugger , Ryder Lee , linux-mediatek@lists.infradead.org, Thomas Petazzoni , Bjorn Helgaas , Mans Rullgard , Hou Zhiqiang , linux-arm-kernel@lists.infradead.org, Andrew Murray Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Signed-off-by: Aman Sharma --- drivers/pci/controller/pcie-tango.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-tango.c b/drivers/pci/controller/pcie-tango.c index 21a208da3f59..18c2c4313eb5 100644 --- a/drivers/pci/controller/pcie-tango.c +++ b/drivers/pci/controller/pcie-tango.c @@ -273,9 +273,9 @@ static int tango_pcie_probe(struct platform_device *pdev) writel_relaxed(0, pcie->base + SMP8759_ENABLE + offset); virq = platform_get_irq(pdev, 1); - if (virq <= 0) { + if (virq < 0) { dev_err(dev, "Failed to map IRQ\n"); - return -ENXIO; + return virq; } irq_dom = irq_domain_create_linear(fwnode, MSI_MAX, &dom_ops, pcie); -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel