From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:33472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL8J3-0000yL-PS for qemu-devel@nongnu.org; Mon, 29 Apr 2019 11:35:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hL8J2-0004la-Oq for qemu-devel@nongnu.org; Mon, 29 Apr 2019 11:35:01 -0400 References: <20190418180057.3593-1-thuth@redhat.com> <20190418180057.3593-17-thuth@redhat.com> <98855a34-ff5a-896f-7959-480b89d62833@redhat.com> From: Thomas Huth Message-ID: Date: Mon, 29 Apr 2019 17:34:26 +0200 MIME-Version: 1.0 In-Reply-To: <98855a34-ff5a-896f-7959-480b89d62833@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 16/29] hw/arm: Express dependencies of the virt machine with Kconfig List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , yang.zhong@intel.com, Peter Maydell , qemu-devel@nongnu.org, pbonzini@redhat.com Cc: "Michael S. Tsirkin" , Gerd Hoffmann , "Edgar E . Iglesias" , Jean-Christophe Dubois , Rob Herring , qemu-block@nongnu.org, Andrey Smirnov , Joel Stanley , Antony Pavlov , Alistair Francis , Beniamino Galvani , qemu-arm@nongnu.org, Peter Chubb , Cedric Le Goater , John Snow , Andrew Jeffery , Philippe Mathieu-Daude , Subbaraya Sundeep , Igor Mitsyanko , Jan Kiszka On 25/04/2019 17.53, Philippe Mathieu-Daud=C3=A9 wrote: > Hi Thomas, >=20 > On 4/18/19 8:00 PM, Thomas Huth wrote: >> Dependencies have been determined by looking at hw/arm/virt.c >> >> Signed-off-by: Thomas Huth >> --- >> default-configs/arm-softmmu.mak | 11 +---------- >> hw/arm/Kconfig | 19 +++++++++++++++++++ >> hw/arm/Makefile.objs | 3 ++- >> 3 files changed, 22 insertions(+), 11 deletions(-) >> >> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-sof= tmmu.mak >> index 2580584281..f440a2b1cd 100644 >> --- a/default-configs/arm-softmmu.mak >> +++ b/default-configs/arm-softmmu.mak >> @@ -6,6 +6,7 @@ CONFIG_ARM_V7M=3Dy >> # CONFIG_PCI_DEVICES=3Dn >> # CONFIG_TEST_DEVICES=3Dn >> =20 >> +CONFIG_ARM_VIRT=3Dy >> CONFIG_EXYNOS4=3Dy >> CONFIG_HIGHBANK=3Dy >> CONFIG_INTEGRATOR=3Dy >> @@ -32,8 +33,6 @@ CONFIG_VGA=3Dy >> CONFIG_SSI_M25P80=3Dy >> CONFIG_ALLWINNER_EMAC=3Dy >> CONFIG_IMX_FEC=3Dy >> -CONFIG_PLATFORM_BUS=3Dy >> -CONFIG_VIRTIO_MMIO=3Dy >> =20 >> CONFIG_NETDUINO2=3Dy >> =20 >> @@ -68,9 +67,6 @@ CONFIG_IOTKIT_SYSINFO=3Dy >> CONFIG_ARMSSE_CPUID=3Dy >> CONFIG_ARMSSE_MHU=3Dy >> =20 >> -CONFIG_PCI_EXPRESS=3Dy >> -CONFIG_PCI_EXPRESS_GENERIC_BRIDGE=3Dy >> - >> CONFIG_ALLWINNER_A10_PIT=3Dy >> CONFIG_ALLWINNER_A10_PIC=3Dy >> CONFIG_ALLWINNER_A10=3Dy >> @@ -86,10 +82,5 @@ CONFIG_PCIE_PORT=3Dy >> CONFIG_XIO3130=3Dy >> CONFIG_IOH3420=3Dy >> CONFIG_I82801B11=3Dy >> -CONFIG_ACPI=3Dy >> -CONFIG_ARM_VIRT=3Dy >> -CONFIG_SMBIOS=3Dy >> -CONFIG_GPIO_KEY=3Dy >> CONFIG_MSF2=3Dy >> -CONFIG_FW_CFG_DMA=3Dy >> CONFIG_PCI_EXPRESS_DESIGNWARE=3Dy >> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig >> index abeaa54d88..4d0febf644 100644 >> --- a/hw/arm/Kconfig >> +++ b/hw/arm/Kconfig >> @@ -1,6 +1,24 @@ >> config ARM_VIRT >> bool >> + imply PCI_DEVICES >=20 > Without -nodefaults I get: > qemu-system-aarch64: Unsupported NIC model: virtio-net-pci > This is expected. Yes, it should still work with "-nic none" or "-nodefaults". >> + imply TEST_DEVICES >> + imply VFIO_AMD_XGBE >> imply VFIO_PLATFORM >> + imply VFIO_XGMAC >> + select A15MPCORE >> + select ACPI >> + select ARM_SMMUV3 >=20 > You forgot to remove ARM_SMMUV3 from default-configs/aarch64-softmmu.ma= k. Good catch! Will fix it in v6. > With it removed: > Reviewed-by: Philippe Mathieu-Daud=C3=A9 Thanks! Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB56CC43219 for ; Mon, 29 Apr 2019 15:36:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9F4F20675 for ; Mon, 29 Apr 2019 15:36:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9F4F20675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:59393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL8K0-0001To-V6 for qemu-devel@archiver.kernel.org; Mon, 29 Apr 2019 11:36:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL8J3-0000yL-PS for qemu-devel@nongnu.org; Mon, 29 Apr 2019 11:35:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hL8J2-0004la-Oq for qemu-devel@nongnu.org; Mon, 29 Apr 2019 11:35:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54770) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hL8Ix-0004gh-Bx; Mon, 29 Apr 2019 11:34:55 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0B9B0C04B94F; Mon, 29 Apr 2019 15:34:53 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-111.ams2.redhat.com [10.36.116.111]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC3616C1F8; Mon, 29 Apr 2019 15:34:27 +0000 (UTC) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , yang.zhong@intel.com, Peter Maydell , qemu-devel@nongnu.org, pbonzini@redhat.com References: <20190418180057.3593-1-thuth@redhat.com> <20190418180057.3593-17-thuth@redhat.com> <98855a34-ff5a-896f-7959-480b89d62833@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzRxUaG9tYXMgSHV0 aCA8dGguaHV0aEBnbXguZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIX gAUCUfuWKwIZAQAKCRAu2dd0/nAttbe/EACb9hafyOb2FmhUqeAiBORSsUifFacQ7laVjcgR I4um8CSHvxijYftpkM2EdAtmXIKgbNDpQoXcWLXB9lu9mLgTO4DVT00TRR65ikn3FCWcyT74 ENTOzRKyKLsDCjhXKPblTPIQbYAUCOWElcyAPm0ERd62fA/rKNxgIiNo/l4UODOMoOJm2/Ox ZoTckW68Eqv7k9L7m7j+Hn3hoDTjAmcCBJt+j7pOhzWvCbqoNOIH8C8qvPaNlrba+R/K6jkO 6jZkTbYQpGIofEQJ/TNn38IsNGpI1ALTHWFtoMxp3j2Imz0REO6dRE2fHRN8sVlHgkoeGhmY NbDsDE1jFQOEObFnu0euk//7BXU7tGOHckVAZ8T1smiRPHfQU7UEH2a/grndxJ+PNeM5w7n2 l+FN3cf2KgPotCK2s9MjSdZA7C5e3rFYO8lqiqTJKvc62vqp3e7B0Kjyy5/QtzSOejBij2QL xkKSFNtxIz4MtuxN8e3IDQNxsKry3nF7R4MDvouXlMo6wP9KuyNWb+vFJt9GtbgfDMIFVamp ZfhEWzWRJH4VgksENA4K/BzjEHCcbTUb1TFsiB1VRnBPJ0SqlvifnfKk6HcpkDk6Pg8Q5FOJ gbNHrdgXsm+m/9GF2zUUr+rOlhVbK23TUqKqPfwnD7uxjpakVcJnsVCFqJpZi1F/ga9IN87B TQRR+3lMARAAtp831HniPHb9AuKq3wj83ujZK8lH5RLrfVsB4X1wi47bwo56BqhXpR/zxPTR eOFT0gnbw9UkphVc7uk/alnXMDEmgvnuxv89PwIQX6k3qLABeV7ykJQG/WT5HQ6+2DdGtVw3 2vjYAPiWQeETsgWRRQMDR0/hwp8s8tL/UodwYCScH6Vxx9pdy353L1fK4Bb9G73a+9FPjp9l x+WwKTsltVqSBuSjyZQ3c3EE8qbTidXZxB38JwARH8yN3TX+t65cbBqLl/zRUUUTapHQpUEd yoAsHIml32e4q+3xdLtTdlLi7FgPBItSazcqZPjEcYW73UAuLcmQmfJlQ5PkDiuqcitn+KzH /1pqsTU7QFZjbmSMJyXY0TDErOFuMOjf20b6arcpEqse1V3IKrb+nqqA2azboRm3pEANLAJw iVTwK3qwGRgK5ut6N/Znv20VEHkFUsRAZoOusrIRfR5HFDxlXguAdEz8M/hxXFYYXqOoaCYy 6pJxTjy0Y/tIfmS/g9Bnp8qg9wsrsnk0+XRnDVPak++G3Uq9tJPwpJbyO0vcqEI3vAXkAB7X VXLzvFwi66RrsPUoDkuzj+aCNumtOePDOCpXQGPpKl+l1aYRMN/+lNSk3+1sVuc2C07WnYyE gV/cbEVklPmKrNwu6DeUyD0qI/bVzKMWZAiB1r56hsGeyYcAEQEAAcLBXwQYAQIACQUCUft5 TAIbDAAKCRAu2dd0/nAttYTwEACLAS/THRqXRKb17PQmKwZHerUvZm2klo+lwQ3wNQBHUJAT p2R9ULexyXrJPqjUpy7+voz+FcKiuQBTKyieiIxO46oMxsbXGZ70o3gxjxdYdgimUD6U8PPd JH8tfAL4BR5FZNjspcnscN2jgbF4OrpDeOLyBaj6HPmElNPtECHWCaf1xbIFsZxSDGMA6cUh 0uX3Q8VI7JN1AR2cfiIRY7NrIlWYucJxyKjO3ivWm69nCtsHiJ0wcF8KlVo7F2eLaufo0K8A ynL8SHMF3VEyxsXOP2f1UR9T2Ur30MXcTBpjUxml1TX3RWY5uH89Js/jlIugBwuAmacJ7JYh lTg6sF/GNc4nPb4kk2yktNWTade+TzsllYlJPaorD2Qe8qX0iFUhFC6y9+O6mP4ZvWoYapp9 ezYNuebMgEr93ob1+4sFg3812wNP01WqsGtWCJHnPv/JoonFdMzD/bIkXGEJMk6ks2kxQQZq g6Ik/s/vxOfao/xCn8nHt7GwvVy41795hzK6tbSl+BuyCRp0vfPRP34OnK7+jR2nvQpJu/pU rCELuGwT9hsYkUPjVd4lfylN3mzEc6iAv/wwjsc0DRTSQCpXT3v2ymTAsRKrVaEZLibTXaf+ WslxWek3xNYRiqwwWAJuL652eAlxUgQ5ZS+fXBRTiQpJ+F26I/2lccScRd9G5w== Organization: Red Hat Message-ID: Date: Mon, 29 Apr 2019 17:34:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <98855a34-ff5a-896f-7959-480b89d62833@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 29 Apr 2019 15:34:53 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH for-QEMU-4.1 v5 16/29] hw/arm: Express dependencies of the virt machine with Kconfig X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Jan Kiszka , Igor Mitsyanko , qemu-block@nongnu.org, "Michael S. Tsirkin" , Andrey Smirnov , Alistair Francis , Philippe Mathieu-Daude , Jean-Christophe Dubois , Beniamino Galvani , Andrew Jeffery , Cedric Le Goater , qemu-arm@nongnu.org, Peter Chubb , Gerd Hoffmann , Antony Pavlov , "Edgar E . Iglesias" , Subbaraya Sundeep , John Snow , Joel Stanley Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190429153426.SEtyxLQAilsTGXNIXgNXQYuBhfLdjMTqMfpBnFtAgoU@z> On 25/04/2019 17.53, Philippe Mathieu-Daud=C3=A9 wrote: > Hi Thomas, >=20 > On 4/18/19 8:00 PM, Thomas Huth wrote: >> Dependencies have been determined by looking at hw/arm/virt.c >> >> Signed-off-by: Thomas Huth >> --- >> default-configs/arm-softmmu.mak | 11 +---------- >> hw/arm/Kconfig | 19 +++++++++++++++++++ >> hw/arm/Makefile.objs | 3 ++- >> 3 files changed, 22 insertions(+), 11 deletions(-) >> >> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-sof= tmmu.mak >> index 2580584281..f440a2b1cd 100644 >> --- a/default-configs/arm-softmmu.mak >> +++ b/default-configs/arm-softmmu.mak >> @@ -6,6 +6,7 @@ CONFIG_ARM_V7M=3Dy >> # CONFIG_PCI_DEVICES=3Dn >> # CONFIG_TEST_DEVICES=3Dn >> =20 >> +CONFIG_ARM_VIRT=3Dy >> CONFIG_EXYNOS4=3Dy >> CONFIG_HIGHBANK=3Dy >> CONFIG_INTEGRATOR=3Dy >> @@ -32,8 +33,6 @@ CONFIG_VGA=3Dy >> CONFIG_SSI_M25P80=3Dy >> CONFIG_ALLWINNER_EMAC=3Dy >> CONFIG_IMX_FEC=3Dy >> -CONFIG_PLATFORM_BUS=3Dy >> -CONFIG_VIRTIO_MMIO=3Dy >> =20 >> CONFIG_NETDUINO2=3Dy >> =20 >> @@ -68,9 +67,6 @@ CONFIG_IOTKIT_SYSINFO=3Dy >> CONFIG_ARMSSE_CPUID=3Dy >> CONFIG_ARMSSE_MHU=3Dy >> =20 >> -CONFIG_PCI_EXPRESS=3Dy >> -CONFIG_PCI_EXPRESS_GENERIC_BRIDGE=3Dy >> - >> CONFIG_ALLWINNER_A10_PIT=3Dy >> CONFIG_ALLWINNER_A10_PIC=3Dy >> CONFIG_ALLWINNER_A10=3Dy >> @@ -86,10 +82,5 @@ CONFIG_PCIE_PORT=3Dy >> CONFIG_XIO3130=3Dy >> CONFIG_IOH3420=3Dy >> CONFIG_I82801B11=3Dy >> -CONFIG_ACPI=3Dy >> -CONFIG_ARM_VIRT=3Dy >> -CONFIG_SMBIOS=3Dy >> -CONFIG_GPIO_KEY=3Dy >> CONFIG_MSF2=3Dy >> -CONFIG_FW_CFG_DMA=3Dy >> CONFIG_PCI_EXPRESS_DESIGNWARE=3Dy >> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig >> index abeaa54d88..4d0febf644 100644 >> --- a/hw/arm/Kconfig >> +++ b/hw/arm/Kconfig >> @@ -1,6 +1,24 @@ >> config ARM_VIRT >> bool >> + imply PCI_DEVICES >=20 > Without -nodefaults I get: > qemu-system-aarch64: Unsupported NIC model: virtio-net-pci > This is expected. Yes, it should still work with "-nic none" or "-nodefaults". >> + imply TEST_DEVICES >> + imply VFIO_AMD_XGBE >> imply VFIO_PLATFORM >> + imply VFIO_XGMAC >> + select A15MPCORE >> + select ACPI >> + select ARM_SMMUV3 >=20 > You forgot to remove ARM_SMMUV3 from default-configs/aarch64-softmmu.ma= k. Good catch! Will fix it in v6. > With it removed: > Reviewed-by: Philippe Mathieu-Daud=C3=A9 Thanks! Thomas