From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 31/32] drm/i915/execlists: Virtual engine bonding Date: Thu, 18 Apr 2019 09:57:43 +0100 Message-ID: References: <20190417075657.19456-1-chris@chris-wilson.co.uk> <20190417075657.19456-31-chris@chris-wilson.co.uk> <155557065786.3649.15598309807699098369@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id B96106E0FD for ; Thu, 18 Apr 2019 08:57:45 +0000 (UTC) In-Reply-To: <155557065786.3649.15598309807699098369@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzA0LzIwMTkgMDc6NTcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTA0LTE4IDA3OjQ3OjUxKQo+Pgo+PiBPbiAxNy8wNC8yMDE5IDA4OjU2 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiArc3RhdGljIHZvaWQKPj4+ICt2aXJ0dWFsX2JvbmRf ZXhlY3V0ZShzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSwgc3RydWN0IGRtYV9mZW5jZSAqc2lnbmFs KQo+Pj4gK3sKPj4+ICsgICAgIHN0cnVjdCB2aXJ0dWFsX2VuZ2luZSAqdmUgPSB0b192aXJ0dWFs X2VuZ2luZShycS0+ZW5naW5lKTsKPj4+ICsgICAgIHN0cnVjdCB2ZV9ib25kICpib25kOwo+Pj4g Kwo+Pj4gKyAgICAgYm9uZCA9IHZpcnR1YWxfZmluZF9ib25kKHZlLCB0b19yZXF1ZXN0KHNpZ25h bCktPmVuZ2luZSk7Cj4+PiArICAgICBpZiAoYm9uZCkgewo+Pj4gKyAgICAgICAgICAgICBpbnRl bF9lbmdpbmVfbWFza190IG9sZCwgbmV3LCBjbXA7Cj4+PiArCj4+PiArICAgICAgICAgICAgIGNt cCA9IFJFQURfT05DRShycS0+ZXhlY3V0aW9uX21hc2spOwo+Pj4gKyAgICAgICAgICAgICBkbyB7 Cj4+PiArICAgICAgICAgICAgICAgICAgICAgb2xkID0gY21wOwo+Pj4gKyAgICAgICAgICAgICAg ICAgICAgIG5ldyA9IGNtcCAmIGJvbmQtPnNpYmxpbmdfbWFzazsKPj4+ICsgICAgICAgICAgICAg fSB3aGlsZSAoKGNtcCA9IGNtcHhjaGcoJnJxLT5leGVjdXRpb25fbWFzaywgb2xkLCBuZXcpKSAh PSBvbGQpOwo+Pgo+PiBMb29wIGltcGxpZXMgc29tZW9uZSBlbHNlIG1pZ2h0IGJlIG1vZGlmeWlu ZyB0aGUgcnEtPmV4ZWN1dGlvbl9tYXNrIGluCj4+IHBhcmFsbGVsPwo+IAo+IFRoZXJlJ3Mgbm90 aGluZyB0aGF0IHByZXZlbnRzIHRoZXJlIGJlaW5nIG11bHRpcGxlIGJvbmRzIGJlaW5nCj4gZXhl Y3V0ZWQgc2ltdWx0YW5lb3VzbHkgKG90aGVyIHRoYW4gcHJhY3RpY2FsaXR5KS4gVGhlcmUncyBh bHNvIG5vdGhpbmcKPiB0aGF0IHNheXMgdGhpcyBzaG91bGQgYmUgdGhlIG9ubHkgd2F5IHRvIG1v ZGlmeSBycS0+ZXhlY3V0aW9uX21hc2sgaW4KPiB0aGUgZnV0dXJlLgoKQnV0IHJlcXVlc3QgaXMg b25lLCBob3cgY2FuIGl0IGJlIHN1Ym1pdHRlZCBtdWx0aXBsZSB0aW1lcyBzaW11bHRhbmVvdXNs eT8KCj4+PiArc3RhdGljIGludAo+Pj4gK3NldF9lbmdpbmVzX19ib25kKHN0cnVjdCBpOTE1X3Vz ZXJfZXh0ZW5zaW9uIF9fdXNlciAqYmFzZSwgdm9pZCAqZGF0YSkKPj4+ICt7Cj4+PiArICAgICBz dHJ1Y3QgaTkxNV9jb250ZXh0X2VuZ2luZXNfYm9uZCBfX3VzZXIgKmV4dCA9Cj4+PiArICAgICAg ICAgICAgIGNvbnRhaW5lcl9vZl91c2VyKGJhc2UsIHR5cGVvZigqZXh0KSwgYmFzZSk7Cj4+PiAr ICAgICBjb25zdCBzdHJ1Y3Qgc2V0X2VuZ2luZXMgKnNldCA9IGRhdGE7Cj4+PiArICAgICBzdHJ1 Y3QgaW50ZWxfZW5naW5lX2NzICp2aXJ0dWFsOwo+Pj4gKyAgICAgc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqbWFzdGVyOwo+Pj4gKyAgICAgdTE2IGNsYXNzLCBpbnN0YW5jZTsKPj4+ICsgICAgIHUx NiBpZHgsIG51bV9ib25kczsKPj4+ICsgICAgIGludCBlcnIsIG47Cj4+PiArCj4+PiArICAgICBp ZiAoZ2V0X3VzZXIoaWR4LCAmZXh0LT52aXJ0dWFsX2luZGV4KSkKPj4+ICsgICAgICAgICAgICAg cmV0dXJuIC1FRkFVTFQ7Cj4+PiArCj4+PiArICAgICBpZiAoaWR4ID49IHNldC0+ZW5naW5lcy0+ bnVtX2VuZ2luZXMpIHsKPj4+ICsgICAgICAgICAgICAgRFJNX0RFQlVHKCJJbnZhbGlkIGluZGV4 IGZvciB2aXJ0dWFsIGVuZ2luZTogJWQgPj0gJWRcbiIsCj4+PiArICAgICAgICAgICAgICAgICAg ICAgICBpZHgsIHNldC0+ZW5naW5lcy0+bnVtX2VuZ2luZXMpOwo+Pj4gKyAgICAgICAgICAgICBy ZXR1cm4gLUVJTlZBTDsKPj4+ICsgICAgIH0KPj4+ICsKPj4+ICsgICAgIGlkeCA9IGFycmF5X2lu ZGV4X25vc3BlYyhpZHgsIHNldC0+ZW5naW5lcy0+bnVtX2VuZ2luZXMpOwo+Pj4gKyAgICAgaWYg KCFzZXQtPmVuZ2luZXMtPmVuZ2luZXNbaWR4XSkgewo+Pj4gKyAgICAgICAgICAgICBEUk1fREVC VUcoIkludmFsaWQgZW5naW5lIGF0ICVkXG4iLCBpZHgpOwo+Pj4gKyAgICAgICAgICAgICByZXR1 cm4gLUVJTlZBTDsKPj4+ICsgICAgIH0KPj4+ICsKPj4+ICsgICAgIC8qCj4+PiArICAgICAgKiBB IG5vbi12aXJ0dWFsIGVuZ2luZSBoYXMgMCBzaWJsaW5ncyB0byBjaG9vc2UgYmV0d2VlbjsgYW5k IHN1Ym1pdAo+Pj4gKyAgICAgICogZmVuY2Ugd2lsbCBhbHdheXMgYmUgZGlyZWN0ZWQgdG8gdGhl IG9uZSBlbmdpbmUuCj4+PiArICAgICAgKi8KPj4+ICsgICAgIHZpcnR1YWwgPSBzZXQtPmVuZ2lu ZXMtPmVuZ2luZXNbaWR4XS0+ZW5naW5lOwo+Pj4gKyAgICAgaWYgKCFpbnRlbF9lbmdpbmVfaXNf dmlydHVhbCh2aXJ0dWFsKSkKPj4+ICsgICAgICAgICAgICAgcmV0dXJuIDA7Cj4+Cj4+IEhtbSB3 b3VsZG4ndCB3ZSBzdHJpY3RseSBzcGVha2luZyBuZWVkIHRvIGRpc3Rpbmd1aXNoIGJldHdlZW4g dUFQSQo+PiBlcnJvcnMgYW5kIGF1dG8tbWFnaWMtc2luZ2xlLXZlbmctcmVwbGFjZW1lbnQ/IExh dHRlciBpcyBPSyB0byByZXR1cm4KPj4gc3VjY2VzcywgYnV0IGZvcm1lciBzaG91bGQgYmUgcmVw b3J0ZWQgYXMgLUVJTlZBTCBJIHRoaW5rLgo+IAo+IElzIGl0IGEgdUFQSSBlcnJvciBpZiBpdCB3 b3Jrcz8gOikKCkl0IHdvcmtzIGJ1dCB3aGF0IGlzIHRoZSBwcmFjdGljYWwgdXNlPyBJdCBtb3Jl IHNpZ25hbHMgdXNlcnNwYWNlIGdvdCAKaXQncyBjb25maWd1cmF0aW9uIHdyb25nIGFuZCBpZiB3 ZSBzaWxlbnRseSBhY2NlcHQgaXQgZ2V0cyBtb3JlIApkaWZmaWN1bHQgdG8gZmlndXJlIG91dC4K Cj4gCj4+PiArCj4+PiArICAgICBlcnIgPSBjaGVja191c2VyX21ieigmZXh0LT5mbGFncyk7Cj4+ PiArICAgICBpZiAoZXJyKQo+Pj4gKyAgICAgICAgICAgICByZXR1cm4gZXJyOwo+Pj4gKwo+Pj4g KyAgICAgZm9yIChuID0gMDsgbiA8IEFSUkFZX1NJWkUoZXh0LT5tYno2NCk7IG4rKykgewo+Pj4g KyAgICAgICAgICAgICBlcnIgPSBjaGVja191c2VyX21ieigmZXh0LT5tYno2NFtuXSk7Cj4+PiAr ICAgICAgICAgICAgIGlmIChlcnIpCj4+PiArICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGVy cjsKPj4+ICsgICAgIH0KPj4+ICsKPj4+ICsgICAgIGlmIChnZXRfdXNlcihjbGFzcywgJmV4dC0+ bWFzdGVyX2NsYXNzKSkKPj4+ICsgICAgICAgICAgICAgcmV0dXJuIC1FRkFVTFQ7Cj4+PiArCj4+ PiArICAgICBpZiAoZ2V0X3VzZXIoaW5zdGFuY2UsICZleHQtPm1hc3Rlcl9pbnN0YW5jZSkpCj4+ PiArICAgICAgICAgICAgIHJldHVybiAtRUZBVUxUOwo+Pj4gKwo+Pj4gKyAgICAgbWFzdGVyID0g aW50ZWxfZW5naW5lX2xvb2t1cF91c2VyKHNldC0+Y3R4LT5pOTE1LCBjbGFzcywgaW5zdGFuY2Up Owo+Pj4gKyAgICAgaWYgKCFtYXN0ZXIpIHsKPj4+ICsgICAgICAgICAgICAgRFJNX0RFQlVHKCJV bnJlY29nbmlzZWQgbWFzdGVyIGVuZ2luZTogeyBjbGFzczolZCwgaW5zdGFuY2U6JWQgfVxuIiwK Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGNsYXNzLCBpbnN0YW5jZSk7Cj4+PiArICAgICAg ICAgICAgIHJldHVybiAtRUlOVkFMOwo+Pj4gKyAgICAgfQo+Pj4gKwo+Pj4gKyAgICAgaWYgKGdl dF91c2VyKG51bV9ib25kcywgJmV4dC0+bnVtX2JvbmRzKSkKPj4+ICsgICAgICAgICAgICAgcmV0 dXJuIC1FRkFVTFQ7Cj4+Cj4+IFNob3VsZCBudW1fYm9uZHMgPiB2aXJ0dWFsLT5udW1fc2libGlu Z3MgYmUgYW4gZXJyb3I/Cj4gCj4gVGhleSBjb3VsZCBzcGVjaWZ5IHRoZSBzYW1lIGJvbmQgbXVs dGlwbGUgdGltZXMgZm9yIHdoYXRldmVyIHJlYXNvbiAoYW5kCj4gcHJvYmFibHkgc2hvdWxkIGFs bG93IHNraXBwaW5nIE5PTkU/KSwgaWYgdGhlIHRhcmdldCBkb2Vzbid0IGV4aXN0IHRoYXQncwo+ IGRlZmluaXRlbHkgYW4gZXJyb3IuCgpTbyB3aGljaCBib25kIHdlIHBpY2sgaWYgdGhleSBzcGVj aWZ5IG11bHRpcGxlIG9uZXM/IEp1c3QgdGhlIGZpcnN0IG9uZSAKZm91bmQuIEhtIGFjdHVhbGx5 IEkgd2FzIHRoaW5raW5nIGFib3V0IG1ha2luZyBzdXJlIGVhY2ggbWFzdGVyIGlzIG9ubHkgCnNw ZWNpZmllZCBvbmNlLCBub3Qgc2libGluZ3MuIEZvciBzaWJsaW5ncyB3ZSBpbmRlZWQgZG8gbm90 IGNhcmUuCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeA==