From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAF95C3A5A0 for ; Mon, 19 Aug 2019 21:03:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83DA12087E for ; Mon, 19 Aug 2019 21:03:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FxoL/ygN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83DA12087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzooV-0007UV-NC for qemu-devel@archiver.kernel.org; Mon, 19 Aug 2019 17:03:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52896) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzomS-0006EN-MH for qemu-devel@nongnu.org; Mon, 19 Aug 2019 17:01:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzomR-00073V-CX for qemu-devel@nongnu.org; Mon, 19 Aug 2019 17:01:32 -0400 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:43119) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzomR-00072C-64 for qemu-devel@nongnu.org; Mon, 19 Aug 2019 17:01:31 -0400 Received: by mail-pf1-x441.google.com with SMTP id v12so1882494pfn.10 for ; Mon, 19 Aug 2019 14:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vGBzrXO7KGpJ/NUWc/Wz8OhRnfw9xF17a3ctMtsK7KU=; b=FxoL/ygNz+Ksftm1RuYm/hG7E+xUwHOeXleAvU5RKlIsyWRQv8RINw3kW0ZJByEwo0 qguqHCPMGOnOa+JMyt2Xwlv2pqzilmdFTcReSsfN6Ms8DIzBRqW1zByU3jMKV6A8MKUd Ey3Co++zv2CtWWhtWKSWRA06PcwxEPwJijUHnQXpmVIriIaWqnF3XwHYCWss8+xa440m W+qxDOjbHZpamKwURVa1T4q7BTMqMydWd9i8NzVovYN2blADLG3kJVQBic4LQgyy3vlX Z06lyjJsf5W39pmQ8zid0Tq07PX/wgluHJ4U9/nidce7U2v5Uo8AzFvmwrpT/uSsFgmQ aH4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vGBzrXO7KGpJ/NUWc/Wz8OhRnfw9xF17a3ctMtsK7KU=; b=Pr4J6Hjcg+5XI4+q/7atUTbCIU3iLsFtay7M2zJt4mRmXacZKJ3Ky1PIPqFKPGwX5r AtbWo5fVVdJY/jMnKQYEmSgOWwu4nOdjLG/gPQ+a8t0sZLa+n+2hS7z0AXxNyNMpMYKB F7mux0qtOZzqYu/DhpoV6jnPsbkSvV8VhPK1DbH40TjhbXjRqTglm37R3ruiBK4odsj0 Gr11AqGe245Q88VmOMVrMV3uly4o1AQxN7DWo9lMvgViaIT2TLlZZeaRnJOhAf9svDRf PYuXZtv2s42UikqYNLbJmMdqi+CPTgBR9gR/lygm+LfYrom0p8P87SfAnvMfrP0P9LdV TDLw== X-Gm-Message-State: APjAAAX/FOmEfFDAw+yRnqq1FqdHGtEQVkU1oGqU8xcqvMEkvfbSsoU3 S3Ed0tqfDP0rAV7ftrgGDqHucA== X-Google-Smtp-Source: APXvYqyxYKmwhkk2+hBSFj74Kf7MG7+XWa94OJ2Sw4xj2uOGNS5PTiiDALcNZLOc7wR94aBemA/2WA== X-Received: by 2002:a65:6104:: with SMTP id z4mr21186266pgu.27.1566248488612; Mon, 19 Aug 2019 14:01:28 -0700 (PDT) Received: from [192.168.1.11] (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id c2sm7562265pjs.13.2019.08.19.14.01.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Aug 2019 14:01:27 -0700 (PDT) To: Paolo Bonzini , Thomas Huth , tony.nguyen@bt.com, qemu-devel@nongnu.org References: <43bc5e07ac614d0e8e740bf6007ff77b@tpw09926dag18e.domain1.systemhost.net> <1565941032362.60179@bt.com> <1b5f5a92-1b75-f0d9-d7bc-4605094ad8e7@redhat.com> <8d8b37c9-3daf-d241-df92-1a5467bca451@redhat.com> <3b983f77-8503-3fcd-7c42-45d0121845e6@redhat.com> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Mon, 19 Aug 2019 14:01:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <3b983f77-8503-3fcd-7c42-45d0121845e6@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::441 Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v7 33/42] exec: Replace device_endian with MemOp X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, peter.maydell@linaro.org, walling@linux.ibm.com, cohuck@redhat.com, jan.kiszka@web.de, sagark@eecs.berkeley.edu, david@redhat.com, green@moxielogic.com, palmer@sifive.com, mark.cave-ayland@ilande.co.uk, i.mitsyanko@gmail.com, keith.busch@intel.com, jcmvbkbc@gmail.com, frederic.konrad@adacore.com, dmitry.fleytman@gmail.com, kraxel@redhat.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, pburton@wavecomp.com, xiaoguangrong.eric@gmail.com, marex@denx.de, robh@kernel.org, hare@suse.com, sstabellini@kernel.org, berto@igalia.com, chouteau@adacore.com, qemu-block@nongnu.org, arikalo@wavecomp.com, jslaby@suse.cz, deller@gmx.de, mst@redhat.com, magnus.damm@gmail.com, lersek@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, mreitz@redhat.com, hpoussin@reactos.org, joel@jms.id.au, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, david@gibson.dropbear.id.au, philmd@redhat.com, jasowang@redhat.com, atar4qemu@gmail.com, antonynpavlov@gmail.com, jiri@resnulli.us, ehabkost@redhat.com, minyard@acm.org, qemu-s390x@nongnu.org, sw@weilnetz.de, alistair@alistair23.me, yuval.shaia@oracle.com, b.galvani@gmail.com, eric.auger@redhat.com, alex.williamson@redhat.com, qemu-arm@nongnu.org, peter.chubb@nicta.com.au, clg@kaod.org, stefanha@redhat.com, marcandre.lureau@redhat.com, shorne@gmail.com, jsnow@redhat.com, rth@twiddle.net, kwolf@redhat.com, qemu-riscv@nongnu.org, proljc@gmail.com, andrew@aj.id.au, claudio.fontana@suse.com, crwulff@gmail.com, laurent@vivier.eu, Andrew.Baumann@microsoft.com, sundeep.lkml@gmail.com, andrew.smirnov@gmail.com, michael@walle.cc, paul.durrant@citrix.com, qemu-ppc@nongnu.org, huth@tuxfamily.org, amarkovic@wavecomp.com, kbastian@mail.uni-paderborn.de, imammedo@redhat.com, jcd@tribudubois.net, aurelien@aurel32.net, stefanb@linux.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/19/19 11:29 AM, Paolo Bonzini wrote: > On 19/08/19 20:28, Paolo Bonzini wrote: >> On 16/08/19 12:12, Thomas Huth wrote: >>> This patch is *huge*, more than 800kB. It keeps being stuck in the the >>> filter of the qemu-s390x list each time you send it. Please: >>> >>> 1) Try to break it up in more digestible pieces, e.g. change only one >>> subsystem at a time (this is also better reviewable by people who are >>> interested in one area) >> >> This is not really possible, since the patch is basically a >> search-and-replace. You could perhaps use some magic >> ("DEVICE_MEMOP_ENDIAN" or something like that) to allow a split, but it >> would introduce more complication than anything else. > > I'm stupid, at this point of the series it _would_ be possible to split > the patch by subsystem. Still not sure it would be actually an advantage. It might be easier to review if we split by symbol, one rename per patch over the entire code base. r~ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C54CFC3A5A0 for ; Mon, 19 Aug 2019 21:01:51 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 918752087E for ; Mon, 19 Aug 2019 21:01:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FxoL/ygN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 918752087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hzomR-000189-Qj; Mon, 19 Aug 2019 21:01:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hzomQ-000184-90 for xen-devel@lists.xenproject.org; Mon, 19 Aug 2019 21:01:30 +0000 X-Inumbo-ID: 83d41de0-c2c4-11e9-b90c-bc764e2007e4 Received: from mail-pg1-x541.google.com (unknown [2607:f8b0:4864:20::541]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 83d41de0-c2c4-11e9-b90c-bc764e2007e4; Mon, 19 Aug 2019 21:01:29 +0000 (UTC) Received: by mail-pg1-x541.google.com with SMTP id n190so1896008pgn.0 for ; Mon, 19 Aug 2019 14:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vGBzrXO7KGpJ/NUWc/Wz8OhRnfw9xF17a3ctMtsK7KU=; b=FxoL/ygNz+Ksftm1RuYm/hG7E+xUwHOeXleAvU5RKlIsyWRQv8RINw3kW0ZJByEwo0 qguqHCPMGOnOa+JMyt2Xwlv2pqzilmdFTcReSsfN6Ms8DIzBRqW1zByU3jMKV6A8MKUd Ey3Co++zv2CtWWhtWKSWRA06PcwxEPwJijUHnQXpmVIriIaWqnF3XwHYCWss8+xa440m W+qxDOjbHZpamKwURVa1T4q7BTMqMydWd9i8NzVovYN2blADLG3kJVQBic4LQgyy3vlX Z06lyjJsf5W39pmQ8zid0Tq07PX/wgluHJ4U9/nidce7U2v5Uo8AzFvmwrpT/uSsFgmQ aH4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vGBzrXO7KGpJ/NUWc/Wz8OhRnfw9xF17a3ctMtsK7KU=; b=H2/EnBwa8cetcRnFWuiB7cyHGtAiroSuSeiQdmNiZeMCqG/fevF9eCP5jQpwq6fKar VZDi5ZrXEw8Ib3hUnbBQP2GRa5MBAZC1n/cFXk4816kCtly23QvZaCx8Ip488KbRtkzY ROQPMyU1gVy8HPowzgAT93MqcQ3Ry4BkOM+TkROG/4c7DkTcT0u/ZL+PtLmkegD0ORiD jLfHDzdDq3jT0X4hbsC8SjoEbTIIDjPkYE0hDkClMUliS1rLS32gIKYfUho+BbNzofhH L4iUJpShquysTEJGqRdoctorrMi+osvpp3/Nr6+MAgDLfRj7sfZNTLk3l3ybLADp1rod Jd4A== X-Gm-Message-State: APjAAAWDx3hO4T9w2XCmt5q3gJdA5krqOg6/xImlmvvYP6KdTs2OlGqO WsiJwCBebqm78X00hN+yEmJkBA== X-Google-Smtp-Source: APXvYqyxYKmwhkk2+hBSFj74Kf7MG7+XWa94OJ2Sw4xj2uOGNS5PTiiDALcNZLOc7wR94aBemA/2WA== X-Received: by 2002:a65:6104:: with SMTP id z4mr21186266pgu.27.1566248488612; Mon, 19 Aug 2019 14:01:28 -0700 (PDT) Received: from [192.168.1.11] (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id c2sm7562265pjs.13.2019.08.19.14.01.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Aug 2019 14:01:27 -0700 (PDT) To: Paolo Bonzini , Thomas Huth , tony.nguyen@bt.com, qemu-devel@nongnu.org References: <43bc5e07ac614d0e8e740bf6007ff77b@tpw09926dag18e.domain1.systemhost.net> <1565941032362.60179@bt.com> <1b5f5a92-1b75-f0d9-d7bc-4605094ad8e7@redhat.com> <8d8b37c9-3daf-d241-df92-1a5467bca451@redhat.com> <3b983f77-8503-3fcd-7c42-45d0121845e6@redhat.com> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Mon, 19 Aug 2019 14:01:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <3b983f77-8503-3fcd-7c42-45d0121845e6@redhat.com> Content-Language: en-US Subject: Re: [Xen-devel] [Qemu-devel] [qemu-s390x] [PATCH v7 33/42] exec: Replace device_endian with MemOp X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, peter.maydell@linaro.org, walling@linux.ibm.com, cohuck@redhat.com, jan.kiszka@web.de, sagark@eecs.berkeley.edu, david@redhat.com, green@moxielogic.com, palmer@sifive.com, mark.cave-ayland@ilande.co.uk, i.mitsyanko@gmail.com, keith.busch@intel.com, jcmvbkbc@gmail.com, frederic.konrad@adacore.com, dmitry.fleytman@gmail.com, kraxel@redhat.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, pburton@wavecomp.com, xiaoguangrong.eric@gmail.com, marex@denx.de, robh@kernel.org, hare@suse.com, sstabellini@kernel.org, berto@igalia.com, chouteau@adacore.com, qemu-block@nongnu.org, arikalo@wavecomp.com, jslaby@suse.cz, deller@gmx.de, mst@redhat.com, magnus.damm@gmail.com, lersek@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, mreitz@redhat.com, hpoussin@reactos.org, joel@jms.id.au, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, david@gibson.dropbear.id.au, philmd@redhat.com, jasowang@redhat.com, atar4qemu@gmail.com, antonynpavlov@gmail.com, jiri@resnulli.us, ehabkost@redhat.com, minyard@acm.org, qemu-s390x@nongnu.org, sw@weilnetz.de, alistair@alistair23.me, yuval.shaia@oracle.com, b.galvani@gmail.com, eric.auger@redhat.com, alex.williamson@redhat.com, qemu-arm@nongnu.org, peter.chubb@nicta.com.au, clg@kaod.org, stefanha@redhat.com, marcandre.lureau@redhat.com, shorne@gmail.com, jsnow@redhat.com, rth@twiddle.net, kwolf@redhat.com, qemu-riscv@nongnu.org, proljc@gmail.com, andrew@aj.id.au, claudio.fontana@suse.com, crwulff@gmail.com, laurent@vivier.eu, Andrew.Baumann@microsoft.com, sundeep.lkml@gmail.com, andrew.smirnov@gmail.com, michael@walle.cc, paul.durrant@citrix.com, qemu-ppc@nongnu.org, huth@tuxfamily.org, amarkovic@wavecomp.com, kbastian@mail.uni-paderborn.de, imammedo@redhat.com, jcd@tribudubois.net, aurelien@aurel32.net, stefanb@linux.ibm.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gOC8xOS8xOSAxMToyOSBBTSwgUGFvbG8gQm9uemluaSB3cm90ZToKPiBPbiAxOS8wOC8xOSAy MDoyOCwgUGFvbG8gQm9uemluaSB3cm90ZToKPj4gT24gMTYvMDgvMTkgMTI6MTIsIFRob21hcyBI dXRoIHdyb3RlOgo+Pj4gVGhpcyBwYXRjaCBpcyAqaHVnZSosIG1vcmUgdGhhbiA4MDBrQi4gSXQg a2VlcHMgYmVpbmcgc3R1Y2sgaW4gdGhlIHRoZQo+Pj4gZmlsdGVyIG9mIHRoZSBxZW11LXMzOTB4 IGxpc3QgZWFjaCB0aW1lIHlvdSBzZW5kIGl0LiBQbGVhc2U6Cj4+Pgo+Pj4gMSkgVHJ5IHRvIGJy ZWFrIGl0IHVwIGluIG1vcmUgZGlnZXN0aWJsZSBwaWVjZXMsIGUuZy4gY2hhbmdlIG9ubHkgb25l Cj4+PiBzdWJzeXN0ZW0gYXQgYSB0aW1lICh0aGlzIGlzIGFsc28gYmV0dGVyIHJldmlld2FibGUg YnkgcGVvcGxlIHdobyBhcmUKPj4+IGludGVyZXN0ZWQgaW4gb25lIGFyZWEpCj4+Cj4+IFRoaXMg aXMgbm90IHJlYWxseSBwb3NzaWJsZSwgc2luY2UgdGhlIHBhdGNoIGlzIGJhc2ljYWxseSBhCj4+ IHNlYXJjaC1hbmQtcmVwbGFjZS4gIFlvdSBjb3VsZCBwZXJoYXBzIHVzZSBzb21lIG1hZ2ljCj4+ ICgiREVWSUNFX01FTU9QX0VORElBTiIgb3Igc29tZXRoaW5nIGxpa2UgdGhhdCkgdG8gYWxsb3cg YSBzcGxpdCwgYnV0IGl0Cj4+IHdvdWxkIGludHJvZHVjZSBtb3JlIGNvbXBsaWNhdGlvbiB0aGFu IGFueXRoaW5nIGVsc2UuCj4gCj4gSSdtIHN0dXBpZCwgYXQgdGhpcyBwb2ludCBvZiB0aGUgc2Vy aWVzIGl0IF93b3VsZF8gYmUgcG9zc2libGUgdG8gc3BsaXQKPiB0aGUgcGF0Y2ggYnkgc3Vic3lz dGVtLiAgU3RpbGwgbm90IHN1cmUgaXQgd291bGQgYmUgYWN0dWFsbHkgYW4gYWR2YW50YWdlLgoK SXQgbWlnaHQgYmUgZWFzaWVyIHRvIHJldmlldyBpZiB3ZSBzcGxpdCBieSBzeW1ib2wsIG9uZSBy ZW5hbWUgcGVyIHBhdGNoIG92ZXIKdGhlIGVudGlyZSBjb2RlIGJhc2UuCgoKcn4KCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5n IGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJv amVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1hzomU-0006Fa-PP for mharc-qemu-riscv@gnu.org; Mon, 19 Aug 2019 17:01:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52879) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzomS-0006EH-87 for qemu-riscv@nongnu.org; Mon, 19 Aug 2019 17:01:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzomR-00072y-97 for qemu-riscv@nongnu.org; Mon, 19 Aug 2019 17:01:32 -0400 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]:41723) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzomP-000725-RK for qemu-riscv@nongnu.org; Mon, 19 Aug 2019 17:01:31 -0400 Received: by mail-pg1-x541.google.com with SMTP id x15so1880991pgg.8 for ; Mon, 19 Aug 2019 14:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vGBzrXO7KGpJ/NUWc/Wz8OhRnfw9xF17a3ctMtsK7KU=; b=FxoL/ygNz+Ksftm1RuYm/hG7E+xUwHOeXleAvU5RKlIsyWRQv8RINw3kW0ZJByEwo0 qguqHCPMGOnOa+JMyt2Xwlv2pqzilmdFTcReSsfN6Ms8DIzBRqW1zByU3jMKV6A8MKUd Ey3Co++zv2CtWWhtWKSWRA06PcwxEPwJijUHnQXpmVIriIaWqnF3XwHYCWss8+xa440m W+qxDOjbHZpamKwURVa1T4q7BTMqMydWd9i8NzVovYN2blADLG3kJVQBic4LQgyy3vlX Z06lyjJsf5W39pmQ8zid0Tq07PX/wgluHJ4U9/nidce7U2v5Uo8AzFvmwrpT/uSsFgmQ aH4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vGBzrXO7KGpJ/NUWc/Wz8OhRnfw9xF17a3ctMtsK7KU=; b=pi6yxSXm78+Kj1friecFD1YxTJXSor3ScBm4lEWCOerWPyCqjGhd3XrLnr3woFakI4 jrzF92lHkTUWeoYVrcnHFHnrbSnVlrL95CXtCHRqaHajhxsX+0CHz+wpi3uDJNmKhTBj XayYVdNzMwD2DG3KUqOGWs8kXnNQHJ8XzrmiRyTu2rVJaMZAusn3cdu7qpPVaGBt3GsT jRHjpsRqUId0qMKO1soUwfiWLGm0kinzJcQopLYh2RrSglSRlEaHkZi2jzoZS5//TP6N pR50HOUJWnW2xTigiaHUvlimkci74wjKO5KPnaj6yvhpuoJmz8ofFodQV4r4Uei9e6tv dsQg== X-Gm-Message-State: APjAAAX8TM3yJx3P0PmMFz5utl0Pic2pJMn9HCBH+yCb3wpQayGS4qT7 fOaJycsSujU17n0EXJh4yqcH/w== X-Google-Smtp-Source: APXvYqyxYKmwhkk2+hBSFj74Kf7MG7+XWa94OJ2Sw4xj2uOGNS5PTiiDALcNZLOc7wR94aBemA/2WA== X-Received: by 2002:a65:6104:: with SMTP id z4mr21186266pgu.27.1566248488612; Mon, 19 Aug 2019 14:01:28 -0700 (PDT) Received: from [192.168.1.11] (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id c2sm7562265pjs.13.2019.08.19.14.01.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Aug 2019 14:01:27 -0700 (PDT) To: Paolo Bonzini , Thomas Huth , tony.nguyen@bt.com, qemu-devel@nongnu.org Cc: frederic.konrad@adacore.com, berto@igalia.com, qemu-block@nongnu.org, arikalo@wavecomp.com, pasic@linux.ibm.com, hpoussin@reactos.org, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, philmd@redhat.com, green@moxielogic.com, jiri@resnulli.us, ehabkost@redhat.com, b.galvani@gmail.com, eric.auger@redhat.com, alex.williamson@redhat.com, stefanha@redhat.com, jsnow@redhat.com, rth@twiddle.net, kwolf@redhat.com, andrew@aj.id.au, claudio.fontana@suse.com, crwulff@gmail.com, laurent@vivier.eu, sundeep.lkml@gmail.com, michael@walle.cc, qemu-ppc@nongnu.org, kbastian@mail.uni-paderborn.de, imammedo@redhat.com, fam@euphon.net, peter.maydell@linaro.org, david@redhat.com, palmer@sifive.com, keith.busch@intel.com, jcmvbkbc@gmail.com, hare@suse.com, sstabellini@kernel.org, andrew.smirnov@gmail.com, deller@gmx.de, magnus.damm@gmail.com, atar4qemu@gmail.com, minyard@acm.org, sw@weilnetz.de, yuval.shaia@oracle.com, qemu-s390x@nongnu.org, qemu-arm@nongnu.org, peter.chubb@nicta.com.au, clg@kaod.org, shorne@gmail.com, qemu-riscv@nongnu.org, i.mitsyanko@gmail.com, cohuck@redhat.com, amarkovic@wavecomp.com, jan.kiszka@web.de, aurelien@aurel32.net, pburton@wavecomp.com, sagark@eecs.berkeley.edu, jasowang@redhat.com, kraxel@redhat.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, robh@kernel.org, lersek@redhat.com, borntraeger@de.ibm.com, joel@jms.id.au, antonynpavlov@gmail.com, chouteau@adacore.com, Andrew.Baumann@microsoft.com, mreitz@redhat.com, walling@linux.ibm.com, dmitry.fleytman@gmail.com, mst@redhat.com, mark.cave-ayland@ilande.co.uk, jslaby@suse.cz, marex@denx.de, proljc@gmail.com, marcandre.lureau@redhat.com, alistair@alistair23.me, paul.durrant@citrix.com, david@gibson.dropbear.id.au, xiaoguangrong.eric@gmail.com, huth@tuxfamily.org, jcd@tribudubois.net, stefanb@linux.ibm.com References: <43bc5e07ac614d0e8e740bf6007ff77b@tpw09926dag18e.domain1.systemhost.net> <1565941032362.60179@bt.com> <1b5f5a92-1b75-f0d9-d7bc-4605094ad8e7@redhat.com> <8d8b37c9-3daf-d241-df92-1a5467bca451@redhat.com> <3b983f77-8503-3fcd-7c42-45d0121845e6@redhat.com> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Mon, 19 Aug 2019 14:01:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <3b983f77-8503-3fcd-7c42-45d0121845e6@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::541 Subject: Re: [Qemu-riscv] [Qemu-devel] [qemu-s390x] [PATCH v7 33/42] exec: Replace device_endian with MemOp X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Aug 2019 21:01:33 -0000 On 8/19/19 11:29 AM, Paolo Bonzini wrote: > On 19/08/19 20:28, Paolo Bonzini wrote: >> On 16/08/19 12:12, Thomas Huth wrote: >>> This patch is *huge*, more than 800kB. It keeps being stuck in the the >>> filter of the qemu-s390x list each time you send it. Please: >>> >>> 1) Try to break it up in more digestible pieces, e.g. change only one >>> subsystem at a time (this is also better reviewable by people who are >>> interested in one area) >> >> This is not really possible, since the patch is basically a >> search-and-replace. You could perhaps use some magic >> ("DEVICE_MEMOP_ENDIAN" or something like that) to allow a split, but it >> would introduce more complication than anything else. > > I'm stupid, at this point of the series it _would_ be possible to split > the patch by subsystem. Still not sure it would be actually an advantage. It might be easier to review if we split by symbol, one rename per patch over the entire code base. r~