Re: [PATCH 0/2] arm64: dts: renesas: r8a779a0: Add INTC-EX support

[Kieran Bingham <kieran.bingham@ideasonboard.com>]

Hi Geert,

On 23/06/2021 16:02, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> This patch series adds support for the Interrupt Controller for External
> Devices (INT-EC) in the Renesas R-Car V3U (r8a779a0) SoC.
> 
> As there are two known issues, I'm posting this to a limited audience:
> 
>   1. External interrupts have not been tested.
> 
>      Kieran: perhaps IRQ0 can be tested on Falcon with the MIPI DSI/eDP
>      bridge, by changing
> 
> 	 -    interrupt-parent = <&gpio1>;
> 	 -    interrupts = <24 IRQ_TYPE_LEVEL_HIGH>;
> 	 +    interrupt-parent = <&intc_ex>;
> 	 +    interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> 
>      ? The "ti,sn65dsi86" driver doesn't seem to use interrupts, though,
>      so I don't know how feasible this is.

I can add an interrupt handler if that's what you need, but I suspect
that the change here simply 're-routes' the interrupt through the
intc_ex so that it still needs an interrupt to be generated by the
SN65DSI86? is that right?



>      Alternatively, with physical access, IRQ0 is available on test
>      point CP47, and IRQ2 on the GPIO CN.

I do have physical access, so I can trigger this - Is there a suitable
voltage or condition I can apply? (I.e. take a signal from a nearby pin
to short it?)

--
Kieran



>   2. As recent revisions of R-Car Gen3 Hardware User's Manuals stopped
>      documenting module clocks for interrupt controllers, I don't know
>      which Module Stop bits control it.  Hence I could not add the intc-ex
>      module clock to the R-Car V3U clock driver, but have used the CP
>      clock instead in DTS.  Alternatively, as the driver doesn't really
>      use the clock (except implicitly through Runtime PM), we can drop
>      it, but that would need an update to the DT bindings.
> 
> This series been boot-tested on a remote Falcon development board.
> 
> Thanks for your comments!
> 
> Geert Uytterhoeven (2):
>   dt-bindings: irqchip: renesas-irqc: Add R-Car V3U support
>   arm64: dts: renesas: r8a779a0: Add INTC-EX device node
> 
>  .../interrupt-controller/renesas,irqc.yaml        |  1 +
>  arch/arm64/boot/dts/renesas/r8a779a0.dtsi         | 15 +++++++++++++++
>  2 files changed, 16 insertions(+)
>