From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933386AbeCGNBp (ORCPT ); Wed, 7 Mar 2018 08:01:45 -0500 Received: from foss.arm.com ([217.140.101.70]:50404 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754269AbeCGNBl (ORCPT ); Wed, 7 Mar 2018 08:01:41 -0500 Subject: Re: [PATCH v7 09/14] dt-bindings: iommu/rockchip: Add clock property To: Jeffy Chen , linux-kernel@vger.kernel.org Cc: jcliang@chromium.org, xxm@rock-chips.com, tfiga@chromium.org, devicetree@vger.kernel.org, Heiko Stuebner , linux-rockchip@lists.infradead.org, iommu@lists.linux-foundation.org, Rob Herring , Mark Rutland , Joerg Roedel , linux-arm-kernel@lists.infradead.org References: <20180306030252.3197-1-jeffy.chen@rock-chips.com> <20180306032113.22247-1-jeffy.chen@rock-chips.com> <20180306032113.22247-6-jeffy.chen@rock-chips.com> From: Robin Murphy Message-ID: Date: Wed, 7 Mar 2018 13:01:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180306032113.22247-6-jeffy.chen@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03/18 03:21, Jeffy Chen wrote: > Add clock property, since we are going to control clocks in rockchip > iommu driver. Reviewed-by: Robin Murphy > Signed-off-by: Jeffy Chen > Reviewed-by: Rob Herring > --- > > Changes in v7: None > Changes in v6: > Fix dt-binding as Robin suggested. > Use aclk and iface clk as Rob and Robin suggested, and split binding > patch. > > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > Documentation/devicetree/bindings/iommu/rockchip,iommu.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt b/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt > index 2098f7732264..6ecefea1c6f9 100644 > --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt > +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt > @@ -14,6 +14,11 @@ Required properties: > "single-master" device, and needs no additional information > to associate with its master device. See: > Documentation/devicetree/bindings/iommu/iommu.txt > +- clocks : A list of clocks required for the IOMMU to be accessible by > + the host CPU. > +- clock-names : Should contain the following: > + "iface" - Main peripheral bus clock (PCLK/HCL) (required) > + "aclk" - AXI bus clock (required) > > Optional properties: > - rockchip,disable-mmu-reset : Don't use the mmu reset operation. > @@ -27,5 +32,7 @@ Example: > reg = <0xff940300 0x100>; > interrupts = ; > interrupt-names = "vopl_mmu"; > + clocks = <&cru ACLK_VOP1>, <&cru HCLK_VOP1>; > + clock-names = "aclk", "iface"; > #iommu-cells = <0>; > }; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH v7 09/14] dt-bindings: iommu/rockchip: Add clock property Date: Wed, 7 Mar 2018 13:01:37 +0000 Message-ID: References: <20180306030252.3197-1-jeffy.chen@rock-chips.com> <20180306032113.22247-1-jeffy.chen@rock-chips.com> <20180306032113.22247-6-jeffy.chen@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180306032113.22247-6-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Jeffy Chen , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Heiko Stuebner , jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 06/03/18 03:21, Jeffy Chen wrote: > Add clock property, since we are going to control clocks in rockchip > iommu driver. Reviewed-by: Robin Murphy > Signed-off-by: Jeffy Chen > Reviewed-by: Rob Herring > --- > > Changes in v7: None > Changes in v6: > Fix dt-binding as Robin suggested. > Use aclk and iface clk as Rob and Robin suggested, and split binding > patch. > > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > Documentation/devicetree/bindings/iommu/rockchip,iommu.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt b/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt > index 2098f7732264..6ecefea1c6f9 100644 > --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt > +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt > @@ -14,6 +14,11 @@ Required properties: > "single-master" device, and needs no additional information > to associate with its master device. See: > Documentation/devicetree/bindings/iommu/iommu.txt > +- clocks : A list of clocks required for the IOMMU to be accessible by > + the host CPU. > +- clock-names : Should contain the following: > + "iface" - Main peripheral bus clock (PCLK/HCL) (required) > + "aclk" - AXI bus clock (required) > > Optional properties: > - rockchip,disable-mmu-reset : Don't use the mmu reset operation. > @@ -27,5 +32,7 @@ Example: > reg = <0xff940300 0x100>; > interrupts = ; > interrupt-names = "vopl_mmu"; > + clocks = <&cru ACLK_VOP1>, <&cru HCLK_VOP1>; > + clock-names = "aclk", "iface"; > #iommu-cells = <0>; > }; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: robin.murphy@arm.com (Robin Murphy) Date: Wed, 7 Mar 2018 13:01:37 +0000 Subject: [PATCH v7 09/14] dt-bindings: iommu/rockchip: Add clock property In-Reply-To: <20180306032113.22247-6-jeffy.chen@rock-chips.com> References: <20180306030252.3197-1-jeffy.chen@rock-chips.com> <20180306032113.22247-1-jeffy.chen@rock-chips.com> <20180306032113.22247-6-jeffy.chen@rock-chips.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/03/18 03:21, Jeffy Chen wrote: > Add clock property, since we are going to control clocks in rockchip > iommu driver. Reviewed-by: Robin Murphy > Signed-off-by: Jeffy Chen > Reviewed-by: Rob Herring > --- > > Changes in v7: None > Changes in v6: > Fix dt-binding as Robin suggested. > Use aclk and iface clk as Rob and Robin suggested, and split binding > patch. > > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > Documentation/devicetree/bindings/iommu/rockchip,iommu.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt b/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt > index 2098f7732264..6ecefea1c6f9 100644 > --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt > +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt > @@ -14,6 +14,11 @@ Required properties: > "single-master" device, and needs no additional information > to associate with its master device. See: > Documentation/devicetree/bindings/iommu/iommu.txt > +- clocks : A list of clocks required for the IOMMU to be accessible by > + the host CPU. > +- clock-names : Should contain the following: > + "iface" - Main peripheral bus clock (PCLK/HCL) (required) > + "aclk" - AXI bus clock (required) > > Optional properties: > - rockchip,disable-mmu-reset : Don't use the mmu reset operation. > @@ -27,5 +32,7 @@ Example: > reg = <0xff940300 0x100>; > interrupts = ; > interrupt-names = "vopl_mmu"; > + clocks = <&cru ACLK_VOP1>, <&cru HCLK_VOP1>; > + clock-names = "aclk", "iface"; > #iommu-cells = <0>; > }; >