From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2AFDC433EF for ; Mon, 14 Feb 2022 11:46:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EC69C16E9; Mon, 14 Feb 2022 12:45:34 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EC69C16E9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1644839185; bh=G1V33pJNQ00HMRMQYtSYymxMctLJqbcyW6mYO6jW5gU=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Sa2pDJK4/00KgPCHs5jn8LvYGCUVkylwu6yJEq2uwpiL3LUa1TyHIMNbF8PtjMq0D UZCI2+b+u/4kUTl16LWZXZiKhA/TmSE477VM4JeTFzFaWwOQNjKxpN5VAH1M93RW6p tVFPhWL8dJNthufRp8xq5dp6fq7nTJoiJNLlk/4U= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8196AF80169; Mon, 14 Feb 2022 12:45:34 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5F4CBF80310; Mon, 14 Feb 2022 12:45:33 +0100 (CET) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2D413F800C0 for ; Mon, 14 Feb 2022 12:45:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2D413F800C0 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="hVWzgIGj" Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: adalessandro) with ESMTPSA id E0FFE1F43899 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644839123; bh=G1V33pJNQ00HMRMQYtSYymxMctLJqbcyW6mYO6jW5gU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hVWzgIGjpfSN+YrqXM2QuDqzogthlRnw0LFqU4Sm4Yf4L59rjF6cwKpZSZYCcSUSJ aZxbaILEYFNfUPVUXzYvhlvn8+gDLuquyhDdQ0z4xNh8xEG/0q5+HDYKrwRR1WMsZo qne8paHgh/oTqkgeQYtfj4YkuYl6gVUPIty5lDg0tweFhstpU6SScElApNXsG6ZUTX 8YuRYsHCyB0eJ+uToMEtlzQHVBUDswYxyIJ/+F25fuAXZRO5q7b2FIS7zY2KwxU2t+ pFQzD+ekeZvUREfAi3TDqX8wyMVDnM75x44kF1avwg71ThC0Xhg4cJywMvdCTPe8Mh gQOjec/ycAMOQ== Message-ID: Date: Mon, 14 Feb 2022 08:45:13 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v2 2/2] arm64: dts: imx8mn-bsh-smm-s2pro: Add tlv320aic31xx audio card node Content-Language: en-US To: Shawn Guo References: <20220210134049.32576-1-ariel.dalessandro@collabora.com> <20220210134049.32576-2-ariel.dalessandro@collabora.com> <20220213041823.GL4909@dragon> From: Ariel D'Alessandro In-Reply-To: <20220213041823.GL4909@dragon> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, krzysztof.kozlowski@canonical.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, michael@amarulasolutions.com, festevam@gmail.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Shawn, Thanks for the review, will address all the below changes in v3. Regards, Ariel On 2/13/22 01:18, Shawn Guo wrote: > On Thu, Feb 10, 2022 at 10:40:49AM -0300, Ariel D'Alessandro wrote: >> BSH SystemMaster (SMM) S2 PRO board comes with an audio card based on >> tlv320aic31xx family codec. >> >> The audio card exposes two playback devices, one of them using the EASRC >> (Enhanced Asynchronous Sample Rate Converter) module. Note that this >> would require SDMA and EASRC firmware in order to work. >> >> Signed-off-by: Ariel D'Alessandro >> Signed-off-by: Michael Trimarchi >> --- >> .../dts/freescale/imx8mn-bsh-smm-s2pro.dts | 94 +++++++++++++++++++ >> 1 file changed, 94 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts >> index c6a8ed6745c1..3621354b4a92 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts >> +++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts >> @@ -7,6 +7,7 @@ >> /dts-v1/; >> >> #include "imx8mn-bsh-smm-s2-common.dtsi" >> +#include >> >> / { >> model = "BSH SMM S2 PRO"; >> @@ -16,6 +17,69 @@ memory@40000000 { >> device_type = "memory"; >> reg = <0x0 0x40000000 0x0 0x20000000>; >> }; >> + >> + sound-tlv320aic31xx { >> + compatible = "fsl,imx-audio-tlv320aic31xx"; >> + model = "tlv320aic31xx-hifi"; >> + audio-cpu = <&sai3>; >> + audio-codec = <&codec>; >> + audio-asrc = <&easrc>; >> + audio-routing = >> + "Ext Spk", "SPL", >> + "Ext Spk", "SPR"; >> + mclk-id = ; >> + }; >> + >> + vdd_input: vdd_input { >> + compatible = "regulator-fixed"; >> + regulator-name = "vdd_input"; >> + regulator-min-microvolt = <5000000>; >> + regulator-max-microvolt = <5000000>; >> + }; >> +}; >> + >> +&easrc { >> + fsl,asrc-rate = <48000>; > > Double spaces before '='. > >> + fsl,asrc-format = <10>; >> + status = "okay"; >> +}; >> + >> +&i2c2 { >> + clock-frequency = <400000>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_i2c2>; >> + status = "okay"; >> + >> + codec: tlv320dac3101@18 { > > tlv320dac3101: audio-codec@18 > >> + #sound-dai-cells = <0>; >> + compatible = "ti,tlv320dac3101"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_dac_rst>; >> + reg = <0x18>; >> + >> + ai31xx-micbias-vg = ; >> + >> + HPVDD-supply = <&buck4_reg>; >> + SPRVDD-supply = <&vdd_input>; >> + SPLVDD-supply = <&vdd_input>; >> + AVDD-supply = <&buck4_reg>; >> + IOVDD-supply = <&buck4_reg>; >> + DVDD-supply = <&buck5_reg>; >> + reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>; >> + >> + clocks = <&clk IMX8MN_CLK_SAI3_ROOT>; >> + clock-names = "mclk"; >> + }; >> +}; >> + >> +&sai3 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_sai3>; >> + assigned-clocks = <&clk IMX8MN_CLK_SAI3>; >> + assigned-clock-parents = <&clk IMX8MN_AUDIO_PLL1_OUT>; >> + assigned-clock-rates = <24576000>; >> + fsl,sai-mclk-direction-output; >> + status = "okay"; >> }; >> >> /* eMMC */ >> @@ -30,6 +94,36 @@ &usdhc1 { >> }; >> >> &iomuxc { >> + pinctrl_dac_rst: dac_rst { > > Name the node more in the same style as other pinctrl nodes. > > Shawn > >> + fsl,pins = < >> + MX8MN_IOMUXC_GPIO1_IO06_GPIO1_IO6 0x19 /* DAC_RST */ >> + >; >> + }; >> + >> + pinctrl_espi2: espi2grp { >> + fsl,pins = < >> + MX8MN_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0x082 >> + MX8MN_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI 0x082 >> + MX8MN_IOMUXC_ECSPI2_MISO_ECSPI2_MISO 0x082 >> + MX8MN_IOMUXC_ECSPI2_SS0_ECSPI2_SS0 0x040 >> + >; >> + }; >> + >> + pinctrl_i2c2: i2c2grp { >> + fsl,pins = < >> + MX8MN_IOMUXC_I2C2_SCL_I2C2_SCL 0x400000c3 >> + MX8MN_IOMUXC_I2C2_SDA_I2C2_SDA 0x400000c3 >> + >; >> + }; >> + >> + pinctrl_sai3: sai3grp { >> + fsl,pins = < >> + MX8MN_IOMUXC_SAI3_TXFS_SAI3_TX_SYNC 0xd6 >> + MX8MN_IOMUXC_SAI3_TXC_SAI3_TX_BCLK 0xd6 >> + MX8MN_IOMUXC_SAI3_TXD_SAI3_TX_DATA0 0xd6 >> + >; >> + }; >> + >> pinctrl_usdhc1: usdhc1grp { >> fsl,pins = < >> MX8MN_IOMUXC_SD1_CLK_USDHC1_CLK 0x40000090 >> -- >> 2.34.1 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39FEAC433EF for ; Mon, 14 Feb 2022 11:49:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351935AbiBNLtV (ORCPT ); Mon, 14 Feb 2022 06:49:21 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347648AbiBNLsq (ORCPT ); Mon, 14 Feb 2022 06:48:46 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B11492BE1; Mon, 14 Feb 2022 03:45:24 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: adalessandro) with ESMTPSA id E0FFE1F43899 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644839123; bh=G1V33pJNQ00HMRMQYtSYymxMctLJqbcyW6mYO6jW5gU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hVWzgIGjpfSN+YrqXM2QuDqzogthlRnw0LFqU4Sm4Yf4L59rjF6cwKpZSZYCcSUSJ aZxbaILEYFNfUPVUXzYvhlvn8+gDLuquyhDdQ0z4xNh8xEG/0q5+HDYKrwRR1WMsZo qne8paHgh/oTqkgeQYtfj4YkuYl6gVUPIty5lDg0tweFhstpU6SScElApNXsG6ZUTX 8YuRYsHCyB0eJ+uToMEtlzQHVBUDswYxyIJ/+F25fuAXZRO5q7b2FIS7zY2KwxU2t+ pFQzD+ekeZvUREfAi3TDqX8wyMVDnM75x44kF1avwg71ThC0Xhg4cJywMvdCTPe8Mh gQOjec/ycAMOQ== Message-ID: Date: Mon, 14 Feb 2022 08:45:13 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v2 2/2] arm64: dts: imx8mn-bsh-smm-s2pro: Add tlv320aic31xx audio card node Content-Language: en-US To: Shawn Guo Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, broonie@kernel.org, festevam@gmail.com, krzysztof.kozlowski@canonical.com, lgirdwood@gmail.com, michael@amarulasolutions.com, robh+dt@kernel.org, s.hauer@pengutronix.de References: <20220210134049.32576-1-ariel.dalessandro@collabora.com> <20220210134049.32576-2-ariel.dalessandro@collabora.com> <20220213041823.GL4909@dragon> From: Ariel D'Alessandro In-Reply-To: <20220213041823.GL4909@dragon> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, Thanks for the review, will address all the below changes in v3. Regards, Ariel On 2/13/22 01:18, Shawn Guo wrote: > On Thu, Feb 10, 2022 at 10:40:49AM -0300, Ariel D'Alessandro wrote: >> BSH SystemMaster (SMM) S2 PRO board comes with an audio card based on >> tlv320aic31xx family codec. >> >> The audio card exposes two playback devices, one of them using the EASRC >> (Enhanced Asynchronous Sample Rate Converter) module. Note that this >> would require SDMA and EASRC firmware in order to work. >> >> Signed-off-by: Ariel D'Alessandro >> Signed-off-by: Michael Trimarchi >> --- >> .../dts/freescale/imx8mn-bsh-smm-s2pro.dts | 94 +++++++++++++++++++ >> 1 file changed, 94 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts >> index c6a8ed6745c1..3621354b4a92 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts >> +++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts >> @@ -7,6 +7,7 @@ >> /dts-v1/; >> >> #include "imx8mn-bsh-smm-s2-common.dtsi" >> +#include >> >> / { >> model = "BSH SMM S2 PRO"; >> @@ -16,6 +17,69 @@ memory@40000000 { >> device_type = "memory"; >> reg = <0x0 0x40000000 0x0 0x20000000>; >> }; >> + >> + sound-tlv320aic31xx { >> + compatible = "fsl,imx-audio-tlv320aic31xx"; >> + model = "tlv320aic31xx-hifi"; >> + audio-cpu = <&sai3>; >> + audio-codec = <&codec>; >> + audio-asrc = <&easrc>; >> + audio-routing = >> + "Ext Spk", "SPL", >> + "Ext Spk", "SPR"; >> + mclk-id = ; >> + }; >> + >> + vdd_input: vdd_input { >> + compatible = "regulator-fixed"; >> + regulator-name = "vdd_input"; >> + regulator-min-microvolt = <5000000>; >> + regulator-max-microvolt = <5000000>; >> + }; >> +}; >> + >> +&easrc { >> + fsl,asrc-rate = <48000>; > > Double spaces before '='. > >> + fsl,asrc-format = <10>; >> + status = "okay"; >> +}; >> + >> +&i2c2 { >> + clock-frequency = <400000>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_i2c2>; >> + status = "okay"; >> + >> + codec: tlv320dac3101@18 { > > tlv320dac3101: audio-codec@18 > >> + #sound-dai-cells = <0>; >> + compatible = "ti,tlv320dac3101"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_dac_rst>; >> + reg = <0x18>; >> + >> + ai31xx-micbias-vg = ; >> + >> + HPVDD-supply = <&buck4_reg>; >> + SPRVDD-supply = <&vdd_input>; >> + SPLVDD-supply = <&vdd_input>; >> + AVDD-supply = <&buck4_reg>; >> + IOVDD-supply = <&buck4_reg>; >> + DVDD-supply = <&buck5_reg>; >> + reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>; >> + >> + clocks = <&clk IMX8MN_CLK_SAI3_ROOT>; >> + clock-names = "mclk"; >> + }; >> +}; >> + >> +&sai3 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_sai3>; >> + assigned-clocks = <&clk IMX8MN_CLK_SAI3>; >> + assigned-clock-parents = <&clk IMX8MN_AUDIO_PLL1_OUT>; >> + assigned-clock-rates = <24576000>; >> + fsl,sai-mclk-direction-output; >> + status = "okay"; >> }; >> >> /* eMMC */ >> @@ -30,6 +94,36 @@ &usdhc1 { >> }; >> >> &iomuxc { >> + pinctrl_dac_rst: dac_rst { > > Name the node more in the same style as other pinctrl nodes. > > Shawn > >> + fsl,pins = < >> + MX8MN_IOMUXC_GPIO1_IO06_GPIO1_IO6 0x19 /* DAC_RST */ >> + >; >> + }; >> + >> + pinctrl_espi2: espi2grp { >> + fsl,pins = < >> + MX8MN_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0x082 >> + MX8MN_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI 0x082 >> + MX8MN_IOMUXC_ECSPI2_MISO_ECSPI2_MISO 0x082 >> + MX8MN_IOMUXC_ECSPI2_SS0_ECSPI2_SS0 0x040 >> + >; >> + }; >> + >> + pinctrl_i2c2: i2c2grp { >> + fsl,pins = < >> + MX8MN_IOMUXC_I2C2_SCL_I2C2_SCL 0x400000c3 >> + MX8MN_IOMUXC_I2C2_SDA_I2C2_SDA 0x400000c3 >> + >; >> + }; >> + >> + pinctrl_sai3: sai3grp { >> + fsl,pins = < >> + MX8MN_IOMUXC_SAI3_TXFS_SAI3_TX_SYNC 0xd6 >> + MX8MN_IOMUXC_SAI3_TXC_SAI3_TX_BCLK 0xd6 >> + MX8MN_IOMUXC_SAI3_TXD_SAI3_TX_DATA0 0xd6 >> + >; >> + }; >> + >> pinctrl_usdhc1: usdhc1grp { >> fsl,pins = < >> MX8MN_IOMUXC_SD1_CLK_USDHC1_CLK 0x40000090 >> -- >> 2.34.1 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F69DC433EF for ; Mon, 14 Feb 2022 12:35:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wDAdY63vazACHvAEk4lDKi6wJu0RU5lMjUnFtZy0LhI=; b=nXYLGOQ3qkhl04 d6xUE+OTanHTNnFC5eko+Xs24grgryaSNRblHYYDgoUC5O/L/sYAvHOdZOWOFQQN58ZhQViO1zmh1 K3bv6TM+oRHFu73uTca1ucKm9FwNdqaL+LbaiJhhPbCxBA4jtxe+ECm/2F+3/0UTf0cxqD4i+7AcB Zw7R+kb73Rp7J0IkDSJcH351ds1zVmv8IsmMA/txu1/a5hYoZpfMN5Sa2DDKLjP6MQU5i/uPaVJYp eiwjarVlxJkL/KC5T0VGWRMGHsMZHbasNq8wGtvLuaQRPajqZcNkptF1iTFH+LIusQLpdqSDYS53w wwvZjpTvSQoYzXiW5imw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJaYJ-00FA5Z-7M; Mon, 14 Feb 2022 12:34:00 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJZnK-00Euqs-FC for linux-arm-kernel@lists.infradead.org; Mon, 14 Feb 2022 11:45:28 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: adalessandro) with ESMTPSA id E0FFE1F43899 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644839123; bh=G1V33pJNQ00HMRMQYtSYymxMctLJqbcyW6mYO6jW5gU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hVWzgIGjpfSN+YrqXM2QuDqzogthlRnw0LFqU4Sm4Yf4L59rjF6cwKpZSZYCcSUSJ aZxbaILEYFNfUPVUXzYvhlvn8+gDLuquyhDdQ0z4xNh8xEG/0q5+HDYKrwRR1WMsZo qne8paHgh/oTqkgeQYtfj4YkuYl6gVUPIty5lDg0tweFhstpU6SScElApNXsG6ZUTX 8YuRYsHCyB0eJ+uToMEtlzQHVBUDswYxyIJ/+F25fuAXZRO5q7b2FIS7zY2KwxU2t+ pFQzD+ekeZvUREfAi3TDqX8wyMVDnM75x44kF1avwg71ThC0Xhg4cJywMvdCTPe8Mh gQOjec/ycAMOQ== Message-ID: Date: Mon, 14 Feb 2022 08:45:13 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v2 2/2] arm64: dts: imx8mn-bsh-smm-s2pro: Add tlv320aic31xx audio card node Content-Language: en-US To: Shawn Guo Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, broonie@kernel.org, festevam@gmail.com, krzysztof.kozlowski@canonical.com, lgirdwood@gmail.com, michael@amarulasolutions.com, robh+dt@kernel.org, s.hauer@pengutronix.de References: <20220210134049.32576-1-ariel.dalessandro@collabora.com> <20220210134049.32576-2-ariel.dalessandro@collabora.com> <20220213041823.GL4909@dragon> From: Ariel D'Alessandro In-Reply-To: <20220213041823.GL4909@dragon> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220214_034526_923908_D6E88332 X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Shawn, Thanks for the review, will address all the below changes in v3. Regards, Ariel On 2/13/22 01:18, Shawn Guo wrote: > On Thu, Feb 10, 2022 at 10:40:49AM -0300, Ariel D'Alessandro wrote: >> BSH SystemMaster (SMM) S2 PRO board comes with an audio card based on >> tlv320aic31xx family codec. >> >> The audio card exposes two playback devices, one of them using the EASRC >> (Enhanced Asynchronous Sample Rate Converter) module. Note that this >> would require SDMA and EASRC firmware in order to work. >> >> Signed-off-by: Ariel D'Alessandro >> Signed-off-by: Michael Trimarchi >> --- >> .../dts/freescale/imx8mn-bsh-smm-s2pro.dts | 94 +++++++++++++++++++ >> 1 file changed, 94 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts >> index c6a8ed6745c1..3621354b4a92 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts >> +++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts >> @@ -7,6 +7,7 @@ >> /dts-v1/; >> >> #include "imx8mn-bsh-smm-s2-common.dtsi" >> +#include >> >> / { >> model = "BSH SMM S2 PRO"; >> @@ -16,6 +17,69 @@ memory@40000000 { >> device_type = "memory"; >> reg = <0x0 0x40000000 0x0 0x20000000>; >> }; >> + >> + sound-tlv320aic31xx { >> + compatible = "fsl,imx-audio-tlv320aic31xx"; >> + model = "tlv320aic31xx-hifi"; >> + audio-cpu = <&sai3>; >> + audio-codec = <&codec>; >> + audio-asrc = <&easrc>; >> + audio-routing = >> + "Ext Spk", "SPL", >> + "Ext Spk", "SPR"; >> + mclk-id = ; >> + }; >> + >> + vdd_input: vdd_input { >> + compatible = "regulator-fixed"; >> + regulator-name = "vdd_input"; >> + regulator-min-microvolt = <5000000>; >> + regulator-max-microvolt = <5000000>; >> + }; >> +}; >> + >> +&easrc { >> + fsl,asrc-rate = <48000>; > > Double spaces before '='. > >> + fsl,asrc-format = <10>; >> + status = "okay"; >> +}; >> + >> +&i2c2 { >> + clock-frequency = <400000>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_i2c2>; >> + status = "okay"; >> + >> + codec: tlv320dac3101@18 { > > tlv320dac3101: audio-codec@18 > >> + #sound-dai-cells = <0>; >> + compatible = "ti,tlv320dac3101"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_dac_rst>; >> + reg = <0x18>; >> + >> + ai31xx-micbias-vg = ; >> + >> + HPVDD-supply = <&buck4_reg>; >> + SPRVDD-supply = <&vdd_input>; >> + SPLVDD-supply = <&vdd_input>; >> + AVDD-supply = <&buck4_reg>; >> + IOVDD-supply = <&buck4_reg>; >> + DVDD-supply = <&buck5_reg>; >> + reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>; >> + >> + clocks = <&clk IMX8MN_CLK_SAI3_ROOT>; >> + clock-names = "mclk"; >> + }; >> +}; >> + >> +&sai3 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_sai3>; >> + assigned-clocks = <&clk IMX8MN_CLK_SAI3>; >> + assigned-clock-parents = <&clk IMX8MN_AUDIO_PLL1_OUT>; >> + assigned-clock-rates = <24576000>; >> + fsl,sai-mclk-direction-output; >> + status = "okay"; >> }; >> >> /* eMMC */ >> @@ -30,6 +94,36 @@ &usdhc1 { >> }; >> >> &iomuxc { >> + pinctrl_dac_rst: dac_rst { > > Name the node more in the same style as other pinctrl nodes. > > Shawn > >> + fsl,pins = < >> + MX8MN_IOMUXC_GPIO1_IO06_GPIO1_IO6 0x19 /* DAC_RST */ >> + >; >> + }; >> + >> + pinctrl_espi2: espi2grp { >> + fsl,pins = < >> + MX8MN_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0x082 >> + MX8MN_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI 0x082 >> + MX8MN_IOMUXC_ECSPI2_MISO_ECSPI2_MISO 0x082 >> + MX8MN_IOMUXC_ECSPI2_SS0_ECSPI2_SS0 0x040 >> + >; >> + }; >> + >> + pinctrl_i2c2: i2c2grp { >> + fsl,pins = < >> + MX8MN_IOMUXC_I2C2_SCL_I2C2_SCL 0x400000c3 >> + MX8MN_IOMUXC_I2C2_SDA_I2C2_SDA 0x400000c3 >> + >; >> + }; >> + >> + pinctrl_sai3: sai3grp { >> + fsl,pins = < >> + MX8MN_IOMUXC_SAI3_TXFS_SAI3_TX_SYNC 0xd6 >> + MX8MN_IOMUXC_SAI3_TXC_SAI3_TX_BCLK 0xd6 >> + MX8MN_IOMUXC_SAI3_TXD_SAI3_TX_DATA0 0xd6 >> + >; >> + }; >> + >> pinctrl_usdhc1: usdhc1grp { >> fsl,pins = < >> MX8MN_IOMUXC_SD1_CLK_USDHC1_CLK 0x40000090 >> -- >> 2.34.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel