From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3B9C43334 for ; Fri, 24 Jun 2022 05:28:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231615AbiFXF2M (ORCPT ); Fri, 24 Jun 2022 01:28:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231565AbiFXF2I (ORCPT ); Fri, 24 Jun 2022 01:28:08 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6F1066333; Thu, 23 Jun 2022 22:28:00 -0700 (PDT) Received: from [192.168.254.32] (unknown [47.189.24.195]) by linux.microsoft.com (Postfix) with ESMTPSA id 5F1AC20C709F; Thu, 23 Jun 2022 22:27:59 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5F1AC20C709F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1656048480; bh=gZuRnI5PofS9iqaTLzKEbxmbrQ015sgbhXqKOntIf+k=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=We1FB93ZdWYCLsuU2LFP/7FXQKNO6o6nLEkF0yuMqc28eiouP6TqE4uf7GrVbAsMQ Eo6vs1iDSwRI++SdaXZO1z8PNH0I6CiJAAfDzWEiBWeJsMOQruSXgyoku3SH6tSryp 4OYnKPcnJnVurUINEr2MIeTA8zywhjMqNyGcAfrw= Message-ID: Date: Fri, 24 Jun 2022 00:27:58 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v15 0/6] arm64: Reorganize the unwinder and implement stack trace reliability checks Content-Language: en-US From: "Madhavan T. Venkataraman" To: Will Deacon Cc: broonie@kernel.org, mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, jamorris@linux.microsoft.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220617210717.27126-1-madvenka@linux.microsoft.com> <20220623173224.GB16966@willie-the-truck> <66545c21-cfcf-60eb-4acf-39be99520369@linux.microsoft.com> In-Reply-To: <66545c21-cfcf-60eb-4acf-39be99520369@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/24/22 00:19, Madhavan T. Venkataraman wrote: > > > On 6/23/22 12:32, Will Deacon wrote: >> On Fri, Jun 17, 2022 at 04:07:11PM -0500, madvenka@linux.microsoft.com wrote: >>> From: "Madhavan T. Venkataraman" >>> >>> I have synced this patch series to v5.19-rc2. >>> I have also removed the following patch. >>> >>> [PATCH v14 7/7] arm64: Select HAVE_RELIABLE_STACKTRACE >>> >>> as HAVE_RELIABLE_STACKTRACE depends on STACK_VALIDATION which is not present >>> yet. This patch will be added in the future once Objtool is enhanced to >>> provide stack validation in some form. >> >> Given that it's not at all obvious that we're going to end up using objtool >> for arm64, does this patch series gain us anything in isolation? >> > > BTW, I have synced my patchset to 5.19-rc2 and sent it as v15. Sorry. What I wanted to say was that in v15 I have removed the patch titled: arm64: Select HAVE_RELIABLE_STACKTRACE since objtool changes are not in place. Apologies. Madhavan > > So, to answer your question, patches 1 thru 3 in v15 are still useful even if we don't > consider reliable stacktrace. These patches reorganize the unwinder code based on > comments from both Mark Rutland and Mark Brown. Mark Brown has already OKed them. > If Mark Rutland OKes them, we should upstream them. > > I can drop patches 4 thru 6. Actually, the objtool patch series that I have > sent separately for supporting livepatch already addresses reliability. So, if that > gets reviewed and accepted, we don't even need patches 4 thru 6. > > If you are OK with that, I can resend v16 with just patches 1 thru 3. Let me know. > > Madhavan > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20E1CCCA47F for ; Fri, 24 Jun 2022 05:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BGDbte4smJG7JXN7BjR7S8sg8l5jcAIsCRxTKO1vfFw=; b=S5bf/+s0RolztA D/lHGwaiFFQOh29mSFAiC59NhQk6YjhAUOvFmcIsWe0Q+yUtw5qyUilK/4Z92R1RCXoqwWL3jIa1m H3vSYgMyRRQXXOV49VtSZJ3NvX8m1HtawDCq/eMTkd8UIB/s5JYb/ywuONJx214yzLeEujEcjlEuY hkhD4G08UuhTDed1UQ3e8v+A8AdjMnqEZ7SsES3eRgTO5PS0PCWRHbRrzLYRpaZMuc02s34d1oupU MDVsz28evswxVbS+bydtqE/oXewFtO0BBEvdsVqgH1GkrZbed4i/A1StagXSBAcigVpDJcbEt2rdI Bb2uAIGRVpSQLJSLy9zQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4brP-000cii-TN; Fri, 24 Jun 2022 05:28:04 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4brM-000cht-W1 for linux-arm-kernel@lists.infradead.org; Fri, 24 Jun 2022 05:28:02 +0000 Received: from [192.168.254.32] (unknown [47.189.24.195]) by linux.microsoft.com (Postfix) with ESMTPSA id 5F1AC20C709F; Thu, 23 Jun 2022 22:27:59 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5F1AC20C709F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1656048480; bh=gZuRnI5PofS9iqaTLzKEbxmbrQ015sgbhXqKOntIf+k=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=We1FB93ZdWYCLsuU2LFP/7FXQKNO6o6nLEkF0yuMqc28eiouP6TqE4uf7GrVbAsMQ Eo6vs1iDSwRI++SdaXZO1z8PNH0I6CiJAAfDzWEiBWeJsMOQruSXgyoku3SH6tSryp 4OYnKPcnJnVurUINEr2MIeTA8zywhjMqNyGcAfrw= Message-ID: Date: Fri, 24 Jun 2022 00:27:58 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v15 0/6] arm64: Reorganize the unwinder and implement stack trace reliability checks Content-Language: en-US From: "Madhavan T. Venkataraman" To: Will Deacon Cc: broonie@kernel.org, mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, jamorris@linux.microsoft.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220617210717.27126-1-madvenka@linux.microsoft.com> <20220623173224.GB16966@willie-the-truck> <66545c21-cfcf-60eb-4acf-39be99520369@linux.microsoft.com> In-Reply-To: <66545c21-cfcf-60eb-4acf-39be99520369@linux.microsoft.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220623_222801_112570_DED0A59D X-CRM114-Status: GOOD ( 17.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/24/22 00:19, Madhavan T. Venkataraman wrote: > > > On 6/23/22 12:32, Will Deacon wrote: >> On Fri, Jun 17, 2022 at 04:07:11PM -0500, madvenka@linux.microsoft.com wrote: >>> From: "Madhavan T. Venkataraman" >>> >>> I have synced this patch series to v5.19-rc2. >>> I have also removed the following patch. >>> >>> [PATCH v14 7/7] arm64: Select HAVE_RELIABLE_STACKTRACE >>> >>> as HAVE_RELIABLE_STACKTRACE depends on STACK_VALIDATION which is not present >>> yet. This patch will be added in the future once Objtool is enhanced to >>> provide stack validation in some form. >> >> Given that it's not at all obvious that we're going to end up using objtool >> for arm64, does this patch series gain us anything in isolation? >> > > BTW, I have synced my patchset to 5.19-rc2 and sent it as v15. Sorry. What I wanted to say was that in v15 I have removed the patch titled: arm64: Select HAVE_RELIABLE_STACKTRACE since objtool changes are not in place. Apologies. Madhavan > > So, to answer your question, patches 1 thru 3 in v15 are still useful even if we don't > consider reliable stacktrace. These patches reorganize the unwinder code based on > comments from both Mark Rutland and Mark Brown. Mark Brown has already OKed them. > If Mark Rutland OKes them, we should upstream them. > > I can drop patches 4 thru 6. Actually, the objtool patch series that I have > sent separately for supporting livepatch already addresses reliability. So, if that > gets reviewed and accepted, we don't even need patches 4 thru 6. > > If you are OK with that, I can resend v16 with just patches 1 thru 3. Let me know. > > Madhavan > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel