* [PATCH] spmi: get rid of a warning when built with W=1
@ 2020-08-12 12:29 Mauro Carvalho Chehab
2020-08-15 9:03 ` Stephen Boyd
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
0 siblings, 2 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2020-08-12 12:29 UTC (permalink / raw)
Cc: linuxarm, mauro.chehab, Mauro Carvalho Chehab, Stephen Boyd,
linux-kernel, linux-arm-msm
The SPMI core complaing with this warning when built with W=1:
drivers/spmi/spmi.c: In function ‘spmi_controller_remove’:
drivers/spmi/spmi.c:548:6: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]
548 | int dummy;
| ^~~~~
As the dummy var isn't needed, remove it.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
drivers/spmi/spmi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
index c16b60f645a4..fd3ff6079b15 100644
--- a/drivers/spmi/spmi.c
+++ b/drivers/spmi/spmi.c
@@ -545,13 +545,10 @@ static int spmi_ctrl_remove_device(struct device *dev, void *data)
*/
void spmi_controller_remove(struct spmi_controller *ctrl)
{
- int dummy;
-
if (!ctrl)
return;
- dummy = device_for_each_child(&ctrl->dev, NULL,
- spmi_ctrl_remove_device);
+ device_for_each_child(&ctrl->dev, NULL, spmi_ctrl_remove_device);
device_del(&ctrl->dev);
}
EXPORT_SYMBOL_GPL(spmi_controller_remove);
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] spmi: get rid of a warning when built with W=1
2020-08-12 12:29 [PATCH] spmi: get rid of a warning when built with W=1 Mauro Carvalho Chehab
@ 2020-08-15 9:03 ` Stephen Boyd
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-08-15 9:03 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: linuxarm, mauro.chehab, Mauro Carvalho Chehab, linux-kernel,
linux-arm-msm
Quoting Mauro Carvalho Chehab (2020-08-12 05:29:18)
> The SPMI core complaing with this warning when built with W=1:
>
> drivers/spmi/spmi.c: In function ‘spmi_controller_remove’:
> drivers/spmi/spmi.c:548:6: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]
> 548 | int dummy;
> | ^~~~~
>
> As the dummy var isn't needed, remove it.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spmi: get rid of a warning when built with W=1
2020-08-12 12:29 [PATCH] spmi: get rid of a warning when built with W=1 Mauro Carvalho Chehab
2020-08-15 9:03 ` Stephen Boyd
@ 2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-arm-msm @ 2020-12-29 20:15 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-arm-msm
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
On Wed, 12 Aug 2020 14:29:18 +0200 you wrote:
> The SPMI core complaing with this warning when built with W=1:
>
> drivers/spmi/spmi.c: In function ‘spmi_controller_remove’:
> drivers/spmi/spmi.c:548:6: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]
> 548 | int dummy;
> | ^~~~~
>
> [...]
Here is the summary with links:
- spmi: get rid of a warning when built with W=1
https://git.kernel.org/qcom/c/b1f0aeecd25a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-29 20:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-12 12:29 [PATCH] spmi: get rid of a warning when built with W=1 Mauro Carvalho Chehab
2020-08-15 9:03 ` Stephen Boyd
2020-12-29 20:15 ` patchwork-bot+linux-arm-msm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.