From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A8FC433EF for ; Tue, 17 May 2022 10:30:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344235AbiEQKau (ORCPT ); Tue, 17 May 2022 06:30:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241853AbiEQKak (ORCPT ); Tue, 17 May 2022 06:30:40 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3E6621B0; Tue, 17 May 2022 03:30:38 -0700 (PDT) X-UUID: c66ce7917cd44ea3ab9552e558e0b8a6-20220517 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:2e6b7c57-7ac6-442f-a68f-d7521cb297c3,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:65367de2-edbf-4bd4-8a34-dfc5f7bb086d,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: c66ce7917cd44ea3ab9552e558e0b8a6-20220517 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1398611353; Tue, 17 May 2022 18:30:34 +0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Tue, 17 May 2022 18:30:33 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 May 2022 18:30:32 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 17 May 2022 18:30:32 +0800 Message-ID: Subject: Re: [PATCH v6 00/16] Cleanup MediaTek clk reset drivers and support MT8192/MT8195 From: Rex-BC Chen To: Stephen Boyd , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "mturquette@baylibre.com" , "robh+dt@kernel.org" CC: "p.zabel@pengutronix.de" , "angelogioacchino.delregno@collabora.com" , Chun-Jie Chen =?UTF-8?Q?=28=E9=99=B3=E6=B5=9A=E6=A1=80=29?= , "wenst@chromium.org" , Runyang Chen =?UTF-8?Q?=28=E9=99=88=E6=B6=A6=E6=B4=8B=29?= , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Project_Global_Chrome_Upstream_Group Date: Tue, 17 May 2022 18:30:31 +0800 In-Reply-To: <20220517072329.D367AC385B8@smtp.kernel.org> References: <20220503093856.22250-1-rex-bc.chen@mediatek.com> <445ef1e3ef9d62934e1b84d4fb207705a90d4f34.camel@mediatek.com> <20220517072329.D367AC385B8@smtp.kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-05-17 at 15:23 +0800, Stephen Boyd wrote: > Quoting Rex-BC Chen (2022-05-08 22:35:55) > > > > The drivers of this series are reviewed. > > The binding of this series are also acked. > > Could you spare some time and give us some suggestion? > > Have you considered using the auxiliary bus to split the Mediatek clk > and reset device up into a clk device and a reset device? The idea > would > be to move the reset related code into drivers/reset and have the clk > code in drivers/clk. It's purely an organizational thing and it can > certainly be done later but it may be a good idea to do this to > clearly split out the two different functionalities. Hello Stephen, Thanks for your advice. The purpose of this series is to clean up the drivers and we can apply new socs for it. I didn't use the auxiliary bus before. However, I can study to the implementation of auxiliary bus for this reset drivers in another series. Is this ok for you? Thanks! BRs, Rex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CE65C433EF for ; Tue, 17 May 2022 10:35:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1d9Skf1faLsPgrWD8ubmAWPoSmsvbG7+9KMsFAitPWk=; b=hXsCtRn8GcEopV eIo64JzExTA/2xT6XJGqJ3qXMHIxkiEBWQyrNUzPUOnLYYfV3u/xkMp305BRH3qLJXTh/8KYMcJRa 7Mp0+zTFgV4AdVFN+VMq5OXycmZjamhzU1v7kc6Yc0JTazVYSTbKKtYwOe8w95XayBCFT+Wxgc3hs ZhGpj2mEcGLNMfemLQnPVEdXbad4esncKiPXeucaWdn2SuW3zNcJS18EqGraiZD2p1g4YLExxrgd9 JWsFOlAIwcV2nJBrJfnKqGDonpjS5gDAf2EmVYPyeDd96tFFsFBVOF3K+Fbmi8w3jEJkPsdSZ9wj3 2TT/Bs2rekmwnP8DMnOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nquXk-00D8BS-Pa; Tue, 17 May 2022 10:35:08 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nquXi-00D89C-0y; Tue, 17 May 2022 10:35:07 +0000 X-UUID: 179573a3711c451e9e8f245a4c28c438-20220517 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5, REQID:5bc90349-99f7-4bbf-8b96-54fe32dd388c, OB:0, LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09, CLOUDID:ce768d79-5ef6-470b-96c9-bdb8ced32786, C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 179573a3711c451e9e8f245a4c28c438-20220517 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 210287056; Tue, 17 May 2022 03:34:58 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 May 2022 03:30:34 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 May 2022 18:30:32 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 17 May 2022 18:30:32 +0800 Message-ID: Subject: Re: [PATCH v6 00/16] Cleanup MediaTek clk reset drivers and support MT8192/MT8195 From: Rex-BC Chen To: Stephen Boyd , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "mturquette@baylibre.com" , "robh+dt@kernel.org" CC: "p.zabel@pengutronix.de" , "angelogioacchino.delregno@collabora.com" , Chun-Jie Chen =?UTF-8?Q?=28=E9=99=B3=E6=B5=9A=E6=A1=80=29?= , "wenst@chromium.org" , Runyang Chen =?UTF-8?Q?=28=E9=99=88=E6=B6=A6=E6=B4=8B=29?= , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Project_Global_Chrome_Upstream_Group Date: Tue, 17 May 2022 18:30:31 +0800 In-Reply-To: <20220517072329.D367AC385B8@smtp.kernel.org> References: <20220503093856.22250-1-rex-bc.chen@mediatek.com> <445ef1e3ef9d62934e1b84d4fb207705a90d4f34.camel@mediatek.com> <20220517072329.D367AC385B8@smtp.kernel.org> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_033506_100229_996973D5 X-CRM114-Status: GOOD ( 17.70 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2022-05-17 at 15:23 +0800, Stephen Boyd wrote: > Quoting Rex-BC Chen (2022-05-08 22:35:55) > > > > The drivers of this series are reviewed. > > The binding of this series are also acked. > > Could you spare some time and give us some suggestion? > > Have you considered using the auxiliary bus to split the Mediatek clk > and reset device up into a clk device and a reset device? The idea > would > be to move the reset related code into drivers/reset and have the clk > code in drivers/clk. It's purely an organizational thing and it can > certainly be done later but it may be a good idea to do this to > clearly split out the two different functionalities. Hello Stephen, Thanks for your advice. The purpose of this series is to clean up the drivers and we can apply new socs for it. I didn't use the auxiliary bus before. However, I can study to the implementation of auxiliary bus for this reset drivers in another series. Is this ok for you? Thanks! BRs, Rex _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3775FC433EF for ; Tue, 17 May 2022 10:36:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=au8dSvGMqgupW7FZrgQ5MtDc8Kty2Xp7hf9ECWyzXgA=; b=fFfD6V2iaGsC1U i7pmOZH3Nf4BnJ9/VM2Vip8BMPsbmgvkDEiXjfx7Dgw741XhExpDD2a7N4D29c7kf05mgItwP66mH rakgoQz1qVJP72s0t/Tedn8a2KtM49gaEhXZFMOLwbkpgJOVL58LjYjRm6eghpCihYp4YNHtCOJ0/ StXZgBloNh17gjGv3tsomK5D1Avy+8gyYHdInvaVQiIWDS6zB/B5otEpYrwVlRujOgat2YxDlN6Ut mWzg9YUlvdfZC026/ZegVFQwgWB6pz7Z2KT/cYn7A3tGiGCo7voZ0grh6xqdXcM/IXrKRBB+sAuZQ 4ucoUZ8M8O11Gea05jLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nquXn-00D8Bt-Ni; Tue, 17 May 2022 10:35:11 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nquXi-00D89C-0y; Tue, 17 May 2022 10:35:07 +0000 X-UUID: 179573a3711c451e9e8f245a4c28c438-20220517 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5, REQID:5bc90349-99f7-4bbf-8b96-54fe32dd388c, OB:0, LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09, CLOUDID:ce768d79-5ef6-470b-96c9-bdb8ced32786, C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 179573a3711c451e9e8f245a4c28c438-20220517 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 210287056; Tue, 17 May 2022 03:34:58 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 May 2022 03:30:34 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 May 2022 18:30:32 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 17 May 2022 18:30:32 +0800 Message-ID: Subject: Re: [PATCH v6 00/16] Cleanup MediaTek clk reset drivers and support MT8192/MT8195 From: Rex-BC Chen To: Stephen Boyd , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "mturquette@baylibre.com" , "robh+dt@kernel.org" CC: "p.zabel@pengutronix.de" , "angelogioacchino.delregno@collabora.com" , Chun-Jie Chen =?UTF-8?Q?=28=E9=99=B3=E6=B5=9A=E6=A1=80=29?= , "wenst@chromium.org" , Runyang Chen =?UTF-8?Q?=28=E9=99=88=E6=B6=A6=E6=B4=8B=29?= , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Project_Global_Chrome_Upstream_Group Date: Tue, 17 May 2022 18:30:31 +0800 In-Reply-To: <20220517072329.D367AC385B8@smtp.kernel.org> References: <20220503093856.22250-1-rex-bc.chen@mediatek.com> <445ef1e3ef9d62934e1b84d4fb207705a90d4f34.camel@mediatek.com> <20220517072329.D367AC385B8@smtp.kernel.org> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_033506_100229_996973D5 X-CRM114-Status: GOOD ( 17.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2022-05-17 at 15:23 +0800, Stephen Boyd wrote: > Quoting Rex-BC Chen (2022-05-08 22:35:55) > > > > The drivers of this series are reviewed. > > The binding of this series are also acked. > > Could you spare some time and give us some suggestion? > > Have you considered using the auxiliary bus to split the Mediatek clk > and reset device up into a clk device and a reset device? The idea > would > be to move the reset related code into drivers/reset and have the clk > code in drivers/clk. It's purely an organizational thing and it can > certainly be done later but it may be a good idea to do this to > clearly split out the two different functionalities. Hello Stephen, Thanks for your advice. The purpose of this series is to clean up the drivers and we can apply new socs for it. I didn't use the auxiliary bus before. However, I can study to the implementation of auxiliary bus for this reset drivers in another series. Is this ok for you? Thanks! BRs, Rex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel