From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751283AbdHaKd7 (ORCPT ); Thu, 31 Aug 2017 06:33:59 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:5061 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbdHaKd6 (ORCPT ); Thu, 31 Aug 2017 06:33:58 -0400 Subject: Re: [PATCH v6 4/4] perf vendor events arm64: Add ThunderX2 implementation defined pmu core events To: Robert Richter References: <20170824120349.2323-1-ganapatrao.kulkarni@cavium.com> <20170824120349.2323-5-ganapatrao.kulkarni@cavium.com> <43dcc107-263a-5429-73d4-a5290c6610d6@hisilicon.com> <20170829124730.GH17961@rric.localdomain> CC: Ganapatrao Kulkarni , , , , , , , , , , , , , John Garry From: Zhangshaokun Message-ID: Date: Thu, 31 Aug 2017 18:29:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20170829124730.GH17961@rric.localdomain> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.221.148] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.59A7E4F9.0062,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 9959d8595415f6175a53e10fc604958f Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robert, On 2017/8/29 20:47, Robert Richter wrote: > Shaokun, > > On 29.08.17 17:26:00, Zhangshaokun wrote: >> On 2017/8/24 20:03, Ganapatrao Kulkarni wrote: >>> This is not a full event list, but a short list of useful events. >>> >>> Signed-off-by: Ganapatrao Kulkarni >>> --- >>> tools/perf/pmu-events/arch/arm64/mapfile.csv | 15 ++++++ >>> .../arm64/thunderx2/implementation-defined.json | 62 ++++++++++++++++++++++ >>> 2 files changed, 77 insertions(+) >>> create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv >>> create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json >>> >> >> I saw you also used thunderx2 in tools/perf/pmu-events/arch/arm64/, how about John's suggestion >> that would use vendor sub-folder? >> Of course, appreciate maintainer's comments. > > this would just add another level of subdirectories. I rather would > prefer to have a per platform dir comparable to what is listed in > > arch/arm64/Kconfig.platforms > Check it again that not all vendors have specific platform config per SoC family, so this would not work for us (HiSilicon) and maybe some other vendors. Thanks, Shaokun > This is the same as Ganapat has implemented it. > > -Robert > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhangshaokun@hisilicon.com (Zhangshaokun) Date: Thu, 31 Aug 2017 18:29:01 +0800 Subject: [PATCH v6 4/4] perf vendor events arm64: Add ThunderX2 implementation defined pmu core events In-Reply-To: <20170829124730.GH17961@rric.localdomain> References: <20170824120349.2323-1-ganapatrao.kulkarni@cavium.com> <20170824120349.2323-5-ganapatrao.kulkarni@cavium.com> <43dcc107-263a-5429-73d4-a5290c6610d6@hisilicon.com> <20170829124730.GH17961@rric.localdomain> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Robert, On 2017/8/29 20:47, Robert Richter wrote: > Shaokun, > > On 29.08.17 17:26:00, Zhangshaokun wrote: >> On 2017/8/24 20:03, Ganapatrao Kulkarni wrote: >>> This is not a full event list, but a short list of useful events. >>> >>> Signed-off-by: Ganapatrao Kulkarni >>> --- >>> tools/perf/pmu-events/arch/arm64/mapfile.csv | 15 ++++++ >>> .../arm64/thunderx2/implementation-defined.json | 62 ++++++++++++++++++++++ >>> 2 files changed, 77 insertions(+) >>> create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv >>> create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json >>> >> >> I saw you also used thunderx2 in tools/perf/pmu-events/arch/arm64/, how about John's suggestion >> that would use vendor sub-folder? >> Of course, appreciate maintainer's comments. > > this would just add another level of subdirectories. I rather would > prefer to have a per platform dir comparable to what is listed in > > arch/arm64/Kconfig.platforms > Check it again that not all vendors have specific platform config per SoC family, so this would not work for us (HiSilicon) and maybe some other vendors. Thanks, Shaokun > This is the same as Ganapat has implemented it. > > -Robert > >