All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: Vadim Pasternak <vadimp@mellanox.com>,
	"wsa@the-dreams.de" <wsa@the-dreams.de>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"jiri@resnulli.us" <jiri@resnulli.us>,
	Michael Shych <michaelsh@mellanox.com>
Subject: Re: [patch v5] i2c: mux: mellanox: add driver
Date: Thu, 10 Nov 2016 12:13:09 +0100	[thread overview]
Message-ID: <b7cf55af-1354-0e0d-b960-877a6223b357@axentia.se> (raw)
In-Reply-To: <AM5PR0501MB2097C2A4BA889C44549A0E9FA2A30@AM5PR0501MB2097.eurprd05.prod.outlook.com>

[resend to all, got the wrong button, sorry]

On 2016-11-10 11:42, Peter Rosin wrote:
> On 2016-11-03 06:20, Vadim Pasternak wrote:
>> Hi,
>>
>> I see that this patch has not been picked-up yet for i2c-next.
>> Is it possible it was missed from some reason?
>
> Yes, apparently, really sorry about that!
>
> I'll put it in a branch and make a pull request for Wolfram (but
> that is a bit new for me, we'll see how it goes).

But now that I looked again, I noticed that the source is
dual licensed and yet your MODULE_LICENSE tag says only
"GPL v2". I.e. the same issue your i2c master driver had
that Vladimir Zapolskiy noticed.

Please fix this, and it might be a good idea to take a look
in your other drivers as well in case you have further
problems in this department...

Also, while at it, the patch doesn't apply cleanly anymore,
please rebase to something more current.

Cheers,
Peter

  reply	other threads:[~2016-11-10 14:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13 20:37 [patch v5] i2c: mux: mellanox: add driver vadimp
2016-09-14  7:49 ` Peter Rosin
2016-09-14  7:49   ` Peter Rosin
2016-09-14  8:10   ` Vadim Pasternak
2016-09-14  8:42     ` Peter Rosin
2016-09-23  9:36 ` Peter Rosin
2016-09-23  9:36   ` Peter Rosin
2016-09-23 11:57   ` Vadim Pasternak
2016-11-03  5:20   ` Vadim Pasternak
2016-11-10 11:13     ` Peter Rosin [this message]
2016-11-10 12:56       ` Vadim Pasternak
2016-11-10 13:02         ` Peter Rosin
2016-11-10 13:04           ` Vadim Pasternak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7cf55af-1354-0e0d-b960-877a6223b357@axentia.se \
    --to=peda@axentia.se \
    --cc=jiri@resnulli.us \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michaelsh@mellanox.com \
    --cc=vadimp@mellanox.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.