Re: [PATCH] kernel-devsrc: copy mmiowb.h and modpost from ${B} of kernel

[Ruslan Bilovol <rbilovol@cisco.com>]

On 9/11/19 2:36 PM, Bruce Ashfield wrote:
> On Wed, Sep 11, 2019 at 5:10 AM Hongzhi, Song
> <hongzhi.song@windriver.com> wrote:
>>
>>
>> On 9/6/19 11:10 AM, Hongzhi, Song wrote:
>>>
>>> On 9/4/19 8:34 PM, Bruce Ashfield wrote:
>>>> On Wed, Sep 4, 2019 at 6:07 AM Hongzhi, Song
>>>> <hongzhi.song@windriver.com> wrote:
>>>>>
>>>>> On 9/4/19 11:55 AM, Bruce Ashfield wrote:
>>>>>> On Tue, Sep 3, 2019 at 9:43 PM Hongzhi.Song
>>>>>> <hongzhi.song@windriver.com> wrote:
>>>>>>> There are two errors when compile an out of tree kernel module
>>>>>>> using sdk:
>>>>>>>
>>>>>> This is not universally true. Can you expand on what kernel version
>>>>>> and architectures you are building ? I'm able to build kernel modules
>>>>>> across all the arches I'm currently testing, so I'd like to capture
>>>>>> your exact config in the long log. Neither is the autobuilder showing
>>>>>> any errors.
>>>>> Hi Bruce,
>>>>>
>>>>>
>>>>> kernel version: 5.0.19

I met the same issue with modpost recently. This is because kernel 5.0
commit 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=60df1aee2aecb53efb4218b4dfdf7d6c80a5a3de
moved modpost out of 'scripts' target.

>> Hi Bruce,
>>
>> I found 2.7 and 2.6 doc all use "make scripts". And now "make scripts"
>> doesn't work.
>>
>> Should the doc be change to "make scripts prepare" ?
> 
> Yes they should be. We need to open a bug and get ScottR to look into it.
> 
> We've (Richard, myself, and others) have been using make scripts
> prepare as a requirement for on kernel building for quite some time
> now. The docs should reflect this.
> 

Looking at kernel sources, there is better alternative for "make scripts
prepare" requirement: "modules_prepare". It's a special Linux Kernel
target to prepare building external modules.
What it does is actually "scripts+prepare" for older kernels (like 3.10)
and "prepare" (which has "scripts" as indirect dependency) in recent
kernels (v5.4 for example)

So instead of custom "make scripts prepare" lets change it in the doc to
official "modules_prepare" target for modules building preparations.

Any objections?

Thanks,
Ruslan