From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: 2.6.37 intel driver crash on hibernate Date: Wed, 09 Feb 2011 09:40:25 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id AA7BF9E7B3 for ; Wed, 9 Feb 2011 01:40:28 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Pedro Ribeiro , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 9 Feb 2011 00:27:52 +0000, Pedro Ribeiro wrote: > Hi, > > I've been having unreliable operation when hibernating ever since 2.6.37-rc5 > (the first 2.6.37 I tried). > With 2.6.36 I never had a problem. Wrong, you just never saw it. commit 9334ef755f060e251f3f395caeda1a58b6834ea3 Author: Chris Wilson Date: Fri Jan 28 11:53:03 2011 +0000 drm: Don't switch fb when disabling an output In drm_crtc_helper_set_config, we call drm_crtc_helper_set_mode which may return early and do no operation if the crtc is to be disabled. In this case we merrily swap to the new fb, discarding the old_fb believing that it has been cleaned up. However, due to the early return, the old_fb was not presented to the backend for correct reaping, and nor was the new one - which is about to be reaped via the drm_helper_disable_unused_functions(), leading to incorrect refcounting of the pinned objects. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=27722 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=29857 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=29230 Tested-by: Takashi Iwai Signed-off-by: Chris Wilson -- Chris Wilson, Intel Open Source Technology Centre