From: Heiko Schocher <hs@denx.de>
To: Vaishnav Achath <vaishnav.a@ti.com>,
u-boot@lists.denx.de, sjg@chromium.org, mr.nuke.me@gmail.com,
jh80.chung@samsung.com, michal.simek@amd.com, marek.behun@nic.cz,
pali@kernel.org, sr@denx.de, marex@denx.de, ricardo@foundries.io,
vigneshr@ti.com, s-anna@ti.com, kishon@ti.com, j-keerthy@ti.com,
p.yadav@ti.com
Subject: Re: [PATCH v2 1/2] common: spl: spl_spi: add support for dynamic override of sf bus
Date: Wed, 11 May 2022 10:24:12 +0200 [thread overview]
Message-ID: <b7dec5d1-4663-e89c-f61e-e2e9134442d7@denx.de> (raw)
In-Reply-To: <20220511060352.28140-2-vaishnav.a@ti.com>
Hello Achath,
On 11.05.22 08:03, Vaishnav Achath wrote:
> Currently the SPI flash to load from is defined through the compile
> time config CONFIG_SF_DEFAULT_BUS and CONFIG_SF_DEFAULT_CS, this
> prevents the loading of binaries from different SPI flash using the
> same build.E.g. supporting QSPI flash boot and OSPI flash boot
> on J721E platform is not possible due to this limitation.
>
> This commit adds lookup functions spl_spi_boot_bus()
> and spl_spi_boot_cs for identifying the flash device based on the
> selected boot device, when not overridden the lookup functions are
> weakly defined in common/spl/spl_spi.c.
>
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> ---
you miss here change history. May you want to look into patman tool in
u-boot:/tools/patman/README
which can help you here much.
> common/spl/spl_spi.c | 16 +++++++++++++---
> include/spl.h | 16 ++++++++++++++++
> 2 files changed, 29 insertions(+), 3 deletions(-)
Looks fine for me, thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de
next prev parent reply other threads:[~2022-05-11 8:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 6:03 [PATCH v2 0/2] Add support for dynamic overriding of default SF bus Vaishnav Achath
2022-05-11 6:03 ` [PATCH v2 1/2] common: spl: spl_spi: add support for dynamic override of sf bus Vaishnav Achath
2022-05-11 8:24 ` Heiko Schocher [this message]
2022-05-12 6:28 ` Vaishnav Achath
2022-05-31 8:59 ` Pratyush Yadav
2022-05-11 6:03 ` [PATCH v2 2/2] arm: k3: j721e: add dynamic sf bus override support for j721e Vaishnav Achath
2022-05-31 10:59 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7dec5d1-4663-e89c-f61e-e2e9134442d7@denx.de \
--to=hs@denx.de \
--cc=j-keerthy@ti.com \
--cc=jh80.chung@samsung.com \
--cc=kishon@ti.com \
--cc=marek.behun@nic.cz \
--cc=marex@denx.de \
--cc=michal.simek@amd.com \
--cc=mr.nuke.me@gmail.com \
--cc=p.yadav@ti.com \
--cc=pali@kernel.org \
--cc=ricardo@foundries.io \
--cc=s-anna@ti.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
--cc=vaishnav.a@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.