From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21C18C04A6B for ; Mon, 6 May 2019 15:09:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1FD52054F for ; Mon, 6 May 2019 15:09:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727344AbfEFPJV (ORCPT ); Mon, 6 May 2019 11:09:21 -0400 Received: from mga17.intel.com ([192.55.52.151]:62153 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726925AbfEFPJT (ORCPT ); Mon, 6 May 2019 11:09:19 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 May 2019 08:09:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,438,1549958400"; d="scan'208";a="155580576" Received: from spandruv-mobl3.jf.intel.com ([10.251.2.135]) by FMSMGA003.fm.intel.com with ESMTP; 06 May 2019 08:09:18 -0700 Message-ID: Subject: Re: [PATCH] drivers: thermal: processor_thermal: Downgrade error message From: Srinivas Pandruvada To: Zhang Rui , edubezval@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 06 May 2019 08:09:18 -0700 In-Reply-To: <1557147020.2456.5.camel@intel.com> References: <20190430034213.40028-1-srinivas.pandruvada@linux.intel.com> <1557147020.2456.5.camel@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-3.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-05-06 at 20:50 +0800, Zhang Rui wrote: > On δΈ€, 2019-04-29 at 20:42 -0700, Srinivas Pandruvada wrote: > > Downgrade "Unsupported event" message from dev_err to dev_dbg. > > Otherwise it > > floods with this message one some platforms. > > > > Signed-off-by: Srinivas Pandruvada < > > srinivas.pandruvada@linux.intel.c > > om> > > --- > > .../thermal/intel/int340x_thermal/processor_thermal_device.c | > > 2 > > +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c > > b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c > > index 4b206b594825..436c256f111d 100644 > > --- > > a/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c > > +++ > > b/drivers/thermal/intel/int340x_thermal/processor_thermal_device.c > > @@ -275,7 +275,7 @@ static void proc_thermal_notify(acpi_handle > > handle, u32 event, void *data) > > THERMAL_DEVICE_POWER_CAPABILITY_CHAN > > GED); > > break; > > default: > > - dev_err(proc_priv->dev, "Unsupported event > > [0x%x]\n", event); > > + dev_dbg(proc_priv->dev, "Unsupported event > > [0x%x]\n", event); > > break; > > } > > } > > a similar patch has been applied, the only difference is that I'm > using > dev_notice instead. > https://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git/commit > /?h=next&id=3c7110fab805766450c5d2eac1c994d4c8c230d3 I think dev_notice still appear with non debug log level (!=7), so dmesg from most distro will still have this print, which will concern some users unnecessarily, which we can't do anything. Thanks, Srinivas > > thanks, > rui