From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61877C64E8A for ; Mon, 30 Nov 2020 07:48:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69F3720709 for ; Mon, 30 Nov 2020 07:48:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69F3720709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjduu-0003AR-6D for qemu-devel@archiver.kernel.org; Mon, 30 Nov 2020 02:48:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjdsZ-00025c-UB; Mon, 30 Nov 2020 02:45:47 -0500 Received: from mx2.suse.de ([195.135.220.15]:37716) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjdsY-0008Tn-A6; Mon, 30 Nov 2020 02:45:47 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3AB04AC6A; Mon, 30 Nov 2020 07:45:44 +0000 (UTC) Subject: Re: [PATCH 6/8] hvf: Use OS provided vcpu kick function To: Alexander Graf , Eduardo Habkost References: <20201126215017.41156-1-agraf@csgraf.de> <20201126215017.41156-7-agraf@csgraf.de> <20201126221808.GU2271382@habkost.net> <2281f481-d64a-1750-0bd2-e7f52b26da51@csgraf.de> From: Claudio Fontana Message-ID: Date: Mon, 30 Nov 2020 08:45:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <2281f481-d64a-1750-0bd2-e7f52b26da51@csgraf.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Richard Henderson , qemu-devel@nongnu.org, Cameron Esfahani , Roman Bolshakov , qemu-arm@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/30/20 3:42 AM, Alexander Graf wrote: > > On 26.11.20 23:18, Eduardo Habkost wrote: >> On Thu, Nov 26, 2020 at 10:50:15PM +0100, Alexander Graf wrote: >>> When kicking another vCPU, we get an OS function that explicitly does that for us >>> on Apple Silicon. That works better than the current signaling logic, let's make >>> use of it there. >>> >>> Signed-off-by: Alexander Graf >>> --- >>> accel/hvf/hvf-cpus.c | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/accel/hvf/hvf-cpus.c b/accel/hvf/hvf-cpus.c >>> index b9f674478d..74a272d2e8 100644 >>> --- a/accel/hvf/hvf-cpus.c >>> +++ b/accel/hvf/hvf-cpus.c >>> @@ -418,8 +418,20 @@ static void hvf_start_vcpu_thread(CPUState *cpu) >>> cpu, QEMU_THREAD_JOINABLE); >>> } >>> >>> +#ifdef __aarch64__ >>> +static void hvf_kick_vcpu_thread(CPUState *cpu) >>> +{ >>> + if (!qemu_cpu_is_self(cpu)) { >>> + hv_vcpus_exit(&cpu->hvf_fd, 1); >>> + } >>> +} >>> +#endif >>> + >>> static const CpusAccel hvf_cpus = { >>> .create_vcpu_thread = hvf_start_vcpu_thread, >>> +#ifdef __aarch64__ >>> + .kick_vcpu_thread = hvf_kick_vcpu_thread, >>> +#endif >> Interesting. We have considered the possibility of adding >> arch-specific TYPE_ACCEL subclasses when discussing Claudio's, >> series. Here we have another arch-specific hack that could be >> avoided if we had a TYPE_ARM_HVF_ACCEL QOM class. > > > I don't think that's necessary in this case. I don't see how you could > ever have aarch64 and x86 HVF backends compiled into the same binary. > The header files even have a lot of #ifdef's. > > Either way, I've changed it to a weak function in v2. That way it's a > bit easier to read. > > > Alex > > Ciao Alex! you're in the news, congrats for your hack! Ciao, Claudio