From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2612AC19F2D for ; Tue, 9 Aug 2022 11:38:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B724B83FB2; Tue, 9 Aug 2022 13:38:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1660045116; bh=xanmpE2YlqxrlrOK4p+fcgZwMYDFJpupKYYPN7VJJb8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=uz2EEfwmnQJmQHHY6HElOkqE29P6Rlu7jBFPHP+E5wTzlUh2pkjnaKjtgWfsGBgDo WMd7jqzkKIQpz93eazAw1DRmVsZh8ARn719m7MzE1/f9tMFF8o+KObswIRIqbbhG7G UvQLVRN0LCGwYkIqFEg+bXYzzR2n1L8n+oaqyI3rFTNmzOzhRd6ChxGa0yCSeEOgfF uG7+UYeavIKWt0qmBdXQpc2hbKudUhbbJ2IMC2lzSeHxKx/E0nIW3t7ybh1hc33eSH dmX/aeEPBAbvgHFWz76dc+/ZeKobV34JqrR3Gi4WrDcuj3sGg+NlfpXKPqsh3JmbkL gP3aFFrtsSiQA== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 2080483FA0; Tue, 9 Aug 2022 13:38:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1660045113; bh=xanmpE2YlqxrlrOK4p+fcgZwMYDFJpupKYYPN7VJJb8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aSXktl/hCKG9srzZBFX9g37ig2qtx/WBiDRX7WXpan16JZSe5Fa4fjMHaC3aOKimv U7MB6O8d/4VaiOaVaF5zg79x/RCHVOLCfJTntSQZPXliWi/OyNQOoZv+M7dorkjtt9 BV7ot2HaetGRJ/yCpMGa2RnCuNmTGUMoPz0ClBkwioDXNzKc2Tp8zriYZdnfabm1o3 6XaL+6doS+x4TRPI4OUsHO6itSI3/uF95z7dRcnA/YuqwwMB3HgbsL/fJLLQfo9E3U LvytSLplj2KG9sZP0V4XMvLLNBDycF0ipsmTjPgOyVjea2WPPHvQNVqeFlD0Dtunxf 5nbBHhmcoSEog== Message-ID: Date: Tue, 9 Aug 2022 13:38:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 1/3] Convert CONFIG_SYS_L2_PL310 to Kconfig Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: Philip Oberfichtner , u-boot@lists.denx.de, Christoph Niedermaier , Stefano Babic , Marcel Ziswiler , =?UTF-8?Q?Marek_Beh=c3=ban?= , Peng Fan , u-boot@dh-electronics.com References: <20220809100703.3101047-1-pro@denx.de> <20220809100703.3101047-2-pro@denx.de> <20220809105813.aa4vjcyiqm3mnqx4@pali> <41f76858-38d9-284b-1b54-b511f3b3cd67@denx.de> <20220809112151.jhrytuxraqcahzh5@pali> <4c124a1f-28cb-a805-ac6f-fd50ae2ee00e@denx.de> <20220809113224.4mvygsubvtb5wd7a@pali> From: Marek Vasut In-Reply-To: <20220809113224.4mvygsubvtb5wd7a@pali> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 8/9/22 13:32, Pali Rohár wrote: > On Tuesday 09 August 2022 13:27:38 Marek Vasut wrote: >> On 8/9/22 13:21, Pali Rohár wrote: >> >> (reducing the CC list) >> >>> On Tuesday 09 August 2022 13:16:41 Marek Vasut wrote: >>>> On 8/9/22 12:58, Pali Rohár wrote: >>>>> On Tuesday 09 August 2022 12:07:00 Philip Oberfichtner wrote: >>>>>> This converts CONFIG_SYS_L2_PL310 to Kconfig. >>>>> ... >>>>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >>>>>> index 949ebb46ba..dde06bdd96 100644 >>>>>> --- a/arch/arm/Kconfig >>>>>> +++ b/arch/arm/Kconfig >>>>>> @@ -488,6 +488,10 @@ config TPL_SYS_THUMB_BUILD >>>>>> density. For ARM architectures that support Thumb2 this flag will >>>>>> result in Thumb2 code generated by GCC. >>>>>> +config SYS_L2_PL310 >>>>>> + bool "ARM PL310 L2 cache controller" >>>>>> + help >>>>>> + Enable support for ARM PL310 L2 cache controller in U-Boot >>>>>> config SYS_L2CACHE_OFF >>>>>> bool "L2cache off" >>>>>> diff --git a/arch/arm/mach-mvebu/include/mach/config.h b/arch/arm/mach-mvebu/include/mach/config.h >>>>>> index 4add0d9e10..0bba0a4cf9 100644 >>>>>> --- a/arch/arm/mach-mvebu/include/mach/config.h >>>>>> +++ b/arch/arm/mach-mvebu/include/mach/config.h >>>>>> @@ -25,8 +25,6 @@ >>>>>> #define MV88F78X60 /* for the DDR training bin_hdr code */ >>>>>> #endif >>>>>> -#define CONFIG_SYS_L2_PL310 >>>>>> - >>>>>> #define MV_UART_CONSOLE_BASE MVEBU_UART0_BASE >>>>>> /* Needed for SPI NOR booting in SPL */ >>>>> >>>>> This option is required for mvebu SoC and is not user (de)-selectable. >>>>> So please do not define it in each individual mvebu board. It would make >>>>> it harder to introduce a new mvebu board into U-Boot. Instead enable it >>>>> for mvebu SoCs like it was before this change. It can be done e.g. by >>>>> "select" Kconfig keyword in mvebu Kconfig file. >>>> >>>> Should it rather be 'default y if MVEBU' in that new PL310 Kconfig option ? >>> >>> No, because this is just default value of this option and still allows >>> end-user to de-select this option. >>> >>> "select" is IIRC the only way how to force Kconfig to always enable some >>> symbol without any option for end-user to disable it. >>> >>> At least I do not know a way how CONFIG_SYS_L2_PL310 symbol could decide >>> that it is required for CONFIG_MVEBU. Just symbol CONFIG_MVEBU can >>> decide that it requires CONFIG_SYS_L2_PL310 symbol (and not in opposite >>> direction). >> >> So why should the user be unable to deselect L2CC support on MVEBU ? >> I can very well disable L2CC support on MX6 and the platform works without >> it just fine. Maybe the MVEBU needs to be fixed to support the same instead >> ? > > Well, I'm not sure, currently it is non-deselectable option. Maybe it is > a bug... but at least change which is doing kconfig conversion should > not change behavior. I agree -- I think your proposal to make this non-user-configurable is changing the behavior, see: Before -- you could comment the entry in include/configs/board.h out to deselect an option. After -- you can flip Kconfig switch to deselect an option.