From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965579AbcLVMeD (ORCPT ); Thu, 22 Dec 2016 07:34:03 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33191 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941020AbcLVMd6 (ORCPT ); Thu, 22 Dec 2016 07:33:58 -0500 Subject: Re: [PATCH 03/15] hyperv: use standard bitops To: Roman Kagan , Olaf Hering , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , "K. Y. Srinivasan" , Vitaly Kuznetsov , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Haiyang Zhang , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, "Denis V . Lunev" References: <20161220155602.6298-1-rkagan@virtuozzo.com> <20161220155602.6298-4-rkagan@virtuozzo.com> <20161221120044.GA15501@aepfle.de> <20161221132337.GA16492@rkaganb.sw.ru> From: Paolo Bonzini Message-ID: Date: Thu, 22 Dec 2016 13:33:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161221132337.GA16492@rkaganb.sw.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/12/2016 14:23, Roman Kagan wrote: > On Wed, Dec 21, 2016 at 01:00:44PM +0100, Olaf Hering wrote: >> On Tue, Dec 20, Roman Kagan wrote: >> >> Reverting commit 22356585712d ("staging: hv: use sync_bitops when >> interacting with the hypervisor") is save because ....... >> >>> - sync_set_bit(channel->monitor_bit, >>> + set_bit(channel->monitor_bit, > > It isn't indeed. I didn't realize there was a UP case where it made a > difference, and failed to locate the commit where it changed. > > I'll drop this part, thanks. Perhaps the sync_bitops should be renamed to virt_bitops. This would match virt_* memory barriers and would make their usage much more obvious. Paolo