From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 427B8C433F5 for ; Mon, 17 Jan 2022 13:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234798AbiAQNud (ORCPT ); Mon, 17 Jan 2022 08:50:33 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:44740 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232312AbiAQNuZ (ORCPT ); Mon, 17 Jan 2022 08:50:25 -0500 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1474A3F1E1 for ; Mon, 17 Jan 2022 13:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642427422; bh=ePAMBME9OoqmLqu9TGmOOJDOdAhBTNGeiMQzo5Zcwk8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p2L2naqWUq4zjq9/tg6HP3ypMaxh6QA/ZQqPNgq8J+075Lg1ef6dOjX3hmVILJYLG 0VLzaro4l9yp9dhARyc3dmmb2HI0YhLaPoblvnOzKSQ1/hWrK8w/Lai3kVdfBOc4i3 q9QEZaecc1HECKMtwruxwbJdq9wuE7fDsfiRp3QZ63PkDgJrXgxaXewGOAHMaV1AL2 lT5ZZGafpKtbCYLGIW9HdIAcsb7dhPB0fFjr2zdf0HUbRC7fB/j2oEMXHKnv9jHu1q d3esT3Ndf9RiTGP9d3SlYo/pLf4qOITeGZIT5YDzGwaOM+HbIYwLPHbIUyBbzEoBeb VB27KXLEcTGZw== Received: by mail-ed1-f71.google.com with SMTP id s9-20020aa7d789000000b004021d03e2dfso3989421edq.18 for ; Mon, 17 Jan 2022 05:50:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ePAMBME9OoqmLqu9TGmOOJDOdAhBTNGeiMQzo5Zcwk8=; b=wncLOMfc8K2qP++oF065dmRavrS37S+Ej0fszfwvCqn10GypKbu8JDLPMKhetmqMVg kxjTcNCMQafi1LGwJ4G2njnMLK3FAnHY0AVzmUuIvFOORPzCSBW5IwhNCg6ZoVxfDd1M jTkumwtRgobiXnHUljwVjoLAYSb6VVlputR74Y+u06uGBGExnAu611pQlN1eK3CwZ+vl sX/gDInHbAz+6ehRma1NFGdUww20vijlAH0GvzrjzJ5SQj48zUeJP2PTmlGDR8KZxDlB L8+3eSUQWlrtSDxvwrN74BWAXX2x+Y4fV8BLSB8Nio41aRpjf7SNRjEuomgQM/G998dH ylWg== X-Gm-Message-State: AOAM533ZPDPpgsF0gdszT6vIrgWxEK/rdl3PgWJKwWzVl9oNG+osS75i HxpT4vqqMVEpmIMnqOyTuSKweTqqLpfBMgHrc/Oo4SeYlFl2Q7CRk6zvjTXyNRKJa5xnCdiZhpk 47zsJXn/qxJ7iI6+FPxAkpSwBilvwermGJf0xz4Q2Lw== X-Received: by 2002:a17:906:5d16:: with SMTP id g22mr5071268ejt.295.1642427419808; Mon, 17 Jan 2022 05:50:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJxq9DzOXYxEW3Jq0YclwQkYlU99PzXh2g5H9926DHwMIx90PvG8ZqFXXD4IU5OjfMoVVLw8EQ== X-Received: by 2002:a17:906:5d16:: with SMTP id g22mr5071248ejt.295.1642427419602; Mon, 17 Jan 2022 05:50:19 -0800 (PST) Received: from [192.168.0.38] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id p10sm4535501ejo.14.2022.01.17.05.50.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jan 2022 05:50:19 -0800 (PST) Message-ID: Date: Mon, 17 Jan 2022 14:50:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 15/23] arm64: dts: fsd: Add initial pinctrl support Content-Language: en-US To: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: soc@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, olof@lixom.net, linus.walleij@linaro.org, catalin.marinas@arm.com, robh+dt@kernel.org, s.nawrocki@samsung.com, linux-samsung-soc@vger.kernel.org, pankaj.dubey@samsung.com, linux-fsd@tesla.com, 'Shashank Prashar' , 'Aswani Reddy' References: <20220113121143.22280-1-alim.akhtar@samsung.com> <20220113121143.22280-16-alim.akhtar@samsung.com> <2927c34e-3259-4e9a-a657-aeeebf9089d2@canonical.com> <00ca01d80ba8$6b9b9800$42d2c800$@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <00ca01d80ba8$6b9b9800$42d2c800$@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/01/2022 14:44, Alim Akhtar wrote: > Hi Krzysztof > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >> Sent: Thursday, January 13, 2022 6:50 PM >> To: Alim Akhtar ; linux-arm- >> kernel@lists.infradead.org; linux-kernel@vger.kernel.org >> Cc: soc@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; >> olof@lixom.net; linus.walleij@linaro.org; catalin.marinas@arm.com; >> robh+dt@kernel.org; s.nawrocki@samsung.com; linux-samsung- >> soc@vger.kernel.org; pankaj.dubey@samsung.com; linux-fsd@tesla.com; >> Shashank Prashar ; Aswani Reddy >> >> Subject: Re: [PATCH 15/23] arm64: dts: fsd: Add initial pinctrl support >> >> On 13/01/2022 13:11, Alim Akhtar wrote: >>> Add initial pin configuration nodes for FSD SoC. >>> >>> Cc: linux-fsd@tesla.com >>> Signed-off-by: Shashank Prashar >>> Signed-off-by: Aswani Reddy >>> Signed-off-by: Alim Akhtar >>> --- >>> arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 338 >> +++++++++++++++++++++ >>> arch/arm64/boot/dts/tesla/fsd.dtsi | 22 ++ >>> 2 files changed, 360 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>> >>> diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>> b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>> new file mode 100644 >>> index 000000000000..ec8d944af636 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>> @@ -0,0 +1,338 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Tesla Full Self-Driving SoC device tree source >>> + * >>> + * Copyright (c) 2017-2021 Samsung Electronics Co., Ltd. >>> + * https://www.samsung.com >>> + * Copyright (c) 2017-2021 Tesla, Inc. >>> + * https://www.tesla.com >>> + */ >>> + >>> +#include >>> + >>> +&pinctrl_fsys0 { >>> + >> >> No need for empty line. >> > Noted > >>> + gpf0: gpf0 { >> >> FYI: >> It's ok now, but the nodes will have to be renamed to "xxx-gpio-bank" later. >> > Have rebased my v2 on your pinmux schema update, so these and below comments are addressed. > Thanks > OK, but have in mind that -gpio-bank suffix is not needed now. This depends on support in the pinctrl driver, which will be applied after the merge window to different tree or branches than DTS is going to. Therefore if I apply your DTS with "-gpio-bank" to my next/dt64, the kernel won't find GPIo banks and won't properly boot. The linux-next will be fine, just my next/dt64 won't be. If you're fine with it - use "-gpio-bank" suffix. If you prefer my next/dt64 to have a fully working Tesla SoC DTS, then stick to old node naming and let's replace it later. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80F1EC433EF for ; Mon, 17 Jan 2022 13:51:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yH6Y+RUS59uwKOT0TkhwpbEWCF90aXK7v4JMHFzgE6g=; b=NmzYMQBc0l/HE1 pSRDfjPASbjhc306yy6tvKB9LKl33lq/Ww5tmdv7hggFzdx1/FXoDVm7//vbkmbTaw0OCeRWXRcU7 sCcIBMSONvAmpo3yhS1i5d4qsadUiKaAJlc4iSr0vedv6u9pYlEfkqXUFjVbvve8BxcOJB3ksXbLl dvNCOTSmPuo+BQkyPJHYvIcD8ycZjFzHgG2eZZVq8WQq16sYc0bJKyT9lHBhl1VTpa1yfonhffjDh UEvbTndkU45cDZZc6lV9R29XWWiJAzKi25EFsSHeeWLE+zcKRMFNlTnm23OC8LfFaRp+LO0+mgqZS YQGX7zhr5RJsfB+ay/sA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9SP5-00F5EN-5B; Mon, 17 Jan 2022 13:50:35 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9SOz-00F5C4-99 for linux-arm-kernel@lists.infradead.org; Mon, 17 Jan 2022 13:50:32 +0000 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 1FBE33F1EA for ; Mon, 17 Jan 2022 13:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642427420; bh=ePAMBME9OoqmLqu9TGmOOJDOdAhBTNGeiMQzo5Zcwk8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qYpVx9pf5VQGuA7rAL1a7osKjrcHLUD7/QSyjWuGuGioAJZwSo620aWXsQmM2viat 00at9RH4UZzs4qwrwm11+eyRf3ciw1s1NhdSqYBR330JvWwNQ8VY5pjO+XBmLIcbk5 mk7c/xSB8sPTk3djbgiXziw07Jsjt4SKDDDgpWU0Twf6p5NoebeBZ5gVpXhEpZg5MX K2ykbqM2s5DpwJTYoJESk5yE0J0x7BMBLMAfZidFPoLnUaG0jG/i7iDthr15DLCTaQ JgsI6pKpnb2KqFo1AfoyR1QIG4GUyHmJ7IvjJq7IY3HxhtfzcFZ/DM187GsjsPiApe DtJdTL+CTWfPQ== Received: by mail-ed1-f71.google.com with SMTP id l14-20020aa7cace000000b003f7f8e1cbbdso14191498edt.20 for ; Mon, 17 Jan 2022 05:50:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ePAMBME9OoqmLqu9TGmOOJDOdAhBTNGeiMQzo5Zcwk8=; b=e2WF1lQiI2+zUQ0kN8TZWLswMqgnddu3GsV52g9kJWej6cSenq+PIDaX05RANVBZHh a+YKrYmCbkK/I0wITs79GFbocLrYxPTOwbr3Xo/fyGxAYRYDOxAPrZRrfK5Z2TvO1syZ psH04JJh6Iwq9nEGHVtjDdLXotX8UVDVKeDhSCpPXAa1+3s6eOs8I75Kabjjw8lD8kz7 CeFQRQDs5b+t7nIynlylW7M5ZsrqFqbMXXcHgpQh9d4xeGlq4llLGAukFKGC7umKb/IK nAav46wbouSelR4AudNCa/hQiRHh7ASQW0V4yR9lNvuPvZICPz6WqnyCL4GaXe0Rah7r leRQ== X-Gm-Message-State: AOAM530NPA+n+RYW1VA/0VxXKV3kpmQJ8Bv2fx90IrysySL+v5vtmmpL Y4BkpcHJpI89cDMvYv8c+biXJJqaD9Fm1kp9b2uJyKFuJMhKqN6zLavQvUCiqlYWNf3dvX7qt4t qyC941YAOZJvj25SpUfzqSdTuoWLeBRqqVnG1ezFBA3AmZ025sMO4 X-Received: by 2002:a17:906:5d16:: with SMTP id g22mr5071276ejt.295.1642427419819; Mon, 17 Jan 2022 05:50:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJxq9DzOXYxEW3Jq0YclwQkYlU99PzXh2g5H9926DHwMIx90PvG8ZqFXXD4IU5OjfMoVVLw8EQ== X-Received: by 2002:a17:906:5d16:: with SMTP id g22mr5071248ejt.295.1642427419602; Mon, 17 Jan 2022 05:50:19 -0800 (PST) Received: from [192.168.0.38] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id p10sm4535501ejo.14.2022.01.17.05.50.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jan 2022 05:50:19 -0800 (PST) Message-ID: Date: Mon, 17 Jan 2022 14:50:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 15/23] arm64: dts: fsd: Add initial pinctrl support Content-Language: en-US To: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: soc@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, olof@lixom.net, linus.walleij@linaro.org, catalin.marinas@arm.com, robh+dt@kernel.org, s.nawrocki@samsung.com, linux-samsung-soc@vger.kernel.org, pankaj.dubey@samsung.com, linux-fsd@tesla.com, 'Shashank Prashar' , 'Aswani Reddy' References: <20220113121143.22280-1-alim.akhtar@samsung.com> <20220113121143.22280-16-alim.akhtar@samsung.com> <2927c34e-3259-4e9a-a657-aeeebf9089d2@canonical.com> <00ca01d80ba8$6b9b9800$42d2c800$@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <00ca01d80ba8$6b9b9800$42d2c800$@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220117_055029_564912_83CF461A X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/01/2022 14:44, Alim Akhtar wrote: > Hi Krzysztof > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >> Sent: Thursday, January 13, 2022 6:50 PM >> To: Alim Akhtar ; linux-arm- >> kernel@lists.infradead.org; linux-kernel@vger.kernel.org >> Cc: soc@kernel.org; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; >> olof@lixom.net; linus.walleij@linaro.org; catalin.marinas@arm.com; >> robh+dt@kernel.org; s.nawrocki@samsung.com; linux-samsung- >> soc@vger.kernel.org; pankaj.dubey@samsung.com; linux-fsd@tesla.com; >> Shashank Prashar ; Aswani Reddy >> >> Subject: Re: [PATCH 15/23] arm64: dts: fsd: Add initial pinctrl support >> >> On 13/01/2022 13:11, Alim Akhtar wrote: >>> Add initial pin configuration nodes for FSD SoC. >>> >>> Cc: linux-fsd@tesla.com >>> Signed-off-by: Shashank Prashar >>> Signed-off-by: Aswani Reddy >>> Signed-off-by: Alim Akhtar >>> --- >>> arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 338 >> +++++++++++++++++++++ >>> arch/arm64/boot/dts/tesla/fsd.dtsi | 22 ++ >>> 2 files changed, 360 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>> >>> diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>> b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>> new file mode 100644 >>> index 000000000000..ec8d944af636 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>> @@ -0,0 +1,338 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Tesla Full Self-Driving SoC device tree source >>> + * >>> + * Copyright (c) 2017-2021 Samsung Electronics Co., Ltd. >>> + * https://www.samsung.com >>> + * Copyright (c) 2017-2021 Tesla, Inc. >>> + * https://www.tesla.com >>> + */ >>> + >>> +#include >>> + >>> +&pinctrl_fsys0 { >>> + >> >> No need for empty line. >> > Noted > >>> + gpf0: gpf0 { >> >> FYI: >> It's ok now, but the nodes will have to be renamed to "xxx-gpio-bank" later. >> > Have rebased my v2 on your pinmux schema update, so these and below comments are addressed. > Thanks > OK, but have in mind that -gpio-bank suffix is not needed now. This depends on support in the pinctrl driver, which will be applied after the merge window to different tree or branches than DTS is going to. Therefore if I apply your DTS with "-gpio-bank" to my next/dt64, the kernel won't find GPIo banks and won't properly boot. The linux-next will be fine, just my next/dt64 won't be. If you're fine with it - use "-gpio-bank" suffix. If you prefer my next/dt64 to have a fully working Tesla SoC DTS, then stick to old node naming and let's replace it later. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel