From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/kvazaar: needs C++ compiler
Date: Wed, 5 Jul 2017 01:11:29 +0200 [thread overview]
Message-ID: <b82b44cd-f94f-6cee-039a-99f1eb1fe03e@mind.be> (raw)
In-Reply-To: <20170704230857.7916-2-romain.naour@smile.fr>
On 05-07-17 01:08, Romain Naour wrote:
> Even if there is only one CPP file src/extras/crypto.cpp which should
> be disabled by --without-cryptopp, kvazaar fail to build the shared
> library libkvazaar.so when no C++ compiler is available.
>
> checking whether we are using the GNU C++ compiler... no
>
> Fixes:
> [microblazel] http://autobuild.buildroot.net/results/5d1/5d140ed95e292f73b6770a5e5be717df844e4830
> [arm] http://autobuild.buildroot.net/results/c55/c55b973502b9b88643ae9fca11447b547148275d
>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> package/kvazaar/Config.in | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/package/kvazaar/Config.in b/package/kvazaar/Config.in
> index 06ab9ac..de2c6c9 100644
> --- a/package/kvazaar/Config.in
> +++ b/package/kvazaar/Config.in
> @@ -1,10 +1,11 @@
> config BR2_PACKAGE_KVAZAAR
> bool "kvazaar"
> + depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_TOOLCHAIN_HAS_THREADS
> help
> An open-source HEVC encoder licensed under LGPLv2.1
>
> https://github.com/ultravideo/kvazaar
>
> -comment "kvazaar needs a toolchain w/ threads"
> - depends on !BR2_TOOLCHAIN_HAS_THREADS
> +comment "kvazaar needs a toolchain w/ C++, threads"
> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2017-07-04 23:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 23:08 [Buildroot] [PATCH 1/3] package/kvazaar: add host-pkgconf dependency Romain Naour
2017-07-04 23:08 ` [Buildroot] [PATCH 2/3] package/kvazaar: needs C++ compiler Romain Naour
2017-07-04 23:11 ` Arnout Vandecappelle [this message]
2017-07-04 23:08 ` [Buildroot] [PATCH 3/3] package/kvazaar: needs BR2_TOOLCHAIN_HAS_SYNC_4 Romain Naour
2017-07-04 23:11 ` Arnout Vandecappelle
2017-07-04 23:11 ` [Buildroot] [PATCH 1/3] package/kvazaar: add host-pkgconf dependency Arnout Vandecappelle
2017-07-04 23:20 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b82b44cd-f94f-6cee-039a-99f1eb1fe03e@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.