From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F40DC433FE for ; Mon, 16 May 2022 07:12:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239908AbiEPHL7 (ORCPT ); Mon, 16 May 2022 03:11:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240940AbiEPHLK (ORCPT ); Mon, 16 May 2022 03:11:10 -0400 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 603DEBBF for ; Mon, 16 May 2022 00:11:06 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=chengyou@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VDGGYBi_1652685062; Received: from 30.43.106.100(mailfrom:chengyou@linux.alibaba.com fp:SMTPD_---0VDGGYBi_1652685062) by smtp.aliyun-inc.com(127.0.0.1); Mon, 16 May 2022 15:11:03 +0800 Message-ID: Date: Mon, 16 May 2022 15:11:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH for-next v7 12/12] RDMA/erdma: Add driver to kernel build environment Content-Language: en-US From: Cheng Xu To: Jason Gunthorpe Cc: dledford@redhat.com, leon@kernel.org, linux-rdma@vger.kernel.org, KaiShen@linux.alibaba.com, tonylu@linux.alibaba.com, BMT@zurich.ibm.com References: <20220421071747.1892-1-chengyou@linux.alibaba.com> <20220421071747.1892-13-chengyou@linux.alibaba.com> <20220510131841.GB1093822@nvidia.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 5/16/22 11:40 AM, Cheng Xu wrote: > > > On 5/10/22 9:18 PM, Jason Gunthorpe wrote: >> On Thu, Apr 21, 2022 at 03:17:47PM +0800, Cheng Xu wrote: >>> Signed-off-by: Cheng Xu >>> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig >>> index 33d3ce9c888e..cc6a7ff88ff3 100644 >>> +++ b/drivers/infiniband/Kconfig >>> @@ -92,6 +92,7 @@ source "drivers/infiniband/hw/hns/Kconfig" >>>   source "drivers/infiniband/hw/bnxt_re/Kconfig" >>>   source "drivers/infiniband/hw/hfi1/Kconfig" >>>   source "drivers/infiniband/hw/qedr/Kconfig" >>> +source "drivers/infiniband/hw/erdma/Kconfig" >>>   source "drivers/infiniband/sw/rdmavt/Kconfig" >>>   source "drivers/infiniband/sw/rxe/Kconfig" >>>   source "drivers/infiniband/sw/siw/Kconfig" >> >> keep sorted >> > > OK, I thought the order follows the rule: "comes first, appears first", > so I add our drivers to the tail of "drivers/infiniband/hw/..." > > Since the current list is not sorted, and if it should be, I will fix > this in next version. > >>> diff --git a/drivers/infiniband/hw/Makefile >>> b/drivers/infiniband/hw/Makefile >>> index fba0b3be903e..6b3a88046125 100644 >>> +++ b/drivers/infiniband/hw/Makefile >>> @@ -13,3 +13,4 @@ obj-$(CONFIG_INFINIBAND_HFI1)        += hfi1/ >>>   obj-$(CONFIG_INFINIBAND_HNS)        += hns/ >>>   obj-$(CONFIG_INFINIBAND_QEDR)        += qedr/ >>>   obj-$(CONFIG_INFINIBAND_BNXT_RE)    += bnxt_re/ >>> +obj-$(CONFIG_INFINIBAND_ERDMA)        += erdma/ >>> diff --git a/drivers/infiniband/hw/erdma/Kconfig >>> b/drivers/infiniband/hw/erdma/Kconfig >>> new file mode 100644 >>> index 000000000000..c90f2be1ea63 >>> +++ b/drivers/infiniband/hw/erdma/Kconfig >>> @@ -0,0 +1,12 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only >>> +config INFINIBAND_ERDMA >>> +    tristate "Alibaba Elastic RDMA Adapter (ERDMA) support" >>> +    depends on PCI_MSI && 64BIT && !CPU_BIG_ENDIAN >> >> Why !CPU_BIG_ENDIAN? That is usually not OK. > > we want use !CPU_BIG_ENDIAN to disable the erdma compilation on big > endian machine, because we only have little endian machines, and > don't support big endian machines. I have no idea why it is usually not > OK, could you explain it any more? > > Thanks > >> Did you run sparse on this? >> > > No, I will check this. I think this may be OK, because EFA also use > !CPU_BIG_ENDIAN in the same way. > I use the command 'make C=2' as the document says to check the code, It seems ok, except some warnings. I reviewed and checked the warnings in erdma part. Fix them or not fix, is all OK for functionality. Is cleaning the warnings necessary for upstream? If so, I will work on it. Thanks Cheng Xu > Thanks, > Cheng Xu > >> Jason