From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69237C4338F for ; Thu, 29 Jul 2021 00:12:31 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C44560F02 for ; Thu, 29 Jul 2021 00:12:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3C44560F02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9D89482D73; Thu, 29 Jul 2021 02:12:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="i6aMCmVT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9B26D82D73; Thu, 29 Jul 2021 02:12:25 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2D1A382D73 for ; Thu, 29 Jul 2021 02:12:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1627517540; bh=KNDXNW++SZVc+02LiDrg4nsCmXeuZyrBzqmXpYFvWIg=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=i6aMCmVTvrwSmrEe5aBhZpcbrGay6HgYYR0fpguIElFIkme/VmEZ5yb+cTZRBvzD5 0ZFBMfvH2fyp4OH8qM+acA/aH14UBAZ50Bnd6yO5cKs1en51h8yE09qms0O9/cLDKt a2nt0wrXck8dSBh/UGCbIWa89CLpc5Rd54HsahDA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([88.152.144.157]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MV63q-1maqMU2Cog-00S4Rg; Thu, 29 Jul 2021 02:12:20 +0200 Subject: Re: [PATCH v2 8/9] Add an option for EBBR To: Simon Glass Cc: Ilias Apalodimas , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Mark Kettenis , U-Boot Mailing List , Tom Rini References: <20210702183620.1542680-1-sjg@chromium.org> <20210702183620.1542680-5-sjg@chromium.org> From: Heinrich Schuchardt Message-ID: Date: Thu, 29 Jul 2021 02:12:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210702183620.1542680-5-sjg@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:qYuMYYXep0kGSqgBbs+mHfRgTPsszOgz6Mut/CRJpAaWC1u8M11 om9lnCutL899fWk/x1GNTIn0hQHaUpsJnWUwggLpWkrRBBvvAkYdWXpD1h1plb5OfN0R3pk fG3uciUNeVuEQEaY2GsmE3Fz8r851DQlGJZeChZdlvqjf+esVPhG3LctoGKzOA/uxrgf9YX 19wmricfL4l2cE8BNyvsQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:ma6uPLLdOHs=:cV5QK1vvTgpquCfjQigMFq QpIifo3tRp+gp67Q1pwJD8snzcwJ0FFeH2EZA0eCIwtwp/92Hh3UkwwuxC5VSrSrTsxkDjsFz 43Qxl/PkpRYJVw63DXazdssx3m/XW9RssFLItveGphAS/Rs13Y9Zd1XL6BtZju57XXkiiQpcW sEH4nrT5ytcNqmrvZvCxGjyP5iuObLZsUWWwZaoqbX8vuMoHd4dz2vOWPabaDYoNlATV3JtEc uLR8phDTBZDhFBTu26BKT18zJSVzwl24PeybBTRXr7MCLAFatIyUaDtCC2XSR8iHo8jVuFsAP w/VebrWEgep8Hf0jj15T+ePJdLQ2wZ/TYoIP88YEpm0ZewbqaL+5vJymMFoR4W2Pi0cis8j0t HlJLz3GI2zUUy12D4b5MxEPFeb8Hvkvh2USxD5zN6gAfD9qvyvpVbUviJzxq9gYmZ7GN79Ni/ CoRKLqTKJ2IdREDY9y7MBJZPTo6gsP/fabqN480v1YDP/Rl5IkvO0vZIO2u6QROCKhH0BTTwS SMcmjuIh2f9LgkfGW11ve4C7sX+5AGRVOmcjDboT2qDBpnp7s6mY92m5kjf08miDB3Mhk80MY m8y69OA9hUBrTIWMi/hRhx25/q8Db9g0B6v5jnpYv/8PAM++XywOc6TqughmZqzazHERk7g+m DuP4yOS3/1DbyveMMVWqeLDne0RY+MBrk8+4xKg8rrjhU6/jc/SH5GdpEL2qtZBO7ra2xgtx8 U1G08bWkQPwmOyGSWm5W9E0oagGaMPsEeXJf1jy+ioU/hNvpae2Ba5W1u02h6PsEHPHZ76ja/ pYDVlrYepXeJRka4K0tmsZyt7jB2JeuAvUVwD9NeRdFsqgczbz+lw/o4XU7MDL3BHpiNpWzEC Sw2GrsMIfxL7ykBDwmDqRqC9bY7AMPt+vbYtgSzNsL5jfaTJkXKTxjrhKkGvJK8xtqKMRcqz2 l8cRAV3zM+wgqBLuM03KoPvWU84xt1p643rM6J9XqMaQMQwqbgh94DcJ/8lhpCB5UNCiSUiqY dyeNbMIHjs2NCFqrvLz20v2CFwrK+/DHKbIVFKWGBKAYoPBxSwKiNZaIhPHTAP6OKJrq8/JTy 3hy82BMb2ghbD/IWxpESBXEsBgYAhBqe+X0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 7/2/21 8:36 PM, Simon Glass wrote: > Add a new Kconfig option for EBBR so that the naming is more explicit. > Make it select EFI_LOADER which is required for EBBR to work. > > Copy over the same 'default' setting so that there is no change in > which boards enable it. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Split out new patch to create an option for EBBR > > common/Kconfig.boot | 16 ++++++++++++++++ > lib/efi_loader/Kconfig | 1 - > 2 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/common/Kconfig.boot b/common/Kconfig.boot > index 89a3161f1fa..111032e1202 100644 > --- a/common/Kconfig.boot > +++ b/common/Kconfig.boot > @@ -300,6 +300,22 @@ config LEGACY_IMAGE_FORMAT > loaded. If a board needs the legacy image format support in this > case, enable it here. > > +config EBBR > + bool "Enable support for Embeeded Boot Base Requirements (EBBR)" > + select EFI_LOADER > + default y if !ARM || SYS_CPU =3D armv7 || SYS_CPU =3D armv8 This won't work. You cannot have UEFI neither on big-endian systems nor on any other architecture not mentioned in the UEFI specification. Why do you want to exclude arm1136 and arm1176? > + help > + Enable this to support ARM's EBBR boot method. This bases everything > + on UEFI protocols.=C2=B4 EBBR is explitely not ARM specific. EBBR is not a boot method but a subset of the UEFI specification. > + > + This Embedded Base Boot Requirements (EBBR) specification defines an > + interface between platform firmware and an operating system that is > + suitable for embedded platforms. EBBR-compliant platforms present a > + consistent interface that will boot an EBBR-compliant operating > + system without any custom tailoring required. For example, an Arm > + A-class embedded platform will benefit from a standard interface tha= t > + supports features such as secure boot and firmware update. Which user will ever have heard of the EBBR specification? Referencing it in Kconfig will lead to confusion. This new symbol is redundant. If you think that a better name for EFI_LOADER is needed, please suggest one. Best regards Heinrich > + > config SUPPORT_RAW_INITRD > bool "Enable raw initrd images" > help > diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig > index 466abfed300..bc5fb3f5e03 100644 > --- a/lib/efi_loader/Kconfig > +++ b/lib/efi_loader/Kconfig > @@ -10,7 +10,6 @@ config EFI_LOADER > depends on !EFI_STUB || !X86_64 || EFI_STUB_64BIT > # We need EFI_STUB_32BIT to be set on x86_32 with EFI_STUB > depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT > - default y if !ARM || SYS_CPU =3D armv7 || SYS_CPU =3D armv8 > select LIB_UUID > select HAVE_BLOCK_DEVICE > select REGEX >