From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Sun, 12 Jun 2016 19:50:20 +0200 Subject: [U-Boot] [PATCH] sunxi: Revert "sunxi: make SoC variant choice mandatory" In-Reply-To: <1465734303.22752.21.camel@hellion.org.uk> References: <1465729412-25686-1-git-send-email-hdegoede@redhat.com> <1465734303.22752.21.camel@hellion.org.uk> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 12-06-16 14:25, Ian Campbell wrote: > On Sun, 2016-06-12 at 13:03 +0200, Hans de Goede wrote: >> This reverts commit 1a5f0de08e86("sunxi: make SoC variant choice >> mandatory"). >> >> With the optional marking in the Kconfig "make savedefconfig" >> will drop CONFIG_MACH_SUN4I=y from all the A10 boards, making it >> hard to see at a glance which family of sunxi chips the defconfig >> is for. >> >> This commit therefore restores the optional, and restores >> CONFIG_MACH_SUN4I=y to all defconfig's which had it dropped >> because of this. > > Is this because the first config in a choice is considered the default > and hence is omitted by savedefconfig Yes, exactly. > or is something else going on? > > In any case: > >> Signed-off-by: Hans de Goede > > Acked-by: Ian Campbell Thanks for all the reviews! Regards, Hans p.s. I've just send out another patch for a new board