All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [Intel-gfx] [PATCH 5/5] drm/i915/fdi: convert BUG()'s to MISSING_CASE()
Date: Wed, 25 Aug 2021 18:47:52 +0300	[thread overview]
Message-ID: <b86132ac63f43f79e51eb63f948beccba85bf449.1629906431.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1629906431.git.jani.nikula@intel.com>

These shouldn't happen, but in the off chance they do, we'll want a
warning rather than panic.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_fdi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c b/drivers/gpu/drm/i915/display/intel_fdi.c
index cc83a6532a71..fc09b781f15f 100644
--- a/drivers/gpu/drm/i915/display/intel_fdi.c
+++ b/drivers/gpu/drm/i915/display/intel_fdi.c
@@ -93,7 +93,8 @@ static int ilk_check_fdi_lanes(struct drm_device *dev, enum pipe pipe,
 		}
 		return 0;
 	default:
-		BUG();
+		MISSING_CASE(pipe);
+		return 0;
 	}
 }
 
@@ -217,7 +218,7 @@ static void ivb_update_fdi_bc_bifurcation(const struct intel_crtc_state *crtc_st
 
 		break;
 	default:
-		BUG();
+		MISSING_CASE(crtc->pipe);
 	}
 }
 
-- 
2.20.1


  parent reply	other threads:[~2021-08-25 15:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 15:47 [Intel-gfx] [PATCH 0/5] drm/i915/fdi: refactor some fdi code out of intel_display.c Jani Nikula
2021-08-25 15:47 ` [Intel-gfx] [PATCH 1/5] drm/i915/fdi: move intel_update_fdi_pll_freq to intel_fdi.c Jani Nikula
2021-08-26 19:36   ` Rodrigo Vivi
2021-08-27  9:13     ` Jani Nikula
2021-08-25 15:47 ` [Intel-gfx] [PATCH 2/5] drm/i915/fdi: move fdi bc bifurcation functions " Jani Nikula
2021-08-26 19:37   ` Rodrigo Vivi
2021-08-25 15:47 ` [Intel-gfx] [PATCH 3/5] drm/i915/fdi: move more FDI stuff to FDI link train hooks Jani Nikula
2021-08-26 19:43   ` Rodrigo Vivi
2021-08-25 15:47 ` [Intel-gfx] [PATCH 4/5] drm/i915/fdi: move fdi mphy reset and programming to intel_fdi.c Jani Nikula
2021-08-26 19:44   ` Rodrigo Vivi
2021-08-25 15:47 ` Jani Nikula [this message]
2021-08-26 19:44   ` [Intel-gfx] [PATCH 5/5] drm/i915/fdi: convert BUG()'s to MISSING_CASE() Rodrigo Vivi
2021-08-25 21:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/fdi: refactor some fdi code out of intel_display.c Patchwork
2021-08-25 21:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-08-26  3:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b86132ac63f43f79e51eb63f948beccba85bf449.1629906431.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.