All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices
@ 2021-09-20 18:21 Krzysztof Kozlowski
  2021-09-20 18:21 ` [PATCH 2/6] dt-bindings: hwmon: lm75: remove gmt,g751 from " Krzysztof Kozlowski
                   ` (6 more replies)
  0 siblings, 7 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-20 18:21 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Jiri Kosina,
	Jonathan Cameron, Krzysztof Kozlowski, linux-hwmon, devicetree,
	linux-kernel

The lm70 thermometer bindings are trivial, so like many other I2C/SPI
temperature sensors can be integrated into trivial devices bindings.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .../devicetree/bindings/hwmon/lm70.txt        | 22 -------------------
 .../devicetree/bindings/trivial-devices.yaml  |  8 +++++++
 2 files changed, 8 insertions(+), 22 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/lm70.txt

diff --git a/Documentation/devicetree/bindings/hwmon/lm70.txt b/Documentation/devicetree/bindings/hwmon/lm70.txt
deleted file mode 100644
index ea417a0d32af..000000000000
--- a/Documentation/devicetree/bindings/hwmon/lm70.txt
+++ /dev/null
@@ -1,22 +0,0 @@
-* LM70/TMP121/LM71/LM74 thermometer.
-
-Required properties:
-- compatible: one of
-		"ti,lm70"
-		"ti,tmp121"
-		"ti,tmp122"
-		"ti,lm71"
-		"ti,lm74"
-
-See Documentation/devicetree/bindings/spi/spi-bus.txt for more required and
-optional properties.
-
-Example:
-
-spi_master {
-	temperature-sensor@0 {
-		compatible = "ti,lm70";
-		reg = <0>;
-		spi-max-frequency = <1000000>;
-	};
-};
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 1eb4ce7dcdfd..183ee0da22c6 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -303,8 +303,13 @@ properties:
           - ti,hdc1050
             # Temperature and humidity sensor with i2c interface
           - ti,hdc1080
+            # Thermometer with SPI interface
+          - ti,lm70
+          - ti,lm71
             # Temperature sensor with 2-wire interface
           - ti,lm73
+            # Thermometer with SPI interface
+          - ti,lm74
             # Temperature sensor with integrated fan control
           - ti,lm96000
             # I2C Touch-Screen Controller
@@ -313,6 +318,9 @@ properties:
           - ti,tmp102
             # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
           - ti,tmp103
+            # Thermometer with SPI interface
+          - ti,tmp121
+          - ti,tmp122
             # Digital Temperature Sensor
           - ti,tmp275
             # TI Dual channel DCAP+ multiphase controller TPS53676 with AVSBus
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 2/6] dt-bindings: hwmon: lm75: remove gmt,g751 from trivial devices
  2021-09-20 18:21 [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Krzysztof Kozlowski
@ 2021-09-20 18:21 ` Krzysztof Kozlowski
  2021-09-23 21:13   ` Rob Herring
  2021-09-24  2:05   ` Guenter Roeck
  2021-09-20 18:21 ` [PATCH 3/6] dt-bindings: hwmon: dps650ab: move to " Krzysztof Kozlowski
                   ` (5 subsequent siblings)
  6 siblings, 2 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-20 18:21 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Jiri Kosina,
	Jonathan Cameron, Krzysztof Kozlowski, linux-hwmon, devicetree,
	linux-kernel

gmt,g751 is covered by LM75 sensor bindings.  This fixes warning:

  arch/arm/boot/dts/gemini-dlink-dns-313.dt.yaml: temperature-sensor@48:
    '#thermal-sensor-cells' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 183ee0da22c6..1bbfa98a85d8 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -109,8 +109,6 @@ properties:
           - mps,mp2888
             # Monolithic Power Systems Inc. multi-phase controller mp2975
           - mps,mp2975
-            # G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire Interface
-          - gmt,g751
             # Infineon IR36021 digital POL buck controller
           - infineon,ir36021
             # Infineon IR38064 Voltage Regulator
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 3/6] dt-bindings: hwmon: dps650ab: move to trivial devices
  2021-09-20 18:21 [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Krzysztof Kozlowski
  2021-09-20 18:21 ` [PATCH 2/6] dt-bindings: hwmon: lm75: remove gmt,g751 from " Krzysztof Kozlowski
@ 2021-09-20 18:21 ` Krzysztof Kozlowski
  2021-09-23 21:14   ` Rob Herring
  2021-09-24  2:06   ` Guenter Roeck
  2021-09-20 18:21 ` [PATCH 4/6] dt-bindings: hwmon: hih6130: " Krzysztof Kozlowski
                   ` (4 subsequent siblings)
  6 siblings, 2 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-20 18:21 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Jiri Kosina,
	Jonathan Cameron, Krzysztof Kozlowski, linux-hwmon, devicetree,
	linux-kernel

The dps650ab bindings are trivial, so it can be integrated into trivial
devices bindings.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 Documentation/devicetree/bindings/hwmon/dps650ab.txt  | 11 -----------
 .../devicetree/bindings/trivial-devices.yaml          |  2 ++
 2 files changed, 2 insertions(+), 11 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/dps650ab.txt

diff --git a/Documentation/devicetree/bindings/hwmon/dps650ab.txt b/Documentation/devicetree/bindings/hwmon/dps650ab.txt
deleted file mode 100644
index 76780e795899..000000000000
--- a/Documentation/devicetree/bindings/hwmon/dps650ab.txt
+++ /dev/null
@@ -1,11 +0,0 @@
-Bindings for Delta Electronics DPS-650-AB power supply
-
-Required properties:
-- compatible : "delta,dps650ab"
-- reg        : I2C address, one of 0x58, 0x59.
-
-Example:
-	dps650ab@58 {
-		    compatible = "delta,dps650ab";
-		    reg = <0x58>;
-	};
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 1bbfa98a85d8..b1bad299ec66 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -73,6 +73,8 @@ properties:
           - dallas,ds4510
             # Digital Thermometer and Thermostat
           - dallas,ds75
+            # Delta Electronics DPS-650-AB power supply
+          - delta,dps650ab
           # Delta Electronics DPS920AB 920W 54V Power Supply
           - delta,dps920ab
             # 1/4 Brick DC/DC Regulated Power Module
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 4/6] dt-bindings: hwmon: hih6130: move to trivial devices
  2021-09-20 18:21 [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Krzysztof Kozlowski
  2021-09-20 18:21 ` [PATCH 2/6] dt-bindings: hwmon: lm75: remove gmt,g751 from " Krzysztof Kozlowski
  2021-09-20 18:21 ` [PATCH 3/6] dt-bindings: hwmon: dps650ab: move to " Krzysztof Kozlowski
@ 2021-09-20 18:21 ` Krzysztof Kozlowski
  2021-09-23 21:14   ` Rob Herring
  2021-09-24  2:07   ` Guenter Roeck
  2021-09-20 18:21 ` [PATCH 5/6] dt-bindings: hwmon: jedec,jc42: convert to dtschema Krzysztof Kozlowski
                   ` (3 subsequent siblings)
  6 siblings, 2 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-20 18:21 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Jiri Kosina,
	Jonathan Cameron, Krzysztof Kozlowski, linux-hwmon, devicetree,
	linux-kernel

The hih6130 bindings are trivial, so it can be integrated into trivial
devices bindings.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 Documentation/devicetree/bindings/hwmon/hih6130.txt  | 12 ------------
 .../devicetree/bindings/trivial-devices.yaml         |  2 ++
 2 files changed, 2 insertions(+), 12 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/hih6130.txt

diff --git a/Documentation/devicetree/bindings/hwmon/hih6130.txt b/Documentation/devicetree/bindings/hwmon/hih6130.txt
deleted file mode 100644
index 2c43837af4c2..000000000000
--- a/Documentation/devicetree/bindings/hwmon/hih6130.txt
+++ /dev/null
@@ -1,12 +0,0 @@
-Honeywell Humidicon HIH-6130 humidity/temperature sensor
---------------------------------------------------------
-
-Requires node properties:
-- compatible : "honeywell,hi6130"
-- reg : the I2C address of the device. This is 0x27.
-
-Example:
-	hih6130@27 {
-		compatible = "honeywell,hih6130";
-		reg = <0x27>;
-	};
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index b1bad299ec66..c9333fb81fdf 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -111,6 +111,8 @@ properties:
           - mps,mp2888
             # Monolithic Power Systems Inc. multi-phase controller mp2975
           - mps,mp2975
+            # Honeywell Humidicon HIH-6130 humidity/temperature sensor
+          - honeywell,hi6130
             # Infineon IR36021 digital POL buck controller
           - infineon,ir36021
             # Infineon IR38064 Voltage Regulator
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 5/6] dt-bindings: hwmon: jedec,jc42: convert to dtschema
  2021-09-20 18:21 [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2021-09-20 18:21 ` [PATCH 4/6] dt-bindings: hwmon: hih6130: " Krzysztof Kozlowski
@ 2021-09-20 18:21 ` Krzysztof Kozlowski
  2021-09-23 21:15   ` Rob Herring
  2021-09-24  2:08   ` Guenter Roeck
  2021-09-20 18:21 ` [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  6 siblings, 2 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-20 18:21 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Jiri Kosina,
	Jonathan Cameron, Krzysztof Kozlowski, linux-hwmon, devicetree,
	linux-kernel

Convert the Jedec JC-42.4 temperature sensor bindings to DT schema
format.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .../devicetree/bindings/hwmon/jc42.txt        | 46 -------------
 .../devicetree/bindings/hwmon/jedec,jc42.yaml | 69 +++++++++++++++++++
 MAINTAINERS                                   |  1 +
 3 files changed, 70 insertions(+), 46 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/jc42.txt
 create mode 100644 Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/jc42.txt b/Documentation/devicetree/bindings/hwmon/jc42.txt
deleted file mode 100644
index f569db58f64a..000000000000
--- a/Documentation/devicetree/bindings/hwmon/jc42.txt
+++ /dev/null
@@ -1,46 +0,0 @@
-Properties for Jedec JC-42.4 compatible temperature sensors
-
-Required properties:
-- compatible: May include a device-specific string consisting of the
-	      manufacturer and the name of the chip. A list of supported
-	      chip names follows.
-	      Must include "jedec,jc-42.4-temp" for any Jedec JC-42.4
-	      compatible temperature sensor.
-
-	      Supported chip names:
-		adi,adt7408
-		atmel,at30ts00
-		atmel,at30tse004
-		onnn,cat6095
-		onnn,cat34ts02
-		maxim,max6604
-		microchip,mcp9804
-		microchip,mcp9805
-		microchip,mcp9808
-		microchip,mcp98243
-		microchip,mcp98244
-		microchip,mcp9843
-		nxp,se97
-		nxp,se98
-		st,stts2002
-		st,stts2004
-		st,stts3000
-		st,stts424
-		st,stts424e
-		idt,tse2002
-		idt,tse2004
-		idt,ts3000
-		idt,ts3001
-
-- reg: I2C address
-
-Optional properties:
-- smbus-timeout-disable: When set, the smbus timeout function will be disabled.
-			 This is not supported on all chips.
-
-Example:
-
-temp-sensor@1a {
-	compatible = "jedec,jc-42.4-temp";
-	reg = <0x1a>;
-};
diff --git a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
new file mode 100644
index 000000000000..a7bb4e3a1c46
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
@@ -0,0 +1,69 @@
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/jedec,jc42.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Jedec JC-42.4 compatible temperature sensors
+
+maintainers:
+  - Jean Delvare <jdelvare@suse.com>
+  - Guenter Roeck <linux@roeck-us.net>
+
+properties:
+  compatible:
+    oneOf:
+      - const: jedec,jc-42.4-temp
+      - items:
+          - enum:
+              - adi,adt7408
+              - atmel,at30ts00
+              - atmel,at30tse004
+              - idt,tse2002
+              - idt,tse2004
+              - idt,ts3000
+              - idt,ts3001
+              - maxim,max6604
+              - microchip,mcp9804
+              - microchip,mcp9805
+              - microchip,mcp9808
+              - microchip,mcp98243
+              - microchip,mcp98244
+              - microchip,mcp9843
+              - nxp,se97
+              - nxp,se98
+              - onnn,cat6095
+              - onnn,cat34ts02
+              - st,stts2002
+              - st,stts2004
+              - st,stts3000
+              - st,stts424
+              - st,stts424e
+          - const: jedec,jc-42.4-temp
+
+  reg:
+    maxItems: 1
+
+  smbus-timeout-disable:
+    description: |
+      When set, the smbus timeout function will be disabled. This is not
+      supported on all chips.
+    type: boolean
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        temp-sensor@1a {
+            compatible = "jedec,jc-42.4-temp";
+            reg = <0x1a>;
+        };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index b07679009af2..15c4d3c809e8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10033,6 +10033,7 @@ JC42.4 TEMPERATURE SENSOR DRIVER
 M:	Guenter Roeck <linux@roeck-us.net>
 L:	linux-hwmon@vger.kernel.org
 S:	Maintained
+F:	Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
 F:	Documentation/hwmon/jc42.rst
 F:	drivers/hwmon/jc42.c
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b
  2021-09-20 18:21 [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Krzysztof Kozlowski
                   ` (3 preceding siblings ...)
  2021-09-20 18:21 ` [PATCH 5/6] dt-bindings: hwmon: jedec,jc42: convert to dtschema Krzysztof Kozlowski
@ 2021-09-20 18:21 ` Krzysztof Kozlowski
  2021-09-23 21:16   ` Rob Herring
  2021-10-08 21:06   ` Guenter Roeck
  2021-09-23 21:13 ` [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Rob Herring
  2021-09-24  1:51 ` Guenter Roeck
  6 siblings, 2 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-20 18:21 UTC (permalink / raw)
  To: Jean Delvare, Guenter Roeck, Rob Herring, Jiri Kosina,
	Jonathan Cameron, Krzysztof Kozlowski, linux-hwmon, devicetree,
	linux-kernel

Document bindings for NXP SE97B, a DDR memory module temperature sensor
with integrated SPD and EEPROM via Atmel's AT24 interface.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
index a7bb4e3a1c46..0e49b3901161 100644
--- a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
+++ b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
@@ -10,6 +10,14 @@ maintainers:
   - Jean Delvare <jdelvare@suse.com>
   - Guenter Roeck <linux@roeck-us.net>
 
+select:
+  properties:
+    compatible:
+      const: jedec,jc-42.4-temp
+
+  required:
+    - compatible
+
 properties:
   compatible:
     oneOf:
@@ -31,6 +39,7 @@ properties:
               - microchip,mcp98244
               - microchip,mcp9843
               - nxp,se97
+              - nxp,se97b
               - nxp,se98
               - onnn,cat6095
               - onnn,cat34ts02
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices
  2021-09-20 18:21 [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Krzysztof Kozlowski
                   ` (4 preceding siblings ...)
  2021-09-20 18:21 ` [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b Krzysztof Kozlowski
@ 2021-09-23 21:13 ` Rob Herring
  2021-09-24  1:51 ` Guenter Roeck
  6 siblings, 0 replies; 23+ messages in thread
From: Rob Herring @ 2021-09-23 21:13 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jonathan Cameron, Jiri Kosina, linux-hwmon, Rob Herring,
	Jean Delvare, devicetree, linux-kernel, Guenter Roeck

On Mon, 20 Sep 2021 20:21:09 +0200, Krzysztof Kozlowski wrote:
> The lm70 thermometer bindings are trivial, so like many other I2C/SPI
> temperature sensors can be integrated into trivial devices bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../devicetree/bindings/hwmon/lm70.txt        | 22 -------------------
>  .../devicetree/bindings/trivial-devices.yaml  |  8 +++++++
>  2 files changed, 8 insertions(+), 22 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/lm70.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/6] dt-bindings: hwmon: lm75: remove gmt,g751 from trivial devices
  2021-09-20 18:21 ` [PATCH 2/6] dt-bindings: hwmon: lm75: remove gmt,g751 from " Krzysztof Kozlowski
@ 2021-09-23 21:13   ` Rob Herring
  2021-09-24  2:05   ` Guenter Roeck
  1 sibling, 0 replies; 23+ messages in thread
From: Rob Herring @ 2021-09-23 21:13 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jiri Kosina, linux-kernel, Rob Herring, Jonathan Cameron,
	Jean Delvare, Guenter Roeck, linux-hwmon, devicetree

On Mon, 20 Sep 2021 20:21:10 +0200, Krzysztof Kozlowski wrote:
> gmt,g751 is covered by LM75 sensor bindings.  This fixes warning:
> 
>   arch/arm/boot/dts/gemini-dlink-dns-313.dt.yaml: temperature-sensor@48:
>     '#thermal-sensor-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
>  1 file changed, 2 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 3/6] dt-bindings: hwmon: dps650ab: move to trivial devices
  2021-09-20 18:21 ` [PATCH 3/6] dt-bindings: hwmon: dps650ab: move to " Krzysztof Kozlowski
@ 2021-09-23 21:14   ` Rob Herring
  2021-09-24  2:06   ` Guenter Roeck
  1 sibling, 0 replies; 23+ messages in thread
From: Rob Herring @ 2021-09-23 21:14 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jiri Kosina, Jean Delvare, linux-kernel, Jonathan Cameron,
	Rob Herring, Guenter Roeck, devicetree, linux-hwmon

On Mon, 20 Sep 2021 20:21:11 +0200, Krzysztof Kozlowski wrote:
> The dps650ab bindings are trivial, so it can be integrated into trivial
> devices bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  Documentation/devicetree/bindings/hwmon/dps650ab.txt  | 11 -----------
>  .../devicetree/bindings/trivial-devices.yaml          |  2 ++
>  2 files changed, 2 insertions(+), 11 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/dps650ab.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 4/6] dt-bindings: hwmon: hih6130: move to trivial devices
  2021-09-20 18:21 ` [PATCH 4/6] dt-bindings: hwmon: hih6130: " Krzysztof Kozlowski
@ 2021-09-23 21:14   ` Rob Herring
  2021-09-24  2:07   ` Guenter Roeck
  1 sibling, 0 replies; 23+ messages in thread
From: Rob Herring @ 2021-09-23 21:14 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: linux-kernel, Jean Delvare, Guenter Roeck, linux-hwmon,
	devicetree, Rob Herring, Jonathan Cameron, Jiri Kosina

On Mon, 20 Sep 2021 20:21:12 +0200, Krzysztof Kozlowski wrote:
> The hih6130 bindings are trivial, so it can be integrated into trivial
> devices bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  Documentation/devicetree/bindings/hwmon/hih6130.txt  | 12 ------------
>  .../devicetree/bindings/trivial-devices.yaml         |  2 ++
>  2 files changed, 2 insertions(+), 12 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/hih6130.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/6] dt-bindings: hwmon: jedec,jc42: convert to dtschema
  2021-09-20 18:21 ` [PATCH 5/6] dt-bindings: hwmon: jedec,jc42: convert to dtschema Krzysztof Kozlowski
@ 2021-09-23 21:15   ` Rob Herring
  2021-09-24  2:08   ` Guenter Roeck
  1 sibling, 0 replies; 23+ messages in thread
From: Rob Herring @ 2021-09-23 21:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, linux-kernel, Jiri Kosina, Jean Delvare,
	Guenter Roeck, devicetree, linux-hwmon, Jonathan Cameron

On Mon, 20 Sep 2021 20:21:13 +0200, Krzysztof Kozlowski wrote:
> Convert the Jedec JC-42.4 temperature sensor bindings to DT schema
> format.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../devicetree/bindings/hwmon/jc42.txt        | 46 -------------
>  .../devicetree/bindings/hwmon/jedec,jc42.yaml | 69 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  3 files changed, 70 insertions(+), 46 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/jc42.txt
>  create mode 100644 Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b
  2021-09-20 18:21 ` [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b Krzysztof Kozlowski
@ 2021-09-23 21:16   ` Rob Herring
  2021-09-24  6:57     ` Krzysztof Kozlowski
  2021-10-08 21:06   ` Guenter Roeck
  1 sibling, 1 reply; 23+ messages in thread
From: Rob Herring @ 2021-09-23 21:16 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jean Delvare, Guenter Roeck, Jiri Kosina, Jonathan Cameron,
	linux-hwmon, devicetree, linux-kernel

On Mon, Sep 20, 2021 at 08:21:14PM +0200, Krzysztof Kozlowski wrote:
> Document bindings for NXP SE97B, a DDR memory module temperature sensor
> with integrated SPD and EEPROM via Atmel's AT24 interface.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> index a7bb4e3a1c46..0e49b3901161 100644
> --- a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> @@ -10,6 +10,14 @@ maintainers:
>    - Jean Delvare <jdelvare@suse.com>
>    - Guenter Roeck <linux@roeck-us.net>
>  
> +select:
> +  properties:
> +    compatible:
> +      const: jedec,jc-42.4-temp
> +
> +  required:
> +    - compatible
> +

Is this supposed to be in the last patch? And why is it needed?

>  properties:
>    compatible:
>      oneOf:
> @@ -31,6 +39,7 @@ properties:
>                - microchip,mcp98244
>                - microchip,mcp9843
>                - nxp,se97
> +              - nxp,se97b
>                - nxp,se98
>                - onnn,cat6095
>                - onnn,cat34ts02
> -- 
> 2.30.2
> 
> 

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices
  2021-09-20 18:21 [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Krzysztof Kozlowski
                   ` (5 preceding siblings ...)
  2021-09-23 21:13 ` [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Rob Herring
@ 2021-09-24  1:51 ` Guenter Roeck
  6 siblings, 0 replies; 23+ messages in thread
From: Guenter Roeck @ 2021-09-24  1:51 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jean Delvare, Rob Herring, Jiri Kosina, Jonathan Cameron,
	linux-hwmon, devicetree, linux-kernel

On Mon, Sep 20, 2021 at 08:21:09PM +0200, Krzysztof Kozlowski wrote:
> The lm70 thermometer bindings are trivial, so like many other I2C/SPI
> temperature sensors can be integrated into trivial devices bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied, per Rob's comment that he prefers devices as .yaml
over .txt, and would rather have a transition from device.txt ->
trivial.yaml -> device.yaml than no transition at all.

Guenter

> ---
>  .../devicetree/bindings/hwmon/lm70.txt        | 22 -------------------
>  .../devicetree/bindings/trivial-devices.yaml  |  8 +++++++
>  2 files changed, 8 insertions(+), 22 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/lm70.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/lm70.txt b/Documentation/devicetree/bindings/hwmon/lm70.txt
> deleted file mode 100644
> index ea417a0d32af..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/lm70.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -* LM70/TMP121/LM71/LM74 thermometer.
> -
> -Required properties:
> -- compatible: one of
> -		"ti,lm70"
> -		"ti,tmp121"
> -		"ti,tmp122"
> -		"ti,lm71"
> -		"ti,lm74"
> -
> -See Documentation/devicetree/bindings/spi/spi-bus.txt for more required and
> -optional properties.
> -
> -Example:
> -
> -spi_master {
> -	temperature-sensor@0 {
> -		compatible = "ti,lm70";
> -		reg = <0>;
> -		spi-max-frequency = <1000000>;
> -	};
> -};
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 1eb4ce7dcdfd..183ee0da22c6 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -303,8 +303,13 @@ properties:
>            - ti,hdc1050
>              # Temperature and humidity sensor with i2c interface
>            - ti,hdc1080
> +            # Thermometer with SPI interface
> +          - ti,lm70
> +          - ti,lm71
>              # Temperature sensor with 2-wire interface
>            - ti,lm73
> +            # Thermometer with SPI interface
> +          - ti,lm74
>              # Temperature sensor with integrated fan control
>            - ti,lm96000
>              # I2C Touch-Screen Controller
> @@ -313,6 +318,9 @@ properties:
>            - ti,tmp102
>              # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
>            - ti,tmp103
> +            # Thermometer with SPI interface
> +          - ti,tmp121
> +          - ti,tmp122
>              # Digital Temperature Sensor
>            - ti,tmp275
>              # TI Dual channel DCAP+ multiphase controller TPS53676 with AVSBus

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 2/6] dt-bindings: hwmon: lm75: remove gmt,g751 from trivial devices
  2021-09-20 18:21 ` [PATCH 2/6] dt-bindings: hwmon: lm75: remove gmt,g751 from " Krzysztof Kozlowski
  2021-09-23 21:13   ` Rob Herring
@ 2021-09-24  2:05   ` Guenter Roeck
  1 sibling, 0 replies; 23+ messages in thread
From: Guenter Roeck @ 2021-09-24  2:05 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jean Delvare, Rob Herring, Jiri Kosina, Jonathan Cameron,
	linux-hwmon, devicetree, linux-kernel

On Mon, Sep 20, 2021 at 08:21:10PM +0200, Krzysztof Kozlowski wrote:
> gmt,g751 is covered by LM75 sensor bindings.  This fixes warning:
> 
>   arch/arm/boot/dts/gemini-dlink-dns-313.dt.yaml: temperature-sensor@48:
>     '#thermal-sensor-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter

> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 183ee0da22c6..1bbfa98a85d8 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -109,8 +109,6 @@ properties:
>            - mps,mp2888
>              # Monolithic Power Systems Inc. multi-phase controller mp2975
>            - mps,mp2975
> -            # G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire Interface
> -          - gmt,g751
>              # Infineon IR36021 digital POL buck controller
>            - infineon,ir36021
>              # Infineon IR38064 Voltage Regulator

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 3/6] dt-bindings: hwmon: dps650ab: move to trivial devices
  2021-09-20 18:21 ` [PATCH 3/6] dt-bindings: hwmon: dps650ab: move to " Krzysztof Kozlowski
  2021-09-23 21:14   ` Rob Herring
@ 2021-09-24  2:06   ` Guenter Roeck
  1 sibling, 0 replies; 23+ messages in thread
From: Guenter Roeck @ 2021-09-24  2:06 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jean Delvare, Rob Herring, Jiri Kosina, Jonathan Cameron,
	linux-hwmon, devicetree, linux-kernel

On Mon, Sep 20, 2021 at 08:21:11PM +0200, Krzysztof Kozlowski wrote:
> The dps650ab bindings are trivial, so it can be integrated into trivial
> devices bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied, per Rob's comments and because it is somewhat unlikely that this
device will need special properties.

Guenter

> ---
>  Documentation/devicetree/bindings/hwmon/dps650ab.txt  | 11 -----------
>  .../devicetree/bindings/trivial-devices.yaml          |  2 ++
>  2 files changed, 2 insertions(+), 11 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/dps650ab.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/dps650ab.txt b/Documentation/devicetree/bindings/hwmon/dps650ab.txt
> deleted file mode 100644
> index 76780e795899..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/dps650ab.txt
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -Bindings for Delta Electronics DPS-650-AB power supply
> -
> -Required properties:
> -- compatible : "delta,dps650ab"
> -- reg        : I2C address, one of 0x58, 0x59.
> -
> -Example:
> -	dps650ab@58 {
> -		    compatible = "delta,dps650ab";
> -		    reg = <0x58>;
> -	};
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 1bbfa98a85d8..b1bad299ec66 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -73,6 +73,8 @@ properties:
>            - dallas,ds4510
>              # Digital Thermometer and Thermostat
>            - dallas,ds75
> +            # Delta Electronics DPS-650-AB power supply
> +          - delta,dps650ab
>            # Delta Electronics DPS920AB 920W 54V Power Supply
>            - delta,dps920ab
>              # 1/4 Brick DC/DC Regulated Power Module

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 4/6] dt-bindings: hwmon: hih6130: move to trivial devices
  2021-09-20 18:21 ` [PATCH 4/6] dt-bindings: hwmon: hih6130: " Krzysztof Kozlowski
  2021-09-23 21:14   ` Rob Herring
@ 2021-09-24  2:07   ` Guenter Roeck
  1 sibling, 0 replies; 23+ messages in thread
From: Guenter Roeck @ 2021-09-24  2:07 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jean Delvare, Rob Herring, Jiri Kosina, Jonathan Cameron,
	linux-hwmon, devicetree, linux-kernel

On Mon, Sep 20, 2021 at 08:21:12PM +0200, Krzysztof Kozlowski wrote:
> The hih6130 bindings are trivial, so it can be integrated into trivial
> devices bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied, per Rob's feedback (.txt -> .yaml conversion).

Thanks,
Guenter

> ---
>  Documentation/devicetree/bindings/hwmon/hih6130.txt  | 12 ------------
>  .../devicetree/bindings/trivial-devices.yaml         |  2 ++
>  2 files changed, 2 insertions(+), 12 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/hih6130.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/hih6130.txt b/Documentation/devicetree/bindings/hwmon/hih6130.txt
> deleted file mode 100644
> index 2c43837af4c2..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/hih6130.txt
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -Honeywell Humidicon HIH-6130 humidity/temperature sensor
> ---------------------------------------------------------
> -
> -Requires node properties:
> -- compatible : "honeywell,hi6130"
> -- reg : the I2C address of the device. This is 0x27.
> -
> -Example:
> -	hih6130@27 {
> -		compatible = "honeywell,hih6130";
> -		reg = <0x27>;
> -	};
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index b1bad299ec66..c9333fb81fdf 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -111,6 +111,8 @@ properties:
>            - mps,mp2888
>              # Monolithic Power Systems Inc. multi-phase controller mp2975
>            - mps,mp2975
> +            # Honeywell Humidicon HIH-6130 humidity/temperature sensor
> +          - honeywell,hi6130
>              # Infineon IR36021 digital POL buck controller
>            - infineon,ir36021
>              # Infineon IR38064 Voltage Regulator

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 5/6] dt-bindings: hwmon: jedec,jc42: convert to dtschema
  2021-09-20 18:21 ` [PATCH 5/6] dt-bindings: hwmon: jedec,jc42: convert to dtschema Krzysztof Kozlowski
  2021-09-23 21:15   ` Rob Herring
@ 2021-09-24  2:08   ` Guenter Roeck
  1 sibling, 0 replies; 23+ messages in thread
From: Guenter Roeck @ 2021-09-24  2:08 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jean Delvare, Rob Herring, Jiri Kosina, Jonathan Cameron,
	linux-hwmon, devicetree, linux-kernel

On Mon, Sep 20, 2021 at 08:21:13PM +0200, Krzysztof Kozlowski wrote:
> Convert the Jedec JC-42.4 temperature sensor bindings to DT schema
> format.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/jc42.txt        | 46 -------------
>  .../devicetree/bindings/hwmon/jedec,jc42.yaml | 69 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  3 files changed, 70 insertions(+), 46 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/jc42.txt
>  create mode 100644 Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/jc42.txt b/Documentation/devicetree/bindings/hwmon/jc42.txt
> deleted file mode 100644
> index f569db58f64a..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/jc42.txt
> +++ /dev/null
> @@ -1,46 +0,0 @@
> -Properties for Jedec JC-42.4 compatible temperature sensors
> -
> -Required properties:
> -- compatible: May include a device-specific string consisting of the
> -	      manufacturer and the name of the chip. A list of supported
> -	      chip names follows.
> -	      Must include "jedec,jc-42.4-temp" for any Jedec JC-42.4
> -	      compatible temperature sensor.
> -
> -	      Supported chip names:
> -		adi,adt7408
> -		atmel,at30ts00
> -		atmel,at30tse004
> -		onnn,cat6095
> -		onnn,cat34ts02
> -		maxim,max6604
> -		microchip,mcp9804
> -		microchip,mcp9805
> -		microchip,mcp9808
> -		microchip,mcp98243
> -		microchip,mcp98244
> -		microchip,mcp9843
> -		nxp,se97
> -		nxp,se98
> -		st,stts2002
> -		st,stts2004
> -		st,stts3000
> -		st,stts424
> -		st,stts424e
> -		idt,tse2002
> -		idt,tse2004
> -		idt,ts3000
> -		idt,ts3001
> -
> -- reg: I2C address
> -
> -Optional properties:
> -- smbus-timeout-disable: When set, the smbus timeout function will be disabled.
> -			 This is not supported on all chips.
> -
> -Example:
> -
> -temp-sensor@1a {
> -	compatible = "jedec,jc-42.4-temp";
> -	reg = <0x1a>;
> -};
> diff --git a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> new file mode 100644
> index 000000000000..a7bb4e3a1c46
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/jedec,jc42.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Jedec JC-42.4 compatible temperature sensors
> +
> +maintainers:
> +  - Jean Delvare <jdelvare@suse.com>
> +  - Guenter Roeck <linux@roeck-us.net>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: jedec,jc-42.4-temp
> +      - items:
> +          - enum:
> +              - adi,adt7408
> +              - atmel,at30ts00
> +              - atmel,at30tse004
> +              - idt,tse2002
> +              - idt,tse2004
> +              - idt,ts3000
> +              - idt,ts3001
> +              - maxim,max6604
> +              - microchip,mcp9804
> +              - microchip,mcp9805
> +              - microchip,mcp9808
> +              - microchip,mcp98243
> +              - microchip,mcp98244
> +              - microchip,mcp9843
> +              - nxp,se97
> +              - nxp,se98
> +              - onnn,cat6095
> +              - onnn,cat34ts02
> +              - st,stts2002
> +              - st,stts2004
> +              - st,stts3000
> +              - st,stts424
> +              - st,stts424e
> +          - const: jedec,jc-42.4-temp
> +
> +  reg:
> +    maxItems: 1
> +
> +  smbus-timeout-disable:
> +    description: |
> +      When set, the smbus timeout function will be disabled. This is not
> +      supported on all chips.
> +    type: boolean
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        temp-sensor@1a {
> +            compatible = "jedec,jc-42.4-temp";
> +            reg = <0x1a>;
> +        };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b07679009af2..15c4d3c809e8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10033,6 +10033,7 @@ JC42.4 TEMPERATURE SENSOR DRIVER
>  M:	Guenter Roeck <linux@roeck-us.net>
>  L:	linux-hwmon@vger.kernel.org
>  S:	Maintained
> +F:	Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
>  F:	Documentation/hwmon/jc42.rst
>  F:	drivers/hwmon/jc42.c
>  

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b
  2021-09-23 21:16   ` Rob Herring
@ 2021-09-24  6:57     ` Krzysztof Kozlowski
  2021-09-24 11:51       ` Guenter Roeck
  2021-10-08 18:57       ` Rob Herring
  0 siblings, 2 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-24  6:57 UTC (permalink / raw)
  To: Rob Herring
  Cc: Jean Delvare, Guenter Roeck, Jiri Kosina, Jonathan Cameron,
	linux-hwmon, devicetree, linux-kernel

On 23/09/2021 23:16, Rob Herring wrote:
> On Mon, Sep 20, 2021 at 08:21:14PM +0200, Krzysztof Kozlowski wrote:
>> Document bindings for NXP SE97B, a DDR memory module temperature sensor
>> with integrated SPD and EEPROM via Atmel's AT24 interface.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
>>  Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
>> index a7bb4e3a1c46..0e49b3901161 100644
>> --- a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
>> @@ -10,6 +10,14 @@ maintainers:
>>    - Jean Delvare <jdelvare@suse.com>
>>    - Guenter Roeck <linux@roeck-us.net>
>>  
>> +select:
>> +  properties:
>> +    compatible:
>> +      const: jedec,jc-42.4-temp
>> +
>> +  required:
>> +    - compatible
>> +
> 
> Is this supposed to be in the last patch? And why is it needed?

Yes, this is here on purpose because of nxp,se97b which is sensor with
at24-compatible EEPROM.

arch/arm/boot/dts/at91-nattis-2-natte-2.dts:
169         temp@18 {
170                 compatible = "nxp,se97b", "jedec,jc-42.4-temp";

171                 reg = <0x18>;
172                 smbus-timeout-disable;
173         };
174
175         eeprom@50 {
176                 compatible = "nxp,se97b", "atmel,24c02";
177                 reg = <0x50>;
178                 pagesize = <16>;

Without the select, dtbs_check was complaining about the second node:

eeprom@50: compatible: 'oneOf' conditional failed, one must be fixed:
	['nxp,se97b', 'atmel,24c02'] is too long
	Additional items are not allowed ('atmel,24c02' was unexpected)
	'jedec,jc-42.4-temp' was expected
	From schema:
/home/dev/linux/linux/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml

eeprom@50: 'pagesize' does not match any of the regexes: 'pinctrl-[0-9]+'
	From schema:
/home/dev/linux/linux/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml


>>  properties:
>>    compatible:
>>      oneOf:
>> @@ -31,6 +39,7 @@ properties:
>>                - microchip,mcp98244
>>                - microchip,mcp9843
>>                - nxp,se97
>> +              - nxp,se97b
>>                - nxp,se98
>>                - onnn,cat6095
>>                - onnn,cat34ts02
>> -- 
>> 2.30.2
>>
>>


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b
  2021-09-24  6:57     ` Krzysztof Kozlowski
@ 2021-09-24 11:51       ` Guenter Roeck
  2021-10-08  8:00         ` Krzysztof Kozlowski
  2021-10-08 18:57       ` Rob Herring
  1 sibling, 1 reply; 23+ messages in thread
From: Guenter Roeck @ 2021-09-24 11:51 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Jean Delvare, Jiri Kosina, Jonathan Cameron,
	linux-hwmon, devicetree, linux-kernel

On Fri, Sep 24, 2021 at 08:57:44AM +0200, Krzysztof Kozlowski wrote:
> On 23/09/2021 23:16, Rob Herring wrote:
> > On Mon, Sep 20, 2021 at 08:21:14PM +0200, Krzysztof Kozlowski wrote:
> >> Document bindings for NXP SE97B, a DDR memory module temperature sensor
> >> with integrated SPD and EEPROM via Atmel's AT24 interface.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >> ---
> >>  Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml | 9 +++++++++
> >>  1 file changed, 9 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> >> index a7bb4e3a1c46..0e49b3901161 100644
> >> --- a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> >> +++ b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> >> @@ -10,6 +10,14 @@ maintainers:
> >>    - Jean Delvare <jdelvare@suse.com>
> >>    - Guenter Roeck <linux@roeck-us.net>
> >>  
> >> +select:
> >> +  properties:
> >> +    compatible:
> >> +      const: jedec,jc-42.4-temp
> >> +
> >> +  required:
> >> +    - compatible
> >> +
> > 
> > Is this supposed to be in the last patch? And why is it needed?
> 
> Yes, this is here on purpose because of nxp,se97b which is sensor with
> at24-compatible EEPROM.
> 
> arch/arm/boot/dts/at91-nattis-2-natte-2.dts:
> 169         temp@18 {
> 170                 compatible = "nxp,se97b", "jedec,jc-42.4-temp";
> 
> 171                 reg = <0x18>;
> 172                 smbus-timeout-disable;
> 173         };
> 174
> 175         eeprom@50 {
> 176                 compatible = "nxp,se97b", "atmel,24c02";

How would that be handled anyway ? Yes, the chip includes both a temperature
sensor and an eeprom, but this node should most definitely not instantiate as
temperature sensor.

Guenter

> 177                 reg = <0x50>;
> 178                 pagesize = <16>;
> 
> Without the select, dtbs_check was complaining about the second node:
> 
> eeprom@50: compatible: 'oneOf' conditional failed, one must be fixed:
> 	['nxp,se97b', 'atmel,24c02'] is too long
> 	Additional items are not allowed ('atmel,24c02' was unexpected)
> 	'jedec,jc-42.4-temp' was expected
> 	From schema:
> /home/dev/linux/linux/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> 
> eeprom@50: 'pagesize' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	From schema:
> /home/dev/linux/linux/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> 
> 
> >>  properties:
> >>    compatible:
> >>      oneOf:
> >> @@ -31,6 +39,7 @@ properties:
> >>                - microchip,mcp98244
> >>                - microchip,mcp9843
> >>                - nxp,se97
> >> +              - nxp,se97b
> >>                - nxp,se98
> >>                - onnn,cat6095
> >>                - onnn,cat34ts02
> >> -- 
> >> 2.30.2
> >>
> >>
> 
> 
> Best regards,
> Krzysztof

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b
  2021-09-24 11:51       ` Guenter Roeck
@ 2021-10-08  8:00         ` Krzysztof Kozlowski
  2021-10-08 15:15           ` Guenter Roeck
  0 siblings, 1 reply; 23+ messages in thread
From: Krzysztof Kozlowski @ 2021-10-08  8:00 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Rob Herring, Jean Delvare, Jiri Kosina, Jonathan Cameron,
	linux-hwmon, devicetree, linux-kernel

On 24/09/2021 13:51, Guenter Roeck wrote:
> On Fri, Sep 24, 2021 at 08:57:44AM +0200, Krzysztof Kozlowski wrote:
>> On 23/09/2021 23:16, Rob Herring wrote:
>>> On Mon, Sep 20, 2021 at 08:21:14PM +0200, Krzysztof Kozlowski wrote:
>>>> Document bindings for NXP SE97B, a DDR memory module temperature sensor
>>>> with integrated SPD and EEPROM via Atmel's AT24 interface.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>>> ---
>>>>  Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml | 9 +++++++++
>>>>  1 file changed, 9 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
>>>> index a7bb4e3a1c46..0e49b3901161 100644
>>>> --- a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
>>>> +++ b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
>>>> @@ -10,6 +10,14 @@ maintainers:
>>>>    - Jean Delvare <jdelvare@suse.com>
>>>>    - Guenter Roeck <linux@roeck-us.net>
>>>>  
>>>> +select:
>>>> +  properties:
>>>> +    compatible:
>>>> +      const: jedec,jc-42.4-temp
>>>> +
>>>> +  required:
>>>> +    - compatible
>>>> +
>>>
>>> Is this supposed to be in the last patch? And why is it needed?
>>
>> Yes, this is here on purpose because of nxp,se97b which is sensor with
>> at24-compatible EEPROM.
>>
>> arch/arm/boot/dts/at91-nattis-2-natte-2.dts:
>> 169         temp@18 {
>> 170                 compatible = "nxp,se97b", "jedec,jc-42.4-temp";
>>
>> 171                 reg = <0x18>;
>> 172                 smbus-timeout-disable;
>> 173         };
>> 174
>> 175         eeprom@50 {
>> 176                 compatible = "nxp,se97b", "atmel,24c02";
> 
> How would that be handled anyway ? Yes, the chip includes both a temperature
> sensor and an eeprom, but this node should most definitely not instantiate as
> temperature sensor.
> 

I am not sure if I understand the problem you are mentioning. You have
two nods in DT, two different compatible sets and two difference
devices. One eeprom and other one a temperature sensor.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b
  2021-10-08  8:00         ` Krzysztof Kozlowski
@ 2021-10-08 15:15           ` Guenter Roeck
  0 siblings, 0 replies; 23+ messages in thread
From: Guenter Roeck @ 2021-10-08 15:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Rob Herring, Jean Delvare, Jiri Kosina, Jonathan Cameron,
	linux-hwmon, devicetree, linux-kernel

On 10/8/21 1:00 AM, Krzysztof Kozlowski wrote:
> On 24/09/2021 13:51, Guenter Roeck wrote:
>> On Fri, Sep 24, 2021 at 08:57:44AM +0200, Krzysztof Kozlowski wrote:
>>> On 23/09/2021 23:16, Rob Herring wrote:
>>>> On Mon, Sep 20, 2021 at 08:21:14PM +0200, Krzysztof Kozlowski wrote:
>>>>> Document bindings for NXP SE97B, a DDR memory module temperature sensor
>>>>> with integrated SPD and EEPROM via Atmel's AT24 interface.
>>>>>
>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>>>> ---
>>>>>   Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml | 9 +++++++++
>>>>>   1 file changed, 9 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
>>>>> index a7bb4e3a1c46..0e49b3901161 100644
>>>>> --- a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
>>>>> +++ b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
>>>>> @@ -10,6 +10,14 @@ maintainers:
>>>>>     - Jean Delvare <jdelvare@suse.com>
>>>>>     - Guenter Roeck <linux@roeck-us.net>
>>>>>   
>>>>> +select:
>>>>> +  properties:
>>>>> +    compatible:
>>>>> +      const: jedec,jc-42.4-temp
>>>>> +
>>>>> +  required:
>>>>> +    - compatible
>>>>> +
>>>>
>>>> Is this supposed to be in the last patch? And why is it needed?
>>>
>>> Yes, this is here on purpose because of nxp,se97b which is sensor with
>>> at24-compatible EEPROM.
>>>
>>> arch/arm/boot/dts/at91-nattis-2-natte-2.dts:
>>> 169         temp@18 {
>>> 170                 compatible = "nxp,se97b", "jedec,jc-42.4-temp";
>>>
>>> 171                 reg = <0x18>;
>>> 172                 smbus-timeout-disable;
>>> 173         };
>>> 174
>>> 175         eeprom@50 {
>>> 176                 compatible = "nxp,se97b", "atmel,24c02";
>>
>> How would that be handled anyway ? Yes, the chip includes both a temperature
>> sensor and an eeprom, but this node should most definitely not instantiate as
>> temperature sensor.
>>
> 
> I am not sure if I understand the problem you are mentioning. You have
> two nods in DT, two different compatible sets and two difference
> devices. One eeprom and other one a temperature sensor.
> 

I didn't realize that the driver is supposed to bind to "jedec,jc-42.4-temp"
and that "nxp,se97b" is really informational.

Sorry for the confusion.

Guenter

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b
  2021-09-24  6:57     ` Krzysztof Kozlowski
  2021-09-24 11:51       ` Guenter Roeck
@ 2021-10-08 18:57       ` Rob Herring
  1 sibling, 0 replies; 23+ messages in thread
From: Rob Herring @ 2021-10-08 18:57 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jean Delvare, Guenter Roeck, Jiri Kosina, Jonathan Cameron,
	Linux HWMON List, devicetree, linux-kernel

On Fri, Sep 24, 2021 at 1:57 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> On 23/09/2021 23:16, Rob Herring wrote:
> > On Mon, Sep 20, 2021 at 08:21:14PM +0200, Krzysztof Kozlowski wrote:
> >> Document bindings for NXP SE97B, a DDR memory module temperature sensor
> >> with integrated SPD and EEPROM via Atmel's AT24 interface.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >> ---
> >>  Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml | 9 +++++++++
> >>  1 file changed, 9 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> >> index a7bb4e3a1c46..0e49b3901161 100644
> >> --- a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> >> +++ b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> >> @@ -10,6 +10,14 @@ maintainers:
> >>    - Jean Delvare <jdelvare@suse.com>
> >>    - Guenter Roeck <linux@roeck-us.net>
> >>
> >> +select:
> >> +  properties:
> >> +    compatible:
> >> +      const: jedec,jc-42.4-temp
> >> +
> >> +  required:
> >> +    - compatible
> >> +
> >
> > Is this supposed to be in the last patch? And why is it needed?
>
> Yes, this is here on purpose because of nxp,se97b which is sensor with
> at24-compatible EEPROM.
>
> arch/arm/boot/dts/at91-nattis-2-natte-2.dts:
> 169         temp@18 {
> 170                 compatible = "nxp,se97b", "jedec,jc-42.4-temp";
>
> 171                 reg = <0x18>;
> 172                 smbus-timeout-disable;
> 173         };
> 174
> 175         eeprom@50 {
> 176                 compatible = "nxp,se97b", "atmel,24c02";
> 177                 reg = <0x50>;
> 178                 pagesize = <16>;
>
> Without the select, dtbs_check was complaining about the second node:
>
> eeprom@50: compatible: 'oneOf' conditional failed, one must be fixed:
>         ['nxp,se97b', 'atmel,24c02'] is too long
>         Additional items are not allowed ('atmel,24c02' was unexpected)
>         'jedec,jc-42.4-temp' was expected
>         From schema:
> /home/dev/linux/linux/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
>
> eeprom@50: 'pagesize' does not match any of the regexes: 'pinctrl-[0-9]+'
>         From schema:
> /home/dev/linux/linux/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml

If a dt only lists one of the vendor specific compatibles, it is going
to pass as this schema won't be applied with this change. We won't get
an undocumented compatible either because it is documented. I don't
have a better suggestion other than listing everything but
'nxp,se97b'. I don't think it is really worth do that, so:

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b
  2021-09-20 18:21 ` [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b Krzysztof Kozlowski
  2021-09-23 21:16   ` Rob Herring
@ 2021-10-08 21:06   ` Guenter Roeck
  1 sibling, 0 replies; 23+ messages in thread
From: Guenter Roeck @ 2021-10-08 21:06 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Jean Delvare, Rob Herring, Jiri Kosina, Jonathan Cameron,
	linux-hwmon, devicetree, linux-kernel

On Mon, Sep 20, 2021 at 08:21:14PM +0200, Krzysztof Kozlowski wrote:
> Document bindings for NXP SE97B, a DDR memory module temperature sensor
> with integrated SPD and EEPROM via Atmel's AT24 interface.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter

> ---
>  Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> index a7bb4e3a1c46..0e49b3901161 100644
> --- a/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/jedec,jc42.yaml
> @@ -10,6 +10,14 @@ maintainers:
>    - Jean Delvare <jdelvare@suse.com>
>    - Guenter Roeck <linux@roeck-us.net>
>  
> +select:
> +  properties:
> +    compatible:
> +      const: jedec,jc-42.4-temp
> +
> +  required:
> +    - compatible
> +
>  properties:
>    compatible:
>      oneOf:
> @@ -31,6 +39,7 @@ properties:
>                - microchip,mcp98244
>                - microchip,mcp9843
>                - nxp,se97
> +              - nxp,se97b
>                - nxp,se98
>                - onnn,cat6095
>                - onnn,cat34ts02

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2021-10-08 21:06 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-20 18:21 [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Krzysztof Kozlowski
2021-09-20 18:21 ` [PATCH 2/6] dt-bindings: hwmon: lm75: remove gmt,g751 from " Krzysztof Kozlowski
2021-09-23 21:13   ` Rob Herring
2021-09-24  2:05   ` Guenter Roeck
2021-09-20 18:21 ` [PATCH 3/6] dt-bindings: hwmon: dps650ab: move to " Krzysztof Kozlowski
2021-09-23 21:14   ` Rob Herring
2021-09-24  2:06   ` Guenter Roeck
2021-09-20 18:21 ` [PATCH 4/6] dt-bindings: hwmon: hih6130: " Krzysztof Kozlowski
2021-09-23 21:14   ` Rob Herring
2021-09-24  2:07   ` Guenter Roeck
2021-09-20 18:21 ` [PATCH 5/6] dt-bindings: hwmon: jedec,jc42: convert to dtschema Krzysztof Kozlowski
2021-09-23 21:15   ` Rob Herring
2021-09-24  2:08   ` Guenter Roeck
2021-09-20 18:21 ` [PATCH 6/6] dt-bindings: hwmon: jedec,jc42: add nxp,se97b Krzysztof Kozlowski
2021-09-23 21:16   ` Rob Herring
2021-09-24  6:57     ` Krzysztof Kozlowski
2021-09-24 11:51       ` Guenter Roeck
2021-10-08  8:00         ` Krzysztof Kozlowski
2021-10-08 15:15           ` Guenter Roeck
2021-10-08 18:57       ` Rob Herring
2021-10-08 21:06   ` Guenter Roeck
2021-09-23 21:13 ` [PATCH 1/6] dt-bindings: hwmon: lm70: move to trivial devices Rob Herring
2021-09-24  1:51 ` Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.