From: Markus Elfring <Markus.Elfring@web.de>
To: "Longpeng (Mike)" <longpeng2@huawei.com>,
linux-crypto@vger.kernel.org,
virtualization@lists.linux-foundation.org
Cc: Corentin Labbe <clabbe@baylibre.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Gonglei <arei.gonglei@huawei.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [v2 1/2] crypto: virtio: Fix src/dst scatterlist calculation in __virtio_crypto_skcipher_do_req()
Date: Tue, 26 May 2020 10:25:28 +0200 [thread overview]
Message-ID: <b863c03b-18f3-4942-10fd-563ab4cf5b43@web.de> (raw)
In-Reply-To: <e1864c6d-6380-831f-9c2f-85611a78779b@huawei.com>
>> I suggest to move the addition of such input parameter validation
>> to a separate update step.
>>
> Um...The 'src_nents' will be used as a loop condition,
> so validate it here is needed ?
Would you prefer to add such checking as the first update in
another small patch series?
Regards,
Markus
next prev parent reply other threads:[~2020-05-26 8:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 3:19 [PATCH v2 0/2] crypto: virtio: Fix two crash issue Longpeng(Mike)
2020-05-26 3:19 ` Longpeng(Mike)
2020-05-26 3:19 ` [PATCH v2 1/2] crypto: virtio: Fix src/dst scatterlist calculation in __virtio_crypto_skcipher_do_req() Longpeng(Mike)
2020-05-26 3:19 ` Longpeng(Mike)
2020-05-26 7:03 ` Markus Elfring
2020-05-26 7:21 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-05-26 7:21 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-05-26 8:25 ` Markus Elfring [this message]
2020-05-26 14:11 ` Sasha Levin
2020-05-26 14:11 ` Sasha Levin
2020-05-26 14:11 ` Sasha Levin
2020-05-26 3:19 ` [PATCH v2 2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req() Longpeng(Mike)
2020-05-26 3:19 ` Longpeng(Mike)
2020-05-26 7:19 ` Markus Elfring
2020-05-26 7:38 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-05-26 7:38 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-05-26 9:01 ` [v2 " Markus Elfring
2020-05-26 9:24 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-05-26 9:24 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-05-26 9:30 ` Markus Elfring
2020-05-26 10:16 ` Greg KH
2020-05-26 10:16 ` Greg KH
2020-05-26 12:00 ` [PATCH v2 " Gonglei (Arei)
2020-05-26 12:00 ` Gonglei (Arei)
2020-05-26 14:11 ` Sasha Levin
2020-05-26 14:11 ` Sasha Levin
2020-05-31 9:21 ` Michael S. Tsirkin
2020-06-02 3:54 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-06-02 3:54 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2020-05-26 14:11 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b863c03b-18f3-4942-10fd-563ab4cf5b43@web.de \
--to=markus.elfring@web.de \
--cc=arei.gonglei@huawei.com \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=mst@redhat.com \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.