* [PATCH] ubifs: ensure zero err is returned on successful return
@ 2016-12-16 13:32 Colin King
2016-12-16 13:38 ` Richard Weinberger
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-12-16 13:32 UTC (permalink / raw)
To: Richard Weinberger, Artem Bityutskiy, Adrian Hunter, linux-mtd
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
err is no longer being set on a successful return path, causing
a garbage value being returned. Fix this by setting err to zero
for the successful return path.
Found with static analysis by CoverityScan, CID 1389473
Fixes: 7799953b34d18 ("ubifs: Implement encrypt/decrypt for all IO")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/ubifs/journal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
index a459211..b75f1a6 100644
--- a/fs/ubifs/journal.c
+++ b/fs/ubifs/journal.c
@@ -1319,6 +1319,7 @@ static int truncate_data_node(const struct ubifs_info *c, const struct inode *in
dn->compr_type = cpu_to_le16(compr_type);
dn->size = cpu_to_le32(*new_len);
*new_len = UBIFS_DATA_NODE_SZ + out_len;
+ err = 0;
out:
kfree(buf);
return err;
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ubifs: ensure zero err is returned on successful return
2016-12-16 13:32 [PATCH] ubifs: ensure zero err is returned on successful return Colin King
@ 2016-12-16 13:38 ` Richard Weinberger
0 siblings, 0 replies; 2+ messages in thread
From: Richard Weinberger @ 2016-12-16 13:38 UTC (permalink / raw)
To: Colin King, Artem Bityutskiy, Adrian Hunter, linux-mtd; +Cc: linux-kernel
On 16.12.2016 14:32, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> err is no longer being set on a successful return path, causing
> a garbage value being returned. Fix this by setting err to zero
> for the successful return path.
>
> Found with static analysis by CoverityScan, CID 1389473
>
> Fixes: 7799953b34d18 ("ubifs: Implement encrypt/decrypt for all IO")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/ubifs/journal.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
> index a459211..b75f1a6 100644
> --- a/fs/ubifs/journal.c
> +++ b/fs/ubifs/journal.c
> @@ -1319,6 +1319,7 @@ static int truncate_data_node(const struct ubifs_info *c, const struct inode *in
> dn->compr_type = cpu_to_le16(compr_type);
> dn->size = cpu_to_le32(*new_len);
> *new_len = UBIFS_DATA_NODE_SZ + out_len;
> + err = 0;
> out:
> kfree(buf);
> return err;
>
Good catch!
Thanks,
//richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-16 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-16 13:32 [PATCH] ubifs: ensure zero err is returned on successful return Colin King
2016-12-16 13:38 ` Richard Weinberger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.