From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A60FAC4332F for ; Wed, 11 May 2022 16:52:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237199AbiEKQwP (ORCPT ); Wed, 11 May 2022 12:52:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345203AbiEKQwD (ORCPT ); Wed, 11 May 2022 12:52:03 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA2E9DEFE for ; Wed, 11 May 2022 09:51:50 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id y32so4609135lfa.6 for ; Wed, 11 May 2022 09:51:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=DNkekimpIZPrOqKWBuNc12AOJ0kosP8VwwiWI0Gdmgs=; b=XbjPsW2X4c3cWRAmMZeaDnd+4gaQND1dM5AwXYIk2nHeIjR1E8SC+V/2EV15p1tHLp eIHQbe3Tkc4lqfw+p6mGlYK6fHJwAy8QS/F8hyNIRJSNoEC/DZJ7nmL2qXLu/7P3KeZM 7zUJnviG6EUWIqQlz9puheZ0J07I38TUzTI/CzOFl/W+h65zQl9LdUykR4ef1OU7cHfH OC3UDJBhBI0HQzQ77L2DKypCm7bWOuevTFnLYsONb4qai5NDXV4svHVN7QO8I9dCUSks SkBLNFYQHKAVu5vviDrmyjgZJmyKCiWHiopm6Bekr9jAyVQtn+nHH+PuLWOqLZyXTzC2 K1DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=DNkekimpIZPrOqKWBuNc12AOJ0kosP8VwwiWI0Gdmgs=; b=v34e12yd2Hsf4mWMr4p1ReSx+TybwzaMZ188TWjaWMYbLD+qciT9EnRXlLC41bxmsC dvbdHA9X5WeDZjVqAT+uISYxd8CMLJqPusDQaG60tQ8c4jT5iL3p4CCbjWzeYONJYx5g NWLQ62hvGdD1fO5RFJ0kHg3dlioAQXwug90aYXwJuICPphw8Q3V6uBiyooo98Lzt74L8 3i3O9zeFCZ9Py/+u/8I5je4ygk4S/R5qAvHofsMX367dW9by2tEUw9ijAVywZyMfI+sd eZefVQ+0aL3AIm1TjgPB4xBs+ltfl8LqUV4fXdZeW22xNPPLGOY03cVHZ4ds9pbOwP+W nFHQ== X-Gm-Message-State: AOAM5335gxaTIz9jZ6AfPmKysPvumOW4lYz4zyes4cnLaCGF6KWLhJil zgbQGAvQ6f+blIvuT9cgiouRbgIjY9ZmRA== X-Google-Smtp-Source: ABdhPJyLo9G6Tmvo0r462l0cfgtq61tw6rmcLQx9lsfbYrcnKqfnS2XsjvfRAIVGvecfyJ0vfRpAmQ== X-Received: by 2002:a05:6512:3f88:b0:44f:567f:8715 with SMTP id x8-20020a0565123f8800b0044f567f8715mr19977138lfa.609.1652287909157; Wed, 11 May 2022 09:51:49 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id k34-20020a05651c062200b0024f3d1daeb1sm437515lje.57.2022.05.11.09.51.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 09:51:48 -0700 (PDT) Message-ID: Date: Wed, 11 May 2022 19:51:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/9] remoteproc: qcom: pas: Add MSM8953 ADSP PIL support Content-Language: en-GB To: Sireesh Kodali , linux-remoteproc@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , Mathieu Poirier References: <20220511161602.117772-1-sireeshkodali1@gmail.com> <20220511161602.117772-2-sireeshkodali1@gmail.com> From: Dmitry Baryshkov In-Reply-To: <20220511161602.117772-2-sireeshkodali1@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 11/05/2022 19:15, Sireesh Kodali wrote: > Add support for the Audio DSP PIL found on the Qualcomm MSM8953 > platform. The same configuration is used on all SoCs based on the > MSM8953 platform (SDM450, SDA450, SDM625, SDM632, APQ8053). > > Signed-off-by: Sireesh Kodali > --- > drivers/remoteproc/qcom_q6v5_pas.c | 31 ++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c > index 1ae47cc153e5..4dcb714a1468 100644 > --- a/drivers/remoteproc/qcom_q6v5_pas.c > +++ b/drivers/remoteproc/qcom_q6v5_pas.c > @@ -617,7 +617,37 @@ static const struct adsp_data sm8350_adsp_resource = { > .ssctl_id = 0x14, > }; > > +static const struct adsp_data msm8953_adsp_resource = { > + .crash_reason_smem = 423, > + .firmware_name = "adsp.mdt", > + .pas_id = 1, > + .has_aggre2_clk = false, > + .auto_boot = true, > + .proxy_pd_names = (char*[]){ > + "cx", > + NULL, > + }, > + .ssr_name = "lpass", > + .sysmon_name = "adsp", > + .ssctl_id = 0x14, > +}; > + Also it looks like this item is identical to msm8996_adsp_resources. So you can existing structure instead. > static const struct adsp_data msm8996_adsp_resource = { > + .crash_reason_smem = 423, > + .firmware_name = "adsp.mdt", > + .pas_id = 1, > + .has_aggre2_clk = false, > + .auto_boot = true, > + .proxy_pd_names = (char*[]){ > + "cx", > + NULL, > + }, > + .ssr_name = "lpass", > + .sysmon_name = "adsp", > + .ssctl_id = 0x14, > +}; > + > +static const struct adsp_data msm8998_adsp_resource = { > .crash_reason_smem = 423, > .firmware_name = "adsp.mdt", > .pas_id = 1, > @@ -850,6 +880,7 @@ static const struct adsp_data sdx55_mpss_resource = { > static const struct of_device_id adsp_of_match[] = { > { .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init}, > { .compatible = "qcom,msm8996-adsp-pil", .data = &msm8996_adsp_resource}, > + { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8953_adsp_resource}, > { .compatible = "qcom,msm8996-slpi-pil", .data = &slpi_resource_init}, > { .compatible = "qcom,msm8998-adsp-pas", .data = &msm8996_adsp_resource}, > { .compatible = "qcom,msm8998-slpi-pas", .data = &slpi_resource_init}, -- With best wishes Dmitry