From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C84E4C433DB for ; Tue, 2 Mar 2021 08:08:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C2D56146D for ; Tue, 2 Mar 2021 08:08:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C2D56146D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH04a-0000RP-NK for qemu-devel@archiver.kernel.org; Tue, 02 Mar 2021 03:08:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH037-0007eO-Lx for qemu-devel@nongnu.org; Tue, 02 Mar 2021 03:06:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:46450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH035-0004hN-Sy for qemu-devel@nongnu.org; Tue, 02 Mar 2021 03:06:33 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5920EAC24; Tue, 2 Mar 2021 08:06:30 +0000 (UTC) Subject: Re: [RFC v2 06/24] target/arm: split off cpu-sysemu.c To: Richard Henderson References: <20210301164936.19446-1-cfontana@suse.de> <20210301164936.19446-7-cfontana@suse.de> <4b776b96-7d5c-da73-9372-2b657a43f4e7@linaro.org> From: Claudio Fontana Message-ID: Date: Tue, 2 Mar 2021 09:06:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <4b776b96-7d5c-da73-9372-2b657a43f4e7@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/2/21 7:17 AM, Richard Henderson wrote: > On 3/1/21 8:49 AM, Claudio Fontana wrote: >> Signed-off-by: Claudio Fontana >> --- >> target/arm/internals.h | 8 ++- >> target/arm/cpu-sysemu.c | 105 ++++++++++++++++++++++++++++++++++++++++ >> target/arm/cpu.c | 83 ------------------------------- >> target/arm/meson.build | 1 + >> 4 files changed, 113 insertions(+), 84 deletions(-) >> create mode 100644 target/arm/cpu-sysemu.c > > It'd be nice to rearrange this into tcg/ and kvm/. Yes. This would be the objective of the next series, basically the objective of this series is to make the kvm-only build succeed after moving helpers to tcg/ and picking stuff we need from helper.c . configure --enable-kvm --disable-tcg The objective of the next one would be to properly place the code in kvm-only and tcg-only sections, and then add the classes that specialize the cpu, just like for i386. But I can continue this series as a whole if preferrable. > > I think we could do with some macros like > > #ifndef CONFIG_KVM > #define KVM_ERROR QEMU_ERROR("kvm is disabled") > #endif > #ifndef CONFIG_TCG > #define TCG_ERROR QEMU_ERROR("tcg is disabled") > #endif > > Not sure where to put these, but certainly not arm specific. > > Then, > > void arm_cpu_tcg_set_irq(void *opaque, int irq, int level) > TCG_ERROR; > void arm_cpu_kvm_set_irq(void *opaque, int irq, int level) > KVM_ERROR; > > if (kvm_enabled()) { > qdev_init_gpio_in(DEVICE(cpu), arm_cpu_kvm_set_irq, 4); > } else if (tcg_enabled()) { > qdev_init_gpio_in(DEVICE(cpu), arm_cpu_tcg_set_irq, 4); > } else { > g_assert_not_reached(); > } > > So arm_cpu_kvm_set_irq can go in kvm/ and needs no ifdef. > > I'll let folks interested in xen and hvf figure our what needs doing with the > above. > > > r~ > Thanks, Claudio