Re: [PATCH v2] f2fs: compress: support zstd compress algorithm

[Chao Yu <yuchao0@huawei.com>]

[-- Attachment #1: Type: text/plain, Size: 3651 bytes --]

Hi,

Thanks for the report.

I guess we need to apply below patches first:

[PATCH 1/2] f2fs: compress: fix to call missing destroy_compress_ctx()
[PATCH 2/2] f2fs: compress: add .{init,destroy}_decompress_ctx callback

On 2020/3/4 9:00, kbuild test robot wrote:
> Hi Chao,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on f2fs/dev-test]
> [also build test ERROR on v5.6-rc4 next-20200303]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> 
> url:    https://github.com/0day-ci/linux/commits/Chao-Yu/f2fs-compress-support-zstd-compress-algorithm/20200304-020312
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
> config: x86_64-allyesconfig (attached as .config)
> compiler: clang version 11.0.0 (git://gitmirror/llvm_project 211fb91f1067ecdf7c0b8a019bcf76554d813129)
> reproduce:
>         # FIXME the reproduce steps for clang is not ready yet
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>>> fs/f2fs/compress.c:450:3: error: field designator 'init_decompress_ctx' does not refer to any field in type 'const struct f2fs_compress_ops'; did you mean 'init_compress_ctx'?
>            .init_decompress_ctx    = zstd_init_decompress_ctx,
>             ^~~~~~~~~~~~~~~~~~~
>             init_compress_ctx
>    fs/f2fs/compress.c:21:8: note: 'init_compress_ctx' declared here
>            int (*init_compress_ctx)(struct compress_ctx *cc);
>                  ^
>>> fs/f2fs/compress.c:450:25: error: incompatible function pointer types initializing 'int (*)(struct compress_ctx *)' with an expression of type 'int (struct decompress_io_ctx *)' [-Werror,-Wincompatible-function-pointer-types]
>            .init_decompress_ctx    = zstd_init_decompress_ctx,
>                                      ^~~~~~~~~~~~~~~~~~~~~~~~
>>> fs/f2fs/compress.c:451:3: error: field designator 'destroy_decompress_ctx' does not refer to any field in type 'const struct f2fs_compress_ops'; did you mean 'destroy_compress_ctx'?
>            .destroy_decompress_ctx = zstd_destroy_decompress_ctx,
>             ^~~~~~~~~~~~~~~~~~~~~~
>             destroy_compress_ctx
>    fs/f2fs/compress.c:22:9: note: 'destroy_compress_ctx' declared here
>            void (*destroy_compress_ctx)(struct compress_ctx *cc);
>                   ^
>>> fs/f2fs/compress.c:451:28: error: incompatible function pointer types initializing 'void (*)(struct compress_ctx *)' with an expression of type 'void (struct decompress_io_ctx *)' [-Werror,-Wincompatible-function-pointer-types]
>            .destroy_decompress_ctx = zstd_destroy_decompress_ctx,
>                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    4 errors generated.
> 
> vim +450 fs/f2fs/compress.c
> 
>    445	
>    446	static const struct f2fs_compress_ops f2fs_zstd_ops = {
>    447		.init_compress_ctx	= zstd_init_compress_ctx,
>    448		.destroy_compress_ctx	= zstd_destroy_compress_ctx,
>    449		.compress_pages		= zstd_compress_pages,
>  > 450		.init_decompress_ctx	= zstd_init_decompress_ctx,
>  > 451		.destroy_decompress_ctx	= zstd_destroy_decompress_ctx,
>    452		.decompress_pages	= zstd_decompress_pages,
>    453	};
>    454	#endif
>    455	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
>