From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heinrich Schuchardt Date: Tue, 26 Nov 2019 02:17:22 +0100 Subject: [U-Boot] [PATCH v2] cmd: efidebug: fix a build error in show_efi_boot_opt() In-Reply-To: <20191126011122.31991-1-takahiro.akashi@linaro.org> References: <20191126011122.31991-1-takahiro.akashi@linaro.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/26/19 2:11 AM, AKASHI Takahiro wrote: > I detected the following error in sandbox with Clang on Travis CI: > +cmd/efidebug.c:703:15: error: result of comparison of constant > 9223372036854775822 with expression of type 'int' is always false > [-Werror,-Wtautological-constant-out-of-range-compare] > + else if (ret == EFI_NOT_FOUND) > + ~~~ ^ ~~~~~~~~~~~~~ > > Simply changing a type of 'ret' to efi_status_t will fix this error. > > Signed-off-by: AKASHI Takahiro Reviewed-by: Heinrich Schuchardt > --- > cmd/efidebug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/cmd/efidebug.c b/cmd/efidebug.c > index ef97e19d0735..1fff4390deae 100644 > --- a/cmd/efidebug.c > +++ b/cmd/efidebug.c > @@ -684,7 +684,7 @@ static void show_efi_boot_opt(int id) > efi_guid_t guid; > void *data = NULL; > efi_uintn_t size; > - int ret; > + efi_status_t ret; > > sprintf(var_name, "Boot%04X", id); > p = var_name16; > @@ -693,7 +693,7 @@ static void show_efi_boot_opt(int id) > > size = 0; > ret = EFI_CALL(RT->get_variable(var_name16, &guid, NULL, &size, NULL)); > - if (ret == (int)EFI_BUFFER_TOO_SMALL) { > + if (ret == EFI_BUFFER_TOO_SMALL) { > data = malloc(size); > ret = EFI_CALL(RT->get_variable(var_name16, &guid, NULL, &size, > data)); >