From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Andrey Shinkevich" <andrey.shinkevich@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: vsementsov@virtuozzo.com, berto@igalia.com, ehabkost@redhat.com,
kvm@vger.kernel.org, mtosatti@redhat.com,
mdroth@linux.vnet.ibm.com, armbru@redhat.com, den@openvz.org,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call
Date: Tue, 30 Jul 2019 21:22:16 +0200 [thread overview]
Message-ID: <b876f6e4-5469-ae03-2a8d-d433ec35d735@redhat.com> (raw)
In-Reply-To: <7a78ef04-4120-20d9-d5f4-6572c5676344@redhat.com>
On 30/07/19 18:44, Philippe Mathieu-Daudé wrote:
>> +++ b/target/i386/kvm.c
>> @@ -190,6 +190,7 @@ static int kvm_get_tsc(CPUState *cs)
>> return 0;
>> }
>>
>> + memset(&msr_data, 0, sizeof(msr_data));
> I wonder the overhead of this one...
>
There is just one MSR in the struct so it is okay.
Paolo
next prev parent reply other threads:[~2019-07-30 19:22 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 16:01 [PATCH 0/3] Reduce the number of Valgrind reports in unit tests Andrey Shinkevich
2019-07-30 16:01 ` [Qemu-devel] " Andrey Shinkevich
2019-07-30 16:01 ` [PATCH 1/3] test-throttle: Fix uninitialized use of burst_length Andrey Shinkevich
2019-07-30 16:01 ` [Qemu-devel] " Andrey Shinkevich
2019-08-13 12:19 ` Alberto Garcia
2019-08-13 12:19 ` [Qemu-devel] " Alberto Garcia
2019-07-30 16:01 ` [PATCH 2/3] tests: Fix uninitialized byte in test_visitor_in_fuzz Andrey Shinkevich
2019-07-30 16:01 ` [Qemu-devel] " Andrey Shinkevich
2019-07-30 16:01 ` [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call Andrey Shinkevich
2019-07-30 16:01 ` [Qemu-devel] " Andrey Shinkevich
2019-07-30 16:44 ` Philippe Mathieu-Daudé
2019-07-30 16:44 ` Philippe Mathieu-Daudé
2019-07-30 17:05 ` Christian Borntraeger
2019-07-30 17:05 ` Christian Borntraeger
2019-07-30 17:14 ` Philippe Mathieu-Daudé
2019-07-30 17:14 ` Philippe Mathieu-Daudé
2019-07-30 17:47 ` Christian Borntraeger
2019-07-30 17:47 ` Christian Borntraeger
2019-07-31 9:05 ` Christophe de Dinechin
2019-07-31 9:05 ` Christophe de Dinechin
2019-07-31 12:32 ` Paolo Bonzini
2019-07-31 12:32 ` Paolo Bonzini
2019-07-31 14:10 ` Andrey Shinkevich
2019-07-31 14:10 ` Andrey Shinkevich
2019-07-30 19:22 ` Paolo Bonzini [this message]
2019-07-30 16:46 ` Peter Maydell
2019-07-30 16:46 ` Peter Maydell
2019-07-30 17:09 ` Christian Borntraeger
2019-07-30 17:09 ` Christian Borntraeger
2019-07-30 19:20 ` Paolo Bonzini
2019-07-30 19:20 ` [Qemu-devel] " Paolo Bonzini
2019-07-31 7:24 ` Christian Borntraeger
2019-07-31 7:24 ` [Qemu-devel] " Christian Borntraeger
2019-07-31 12:04 ` Andrey Shinkevich
2019-07-31 12:04 ` [Qemu-devel] " Andrey Shinkevich
2019-07-31 12:28 ` Christian Borntraeger
2019-07-31 12:28 ` [Qemu-devel] " Christian Borntraeger
2019-07-31 12:43 ` Christian Borntraeger
2019-07-31 12:43 ` [Qemu-devel] " Christian Borntraeger
2019-07-31 13:03 ` Paolo Bonzini
2019-07-31 13:03 ` [Qemu-devel] " Paolo Bonzini
2019-07-31 14:11 ` Andrey Shinkevich
2019-07-31 14:11 ` [Qemu-devel] " Andrey Shinkevich
2019-08-13 12:02 ` [PATCH 0/3] Reduce the number of Valgrind reports in unit tests Andrey Shinkevich
2019-08-13 12:02 ` [Qemu-devel] " Andrey Shinkevich
2019-08-13 12:05 ` Paolo Bonzini
2019-08-13 12:05 ` [Qemu-devel] " Paolo Bonzini
2019-08-13 12:08 ` Andrey Shinkevich
2019-08-13 12:08 ` [Qemu-devel] " Andrey Shinkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b876f6e4-5469-ae03-2a8d-d433ec35d735@redhat.com \
--to=pbonzini@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=den@openvz.org \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mtosatti@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.