From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F4FEC433E9 for ; Thu, 11 Mar 2021 16:12:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCBD464D5D for ; Thu, 11 Mar 2021 16:12:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234494AbhCKQM2 (ORCPT ); Thu, 11 Mar 2021 11:12:28 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:57202 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234465AbhCKQL4 (ORCPT ); Thu, 11 Mar 2021 11:11:56 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DxDV06DYQz1s00y; Thu, 11 Mar 2021 17:11:52 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DxDV0432hz1qr4l; Thu, 11 Mar 2021 17:11:52 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id jnJYO_qSd5et; Thu, 11 Mar 2021 17:11:50 +0100 (CET) X-Auth-Info: 2KuBOCaE/sL/z2h12qu6ViGM9U9yOLCzuzHVP39GOc4= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 11 Mar 2021 17:11:50 +0100 (CET) Subject: Re: [Linux-stm32] [PATCH v2 00/14] Introduce STM32MP1 RCC in secured mode To: Ahmad Fatoum , Alexandre TORGUE , Alexandre TORGUE , "Alex G." , Gabriel FERNANDEZ - foss , Michael Turquette , Stephen Boyd , Rob Herring , Maxime Coquelin , Philipp Zabel , Etienne CARRIERE Cc: "devicetree@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" References: <20210126090120.19900-1-gabriel.fernandez@foss.st.com> <2e04f814-b694-119d-fe8a-13e6df129536@gmail.com> <463dafed-ec60-cd9a-33d2-ba118a6af629@foss.st.com> From: Marek Vasut Message-ID: Date: Thu, 11 Mar 2021 17:11:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/11/21 3:41 PM, Ahmad Fatoum wrote: > Hello, Hi, > On 11.03.21 15:02, Alexandre TORGUE wrote: >> On 3/11/21 12:43 PM, Marek Vasut wrote: >>> On 3/11/21 9:08 AM, Alexandre TORGUE wrote: >>>> 1- Break the current ABI: as soon as those patches are merged, stm32mp157c-dk2.dtb will impose to use >>>> A tf-a for scmi clocks. For people using u-boot spl, the will have to create their own "no-secure" devicetree. >>> >>> NAK, this breaks existing boards and existing setups, e.g. DK2 that does not use ATF. >>> >>>> 2-As you suggest, create a new "secure" dtb per boards (Not my wish for maintenance perspectives). >>> >>> I agree with Alex (G) that the "secure" option should be opt-in. >>> That way existing setups remain working and no extra requirements are imposed on MP1 users. Esp. since as far as I understand this, the "secure" part isn't really about security, but rather about moving clock configuration from Linux to some firmware blob. >>> >>>> 3- Keep kernel device tree as they are and applied this secure layer (scmi clocks phandle) thanks to dtbo in >>>> U-boot. >>> >>> Is this really better than >>> #include "stm32mp15xx-enable-secure-stuff.dtsi" >>> in a board DT ? Because that is how I imagine the opt-in "secure" option could work. >>> >> >> Discussing with Patrick about u-boot, we could use dtbo application thanks to extlinux.conf. BUT it it will not prevent other case (i.e. TF-A which jump directly in kernel@). So the "least worst" solution is to create a new "stm32mp1257c-scmi-dk2 board which will overload clock entries with a scmi phandle (as proposed by Alex). > > I raised this issue before with your colleagues. I still believe the correct way > would be for the TF-A to pass down either a device tree or an overlay with the > actual settings in use, e.g.: > > - Clocks/Resets done via SCMI > - Reserved memory regions > > If TF-A directly boots Linux, it can apply the overlay itself, otherwise it's > passed down to SSBL that applies it before booting Linux. That sounds good and it is something e.g. R-Car already does, it merges DT fragment from prior stages at U-Boot level and then passes the result to Linux. So on ST hardware, the same could very well happen and it would work for both non-ATF / ATF / ATF+TEE options. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DB3BC433E0 for ; Thu, 11 Mar 2021 16:13:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F4B564FF3 for ; Thu, 11 Mar 2021 16:13:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F4B564FF3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e5VWhr0p9Voj6fAnuwZcbHI1NPMb+kLKyYmmocD1k1c=; b=QD3H0PW7ZbcjkG0cVeB+lW0VY 3nvFMlJX7s8+ufxUMeBqWBzq/N+pLwdeE15zs8TIJuyF1SiExiXBDv7FvRGa/FpIcUBhwvHa/4Ur0 gKX2WzFtyMtwKFmEjSaDPTLcNc1k9wOxycB/2BWjZceBxEq8QZ4VZagxofU4wZI3C5pTgtheHooro z9Z0RaL4NLYlJVfI090QqAAU8kxDHYvmtvLJDjw+Xz+t8yLNSoGWomkWwyTS8x3TqZF2NAdEjrdyz DT+rsf4tNHZGYa9WuB19TvRflIpW7aXmTwpsy7NbU9HsmvSwU7EXssQdQWKsc78q8rQXCbPS2cM3l jWA8qrY7w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKNur-009XPD-BH; Thu, 11 Mar 2021 16:12:01 +0000 Received: from mail-out.m-online.net ([2001:a60:0:28:0:1:25:1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKNuk-009XNk-8O for linux-arm-kernel@lists.infradead.org; Thu, 11 Mar 2021 16:11:59 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DxDV06DYQz1s00y; Thu, 11 Mar 2021 17:11:52 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DxDV0432hz1qr4l; Thu, 11 Mar 2021 17:11:52 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id jnJYO_qSd5et; Thu, 11 Mar 2021 17:11:50 +0100 (CET) X-Auth-Info: 2KuBOCaE/sL/z2h12qu6ViGM9U9yOLCzuzHVP39GOc4= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 11 Mar 2021 17:11:50 +0100 (CET) Subject: Re: [Linux-stm32] [PATCH v2 00/14] Introduce STM32MP1 RCC in secured mode To: Ahmad Fatoum , Alexandre TORGUE , Alexandre TORGUE , "Alex G." , Gabriel FERNANDEZ - foss , Michael Turquette , Stephen Boyd , Rob Herring , Maxime Coquelin , Philipp Zabel , Etienne CARRIERE Cc: "devicetree@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" References: <20210126090120.19900-1-gabriel.fernandez@foss.st.com> <2e04f814-b694-119d-fe8a-13e6df129536@gmail.com> <463dafed-ec60-cd9a-33d2-ba118a6af629@foss.st.com> From: Marek Vasut Message-ID: Date: Thu, 11 Mar 2021 17:11:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210311_161154_626313_5E5C773D X-CRM114-Status: GOOD ( 20.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/11/21 3:41 PM, Ahmad Fatoum wrote: > Hello, Hi, > On 11.03.21 15:02, Alexandre TORGUE wrote: >> On 3/11/21 12:43 PM, Marek Vasut wrote: >>> On 3/11/21 9:08 AM, Alexandre TORGUE wrote: >>>> 1- Break the current ABI: as soon as those patches are merged, stm32mp157c-dk2.dtb will impose to use >>>> A tf-a for scmi clocks. For people using u-boot spl, the will have to create their own "no-secure" devicetree. >>> >>> NAK, this breaks existing boards and existing setups, e.g. DK2 that does not use ATF. >>> >>>> 2-As you suggest, create a new "secure" dtb per boards (Not my wish for maintenance perspectives). >>> >>> I agree with Alex (G) that the "secure" option should be opt-in. >>> That way existing setups remain working and no extra requirements are imposed on MP1 users. Esp. since as far as I understand this, the "secure" part isn't really about security, but rather about moving clock configuration from Linux to some firmware blob. >>> >>>> 3- Keep kernel device tree as they are and applied this secure layer (scmi clocks phandle) thanks to dtbo in >>>> U-boot. >>> >>> Is this really better than >>> #include "stm32mp15xx-enable-secure-stuff.dtsi" >>> in a board DT ? Because that is how I imagine the opt-in "secure" option could work. >>> >> >> Discussing with Patrick about u-boot, we could use dtbo application thanks to extlinux.conf. BUT it it will not prevent other case (i.e. TF-A which jump directly in kernel@). So the "least worst" solution is to create a new "stm32mp1257c-scmi-dk2 board which will overload clock entries with a scmi phandle (as proposed by Alex). > > I raised this issue before with your colleagues. I still believe the correct way > would be for the TF-A to pass down either a device tree or an overlay with the > actual settings in use, e.g.: > > - Clocks/Resets done via SCMI > - Reserved memory regions > > If TF-A directly boots Linux, it can apply the overlay itself, otherwise it's > passed down to SSBL that applies it before booting Linux. That sounds good and it is something e.g. R-Car already does, it merges DT fragment from prior stages at U-Boot level and then passes the result to Linux. So on ST hardware, the same could very well happen and it would work for both non-ATF / ATF / ATF+TEE options. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel