From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0421EC432BE for ; Fri, 23 Jul 2021 06:14:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAA6A60E90 for ; Fri, 23 Jul 2021 06:14:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233869AbhGWFeO (ORCPT ); Fri, 23 Jul 2021 01:34:14 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33816 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229788AbhGWFeN (ORCPT ); Fri, 23 Jul 2021 01:34:13 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16N680x1154708; Fri, 23 Jul 2021 02:14:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : subject : to : cc : references : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=RF+RAEs8+U5n3JMz636Knj9hNkDXHa3/dt62ULGTEi4=; b=i5YaZbRop38UIdygOPoBopHly4JvG+pD7n9Gigxvt32Z0f6IjGvZfwmpBqSsq7lY2i+b s2c/vZZfn4lr8g33wrN8PlgHYvxVnNsHW5QPCuTVTWctxGljRiMc9kbU8YLlwL9+8dID A+covGoR9uh+hPTLwpPZi5G0vKi95v3fUiv2eYt3HhjbGoyV8OiO1/op5wRxKEqQwi9+ sPhKoOpMd8Hew7TKg69WYGSLMB70+suQsCIZtZv3S7ICnWHFOO0AIBy58C5Y67bEKEBr lqskhShlFUArdC5Tx02IpH7lbzgRJJ6ZdNOmR9QTyVf8SCUT5x4XsOQqZ95ssO8TEQ3k sw== Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0b-001b2d01.pphosted.com with ESMTP id 39ypjea9gj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Jul 2021 02:14:25 -0400 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16N69ErS013314; Fri, 23 Jul 2021 06:14:23 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma06ams.nl.ibm.com with ESMTP id 39vng72fse-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Jul 2021 06:14:23 +0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16N6BoSQ30409042 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Jul 2021 06:11:50 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4AC5F42042; Fri, 23 Jul 2021 06:14:20 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C298442041; Fri, 23 Jul 2021 06:14:19 +0000 (GMT) Received: from oc7455500831.ibm.com (unknown [9.145.25.128]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 23 Jul 2021 06:14:19 +0000 (GMT) From: Christian Borntraeger Subject: Re: [PATCH v2 0/4] Fix restricted DMA vs swiotlb_exit() To: Halil Pasic Cc: Will Deacon , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Guenter Roeck , Claire Chang , Christoph Hellwig , Robin Murphy , Konrad Rzeszutek Wilk , Nathan Chancellor , linux-s390 , Vasily Gorbik , Heiko Carstens References: <20210720133826.9075-1-will@kernel.org> <57e37ef9-c055-d6a6-2244-2c7dd243b5c1@de.ibm.com> <20210723031252.655d6a83.pasic@linux.ibm.com> Message-ID: Date: Fri, 23 Jul 2021 08:14:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210723031252.655d6a83.pasic@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-GUID: UrE2dl66hYVYxVrAj4LJDQFghwLh85Dh X-Proofpoint-ORIG-GUID: UrE2dl66hYVYxVrAj4LJDQFghwLh85Dh Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-07-23_03:2021-07-22,2021-07-23 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 clxscore=1015 priorityscore=1501 spamscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 phishscore=0 suspectscore=0 impostorscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107230031 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Resending with the correct email of Heiko.... On 23.07.21 03:12, Halil Pasic wrote: > On Thu, 22 Jul 2021 21:22:58 +0200 > Christian Borntraeger wrote: > >> On 20.07.21 15:38, Will Deacon wrote: >>> Hi again, folks, >>> >>> This is version two of the patch series I posted yesterday: >>> >>> https://lore.kernel.org/r/20210719123054.6844-1-will@kernel.org >>> >>> The only changes since v1 are: >>> >>> * Squash patches 2 and 3, amending the commit message accordingly >>> * Add Reviewed-by and Tested-by tags from Christoph and Claire (thanks!) >>> >>> I'd usually leave it a bit longer between postings, but since this fixes >>> issues with patches in -next I thought I'd spin a new version immediately. >>> >>> Cheers, >> >> FWIW, I just bisected virtio-errors with secure execution mode >> qemu-system-s390x: virtio-serial-bus: Unexpected port id 4205794771 for device virtio-serial0.0 >> >> to >> commit 903cd0f315fe426c6a64c54ed389de0becb663dc >> Author: Claire Chang >> Date: Thu Jun 24 23:55:20 2021 +0800 >> >> swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing >> >> Unfortunately this patch series does NOT fix this issue, so it seems that even more >> things are broken. >> >> Any idea what else might be broken? > > I've done some debugging, and I think I know what is going on. Since > that commit we need to set force_swiotlb before the swiotlb itself is > initialized. So the patch below should fix the problem. > > --------------------8<------------------------------------- > > From: Halil Pasic > Date: Fri, 23 Jul 2021 02:57:06 +0200 > Subject: [PATCH 1/1] s390/pv: fix the forcing of the swiotlb > > Since commit 903cd0f315fe ("swiotlb: Use is_swiotlb_force_bounce for > swiotlb data bouncing") if code sets swiotlb_force it needs to do so > before the swiotlb is initialised. Otherwise > io_tlb_default_mem->force_bounce will not get set to true, and devices > that use (the default) swiotlb will not bounce despite switolb_force > having the value of SWIOTLB_FORCE. > > Let us restore swiotlb functionality for PV by fulfilling this new > requirement. > I would add: Fixes: 903cd0f315fe ("swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing") as this patch breaks things and Fixes: 64e1f0c531d1 ("s390/mm: force swiotlb for protected virtualization") to make the s390 init code more robust in case people start backporting things. > Signed-off-by: Halil Pasic I can confirm that this fixes the problem. This also makes sense codewise. Tested-by: Christian Borntraeger Reviewed-by: Christian Borntraeger Konrad, Heiko, Vasily, any preference which tree this goes? I think s390 would be easiest, but that requires that the patches in the swiotlb tree have fixed commit IDs. > --- > arch/s390/mm/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c > index 8ac710de1ab1..07bbee9b7320 100644 > --- a/arch/s390/mm/init.c > +++ b/arch/s390/mm/init.c > @@ -186,9 +186,9 @@ static void pv_init(void) > return; > > /* make sure bounce buffers are shared */ > + swiotlb_force = SWIOTLB_FORCE; > swiotlb_init(1); > swiotlb_update_mem_attributes(); > - swiotlb_force = SWIOTLB_FORCE; > } > > void __init mem_init(void) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7231CC4338F for ; Fri, 23 Jul 2021 06:14:35 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0518560E95 for ; Fri, 23 Jul 2021 06:14:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0518560E95 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=de.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C51A76066F; Fri, 23 Jul 2021 06:14:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GsIeuz6SyT3A; Fri, 23 Jul 2021 06:14:34 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id AD11E6063E; Fri, 23 Jul 2021 06:14:33 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 781E4C0010; Fri, 23 Jul 2021 06:14:33 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id C1811C000E for ; Fri, 23 Jul 2021 06:14:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A283583478 for ; Fri, 23 Jul 2021 06:14:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=ibm.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L7q-xyjhGpcq for ; Fri, 23 Jul 2021 06:14:31 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by smtp1.osuosl.org (Postfix) with ESMTPS id A6EC883412 for ; Fri, 23 Jul 2021 06:14:31 +0000 (UTC) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16N680x1154708; Fri, 23 Jul 2021 02:14:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : subject : to : cc : references : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=RF+RAEs8+U5n3JMz636Knj9hNkDXHa3/dt62ULGTEi4=; b=i5YaZbRop38UIdygOPoBopHly4JvG+pD7n9Gigxvt32Z0f6IjGvZfwmpBqSsq7lY2i+b s2c/vZZfn4lr8g33wrN8PlgHYvxVnNsHW5QPCuTVTWctxGljRiMc9kbU8YLlwL9+8dID A+covGoR9uh+hPTLwpPZi5G0vKi95v3fUiv2eYt3HhjbGoyV8OiO1/op5wRxKEqQwi9+ sPhKoOpMd8Hew7TKg69WYGSLMB70+suQsCIZtZv3S7ICnWHFOO0AIBy58C5Y67bEKEBr lqskhShlFUArdC5Tx02IpH7lbzgRJJ6ZdNOmR9QTyVf8SCUT5x4XsOQqZ95ssO8TEQ3k sw== Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0b-001b2d01.pphosted.com with ESMTP id 39ypjea9gj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Jul 2021 02:14:25 -0400 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16N69ErS013314; Fri, 23 Jul 2021 06:14:23 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma06ams.nl.ibm.com with ESMTP id 39vng72fse-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Jul 2021 06:14:23 +0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16N6BoSQ30409042 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Jul 2021 06:11:50 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4AC5F42042; Fri, 23 Jul 2021 06:14:20 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C298442041; Fri, 23 Jul 2021 06:14:19 +0000 (GMT) Received: from oc7455500831.ibm.com (unknown [9.145.25.128]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 23 Jul 2021 06:14:19 +0000 (GMT) From: Christian Borntraeger Subject: Re: [PATCH v2 0/4] Fix restricted DMA vs swiotlb_exit() To: Halil Pasic References: <20210720133826.9075-1-will@kernel.org> <57e37ef9-c055-d6a6-2244-2c7dd243b5c1@de.ibm.com> <20210723031252.655d6a83.pasic@linux.ibm.com> Message-ID: Date: Fri, 23 Jul 2021 08:14:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210723031252.655d6a83.pasic@linux.ibm.com> Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-GUID: UrE2dl66hYVYxVrAj4LJDQFghwLh85Dh X-Proofpoint-ORIG-GUID: UrE2dl66hYVYxVrAj4LJDQFghwLh85Dh X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-23_03:2021-07-22, 2021-07-23 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 clxscore=1015 priorityscore=1501 spamscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 phishscore=0 suspectscore=0 impostorscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107230031 Cc: linux-s390 , Vasily Gorbik , Konrad Rzeszutek Wilk , Robin Murphy , Heiko Carstens , linux-kernel@vger.kernel.org, Nathan Chancellor , iommu@lists.linux-foundation.org, Claire Chang , Will Deacon , Christoph Hellwig , Guenter Roeck X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Resending with the correct email of Heiko.... On 23.07.21 03:12, Halil Pasic wrote: > On Thu, 22 Jul 2021 21:22:58 +0200 > Christian Borntraeger wrote: > >> On 20.07.21 15:38, Will Deacon wrote: >>> Hi again, folks, >>> >>> This is version two of the patch series I posted yesterday: >>> >>> https://lore.kernel.org/r/20210719123054.6844-1-will@kernel.org >>> >>> The only changes since v1 are: >>> >>> * Squash patches 2 and 3, amending the commit message accordingly >>> * Add Reviewed-by and Tested-by tags from Christoph and Claire (thanks!) >>> >>> I'd usually leave it a bit longer between postings, but since this fixes >>> issues with patches in -next I thought I'd spin a new version immediately. >>> >>> Cheers, >> >> FWIW, I just bisected virtio-errors with secure execution mode >> qemu-system-s390x: virtio-serial-bus: Unexpected port id 4205794771 for device virtio-serial0.0 >> >> to >> commit 903cd0f315fe426c6a64c54ed389de0becb663dc >> Author: Claire Chang >> Date: Thu Jun 24 23:55:20 2021 +0800 >> >> swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing >> >> Unfortunately this patch series does NOT fix this issue, so it seems that even more >> things are broken. >> >> Any idea what else might be broken? > > I've done some debugging, and I think I know what is going on. Since > that commit we need to set force_swiotlb before the swiotlb itself is > initialized. So the patch below should fix the problem. > > --------------------8<------------------------------------- > > From: Halil Pasic > Date: Fri, 23 Jul 2021 02:57:06 +0200 > Subject: [PATCH 1/1] s390/pv: fix the forcing of the swiotlb > > Since commit 903cd0f315fe ("swiotlb: Use is_swiotlb_force_bounce for > swiotlb data bouncing") if code sets swiotlb_force it needs to do so > before the swiotlb is initialised. Otherwise > io_tlb_default_mem->force_bounce will not get set to true, and devices > that use (the default) swiotlb will not bounce despite switolb_force > having the value of SWIOTLB_FORCE. > > Let us restore swiotlb functionality for PV by fulfilling this new > requirement. > I would add: Fixes: 903cd0f315fe ("swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing") as this patch breaks things and Fixes: 64e1f0c531d1 ("s390/mm: force swiotlb for protected virtualization") to make the s390 init code more robust in case people start backporting things. > Signed-off-by: Halil Pasic I can confirm that this fixes the problem. This also makes sense codewise. Tested-by: Christian Borntraeger Reviewed-by: Christian Borntraeger Konrad, Heiko, Vasily, any preference which tree this goes? I think s390 would be easiest, but that requires that the patches in the swiotlb tree have fixed commit IDs. > --- > arch/s390/mm/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/mm/init.c b/arch/s390/mm/init.c > index 8ac710de1ab1..07bbee9b7320 100644 > --- a/arch/s390/mm/init.c > +++ b/arch/s390/mm/init.c > @@ -186,9 +186,9 @@ static void pv_init(void) > return; > > /* make sure bounce buffers are shared */ > + swiotlb_force = SWIOTLB_FORCE; > swiotlb_init(1); > swiotlb_update_mem_attributes(); > - swiotlb_force = SWIOTLB_FORCE; > } > > void __init mem_init(void) > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu