On 23/02/2020 17:49, Jens Axboe wrote:
> On 2/23/20 4:02 AM, Pavel Begunkov wrote:
>> Looking at
>>
>> io_async_task_func() {
>> 	...
>> 	/* ensure req->work.creds is valid for __io_queue_sqe() */
>> 	req->work.creds = apoll->work.creds;
>> }
>>
>> It copies creds, but doesn't touch the rest req->work fields. And if you have
>> one, you most probably got all of them in *grab_env(). Are you sure it doesn't
>> leak, e.g. mmgrab()'ed mm?
> 
> You're looking at a version that only existed for about 20 min, had to
> check I pushed it out. But ce21471abe0fef is the current one, it does
> a full memcpy() of it.

Lucky me, great then

> 
> Thanks, I'll fold this in, if you don't mind.

Sure

-- 
Pavel Begunkov