From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 001C2C433F5 for ; Wed, 12 Jan 2022 10:18:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352470AbiALKSQ (ORCPT ); Wed, 12 Jan 2022 05:18:16 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:59368 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352457AbiALKSH (ORCPT ); Wed, 12 Jan 2022 05:18:07 -0500 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 11C423FFCF for ; Wed, 12 Jan 2022 10:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1641982686; bh=aPXjXruDq54PeYQ9iMhjoDG9FDgbk3AB64hbIMorCCc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZTrjUzUcNPQHYTA0VnqAFc5Mp+WdID8hg3+ypr68JZbAcNIgRfxNgS+5jamS1ZWFD pqBy5Ht5E6DycXbt007XSgovfUrRPNfUGEwZcUdd6/Q3tSLeRYDulWU/vryibetTHe AQwaX4jg1V7Br7UEwkyDhdAFipfwdC7UBDOgE73NeiCDJcohNstOmB524c1ouhBPZN yCHuRzZfKxw3sGV9ecImvCyF9btp6RGsQwYBEEy1ECsbf6sUtEs1nyBw/CLxVDk0WT F4EeFA4OvRfaBH8qH2sxTJaJ3MHcMvTxLGiA1AywtZBdiHWuzyXuNxzQqDEpIeuo0C AVyQZOHNnFeJA== Received: by mail-ed1-f72.google.com with SMTP id i9-20020a05640242c900b003fe97faab62so1837120edc.9 for ; Wed, 12 Jan 2022 02:18:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=aPXjXruDq54PeYQ9iMhjoDG9FDgbk3AB64hbIMorCCc=; b=8AkOyZkK0aFor8HkjsRqyoDQ96h/kp7+3YbCobSt1po5A5IJRcU35rUkcyfVsd6I3N AdL6Xv3BDNBVGlAG8EFH5US0Ee9kvXU3MrV8hMRx+lOEnPkjxoLl42zPoTMjolvbrPmz tA5SS0GYTJKj34yTGR8khvb+gJuulu3hysKjtgACThZ49TSgbwbTaxIlw9UCTOQmXzmb c2E0Bt9dr/XTcnlLVDBH9SefqQJh/P2WAwvFz7hvCKckIA7P9fhZd7yT/VZI1tMz6iro EMOP2MgN0u7kkKOURlusy8eBGvJPJzeukxp+sAaW0bHwEWPLhAFoDvsrDem8BMo9DZPC fZ9g== X-Gm-Message-State: AOAM532y6FmnL80TTbI0affF5snA09HGC9ZyxpipnPDD1PSbmjIOubQm t1JyxQnP+qxj8LnWPMDNzalNIRH0GoxngfXYA7loeyES0kjDz406ztJRBxBpbX3BaoOnHG1qjuj Q5YYDDJiIqYMrJDbjF18aIaLDDxchU1fdg3hxuCTy5A== X-Received: by 2002:a17:906:ecee:: with SMTP id qt14mr471024ejb.133.1641982685615; Wed, 12 Jan 2022 02:18:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxkDLUnDXncfLM2SjyZMmYMSSgiKcr4RLjw+16eEj0TVwkNqMlPbJfgszDEo6F90TMvDr8RGQ== X-Received: by 2002:a17:906:ecee:: with SMTP id qt14mr470995ejb.133.1641982685404; Wed, 12 Jan 2022 02:18:05 -0800 (PST) Received: from [192.168.0.29] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id eb14sm6047322edb.16.2022.01.12.02.18.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 02:18:05 -0800 (PST) Message-ID: Date: Wed, 12 Jan 2022 11:18:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v2 2/6] dt-bindings: memory: mtk-smi: Fix the larb clock/clock-names dtbs warning Content-Language: en-US To: Yong Wu , Rob Herring , Matthias Brugger Cc: Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, anan.sun@mediatek.com, lc.kan@mediatek.com, yi.kuo@mediatek.com, anthony.huang@mediatek.com, AngeloGioacchino Del Regno References: <20220111063904.7583-1-yong.wu@mediatek.com> <20220111063904.7583-3-yong.wu@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220111063904.7583-3-yong.wu@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/01/2022 07:39, Yong Wu wrote: > Mute the warning from "make dtbs_check": > > larb@14017000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > ... > > larb@16010000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > > larb@17010000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > > If a platform's larb supports gals, there will be some larbs have one > more "gals" clock while the others still only need "apb"/"smi" clocks, > then the minItems for clock and clock-names are 2. > > Fixes: 27bb0e42855a ("dt-bindings: memory: mediatek: Convert SMI to DT schema") > Signed-off-by: Yong Wu > --- > .../bindings/memory-controllers/mediatek,smi-larb.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > index 80907e357892..884c0c74e5e4 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > @@ -80,10 +80,10 @@ allOf: > then: > properties: > clock: Separate patch: This should be clocks. The same in second if. Now it is simply not working... > - items: Putting min/maxItems under items is wrong. The second if also needs the fixing. Please make it a separate patch before this one. The schema was clearly not tested before... > - minItems: 3 > - maxItems: 3 > + minItems: 2 > + maxItems: 3 > clock-names: > + minItems: 2 > items: > - const: apb > - const: smi > Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2CFFC433EF for ; Wed, 12 Jan 2022 10:18:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7C890415FE; Wed, 12 Jan 2022 10:18:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ihFBtwvRrAKM; Wed, 12 Jan 2022 10:18:09 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 78217415FB; Wed, 12 Jan 2022 10:18:09 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 487E5C0030; Wed, 12 Jan 2022 10:18:09 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6C62AC001E for ; Wed, 12 Jan 2022 10:18:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6848C41600 for ; Wed, 12 Jan 2022 10:18:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zx5MBXZLLc6K for ; Wed, 12 Jan 2022 10:18:07 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by smtp4.osuosl.org (Postfix) with ESMTPS id A6AF8415FB for ; Wed, 12 Jan 2022 10:18:07 +0000 (UTC) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id E36A93F1E9 for ; Wed, 12 Jan 2022 10:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1641982685; bh=aPXjXruDq54PeYQ9iMhjoDG9FDgbk3AB64hbIMorCCc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J1epngDH3rtVyI0kw1nwO+o1iWW//vTfuVENIMKaYqaYCseHA8Y02rjXUM2TiXrLv HVUj1uAoisc6ftWpERPfJ3h+P0YTJpRXYXML28XIIgdVh2JYF0kPHF35WHBKPy4fBx T/OvlmAS/hjnhz9ZKBSBrsVG7cdnZsM3/O6WsrPzxhL+tpMQqLF0TCS9IppAUSimMW I1GJpekek+y5jRkpRQ6m9UGqOjupIYzruyy9VKnm46sn0JXuGtdMuWzeI2HVd07/k8 Yib67PK91VooIO1EKwu4u4UsqFMfeub6qVfqkDNT1rC8Uh5DRR3iN+PU99tgfC2Lrm rtjo7M95toeAQ== Received: by mail-ed1-f71.google.com with SMTP id l14-20020aa7cace000000b003f7f8e1cbbdso1811829edt.20 for ; Wed, 12 Jan 2022 02:18:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=aPXjXruDq54PeYQ9iMhjoDG9FDgbk3AB64hbIMorCCc=; b=LINCfuhPtQhXzJ3h0iOF07fijG8MzDcnbVhClBTllOB7tRHy7xQBuykRbE9ev9VQMS O3TkzK210cYvkMDkFGIf1MB3rhvf4V9BmjgyVM2Y6T3fbzqzut0nrqT0qHFpdD9RWQa3 I1ozi128C/gZQtIuTXWSUTSaMJB1/Oy/8U/3iM7BLoxAQb3DgiPHBojKTBx8k7LUE5JN vtME8/i4AJ6goNNCVMDBbw/A0Aj3T01dXKt1zEOe1i20gKgWarKocyhTA+zAVi+CPYtG WzyxlYQA0B3e1v/lbtzGVbvjoQA7tIJ9Kp9eZ/wbwnsgH+YP5qZJOWUSeZketPfbnrHT PsgQ== X-Gm-Message-State: AOAM531saxBrwZPpTLVG1uuanuY/u5IA32a3khX9nx5Jw81/BjmjmrdQ 0kUeNDOAuLrsz6Ux2GXRRs72BU4+INJgf0Io8tuSna1Wyiuwx33VUQ5NXn9QjugjEsDjylTxpbn 3PZEEWiqcby1GN02qJBGvTjRMWrzjJTqc8nsfyP6p58Oc8Ds= X-Received: by 2002:a17:906:ecee:: with SMTP id qt14mr471014ejb.133.1641982685614; Wed, 12 Jan 2022 02:18:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxkDLUnDXncfLM2SjyZMmYMSSgiKcr4RLjw+16eEj0TVwkNqMlPbJfgszDEo6F90TMvDr8RGQ== X-Received: by 2002:a17:906:ecee:: with SMTP id qt14mr470995ejb.133.1641982685404; Wed, 12 Jan 2022 02:18:05 -0800 (PST) Received: from [192.168.0.29] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id eb14sm6047322edb.16.2022.01.12.02.18.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 02:18:05 -0800 (PST) Message-ID: Date: Wed, 12 Jan 2022 11:18:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v2 2/6] dt-bindings: memory: mtk-smi: Fix the larb clock/clock-names dtbs warning Content-Language: en-US To: Yong Wu , Rob Herring , Matthias Brugger References: <20220111063904.7583-1-yong.wu@mediatek.com> <20220111063904.7583-3-yong.wu@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220111063904.7583-3-yong.wu@mediatek.com> Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, yi.kuo@mediatek.com, srv_heupstream@mediatek.com, Will Deacon , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, lc.kan@mediatek.com, anthony.huang@mediatek.com, anan.sun@mediatek.com, Robin Murphy , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 11/01/2022 07:39, Yong Wu wrote: > Mute the warning from "make dtbs_check": > > larb@14017000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > ... > > larb@16010000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > > larb@17010000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > > If a platform's larb supports gals, there will be some larbs have one > more "gals" clock while the others still only need "apb"/"smi" clocks, > then the minItems for clock and clock-names are 2. > > Fixes: 27bb0e42855a ("dt-bindings: memory: mediatek: Convert SMI to DT schema") > Signed-off-by: Yong Wu > --- > .../bindings/memory-controllers/mediatek,smi-larb.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > index 80907e357892..884c0c74e5e4 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > @@ -80,10 +80,10 @@ allOf: > then: > properties: > clock: Separate patch: This should be clocks. The same in second if. Now it is simply not working... > - items: Putting min/maxItems under items is wrong. The second if also needs the fixing. Please make it a separate patch before this one. The schema was clearly not tested before... > - minItems: 3 > - maxItems: 3 > + minItems: 2 > + maxItems: 3 > clock-names: > + minItems: 2 > items: > - const: apb > - const: smi > Best regards, Krzysztof _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EF3EC433F5 for ; Wed, 12 Jan 2022 10:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aBjgcKdcADf42rm3vMBJDE1r0zQEDQwKwtHC37p9XrU=; b=SSdb644KZAzxCI y1dEbcnRH6i9F7A7SaUeDEfoqzYG39AZEEB504AgTNjYWwyDZHiBNO4nOSaiJ/iS4rMGWnc+3QyvU tUnDwdBNx+WAE3fawc5eQ3JvtIEkyva6IbfyRJF1LcoAgOSCs8gQ6r4sW8q7pt8bCEFeWZGPyftDh RxHe0NvA1xYXaf5oBp0rzSX/MnIl458hNCIyO16EON+aKioqET8p8hBBk+M2C/IjtXNGW5WzKRtGh auPFAgDTUhul6cLK+TgzSpTpM18vy5c2f2m6KJ5pl/SFCm/KNqJchiNfD/kW02vDFBfx/IxTvlYwS XV3Z/NlY4caFBMmBPWhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7ajh-0023Y8-Ta; Wed, 12 Jan 2022 10:20:09 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7ahn-0022i0-Ko for linux-mediatek@lists.infradead.org; Wed, 12 Jan 2022 10:18:14 +0000 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 6378540749 for ; Wed, 12 Jan 2022 10:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1641982686; bh=aPXjXruDq54PeYQ9iMhjoDG9FDgbk3AB64hbIMorCCc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZTrjUzUcNPQHYTA0VnqAFc5Mp+WdID8hg3+ypr68JZbAcNIgRfxNgS+5jamS1ZWFD pqBy5Ht5E6DycXbt007XSgovfUrRPNfUGEwZcUdd6/Q3tSLeRYDulWU/vryibetTHe AQwaX4jg1V7Br7UEwkyDhdAFipfwdC7UBDOgE73NeiCDJcohNstOmB524c1ouhBPZN yCHuRzZfKxw3sGV9ecImvCyF9btp6RGsQwYBEEy1ECsbf6sUtEs1nyBw/CLxVDk0WT F4EeFA4OvRfaBH8qH2sxTJaJ3MHcMvTxLGiA1AywtZBdiHWuzyXuNxzQqDEpIeuo0C AVyQZOHNnFeJA== Received: by mail-ed1-f69.google.com with SMTP id g2-20020a056402424200b003f8ee03207eso1866127edb.7 for ; Wed, 12 Jan 2022 02:18:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=aPXjXruDq54PeYQ9iMhjoDG9FDgbk3AB64hbIMorCCc=; b=VvksFlycIwEHUKcEityGh/G38Uf4oGqkr+GP12RbcMlOqc55LjTGD8pyCjFCQNN/Da Tr5RcDceWpFun1IVteBfDFBfcmv8RphbQ4yxboWImY91UoZl0j96dGbydl4ObPXQlZbU rJiRWpcOYpPjz3R3vT7AVRp2/9IiD2ackiOXvzV5UJw7/0uU1iNAzxu0MtoJ2TVh8mFf F2wEkbnSBwooQrf91GX7u7hiTTz4C7RY67rdxSwT2VyNmUbyYjfngYSdChCGiUPSHj9r xfJT4nIgj/zxEW2QMbMt/tc0wYOnWiO7/AH778sTB4yPviwbZfrl3ToXOa7c/6EPYxcB 9M7g== X-Gm-Message-State: AOAM531XsaAWsx6hgRrBzpmseRh3uyfZJlZgJtcutV1PrQkmdrjcQuEq m+dIFPlKs9wGyz0VdqLYEjrdPpiBQmoEHchUumzcJd0H+acGsDE561fgfL82Jrn+1GNqM/jluBD OMtqsEnt4OYuYW33HWMjikm5A3i0CZO9zdTWwQX0p/g1owBu1UQ== X-Received: by 2002:a17:906:ecee:: with SMTP id qt14mr471012ejb.133.1641982685614; Wed, 12 Jan 2022 02:18:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxkDLUnDXncfLM2SjyZMmYMSSgiKcr4RLjw+16eEj0TVwkNqMlPbJfgszDEo6F90TMvDr8RGQ== X-Received: by 2002:a17:906:ecee:: with SMTP id qt14mr470995ejb.133.1641982685404; Wed, 12 Jan 2022 02:18:05 -0800 (PST) Received: from [192.168.0.29] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id eb14sm6047322edb.16.2022.01.12.02.18.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 02:18:05 -0800 (PST) Message-ID: Date: Wed, 12 Jan 2022 11:18:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v2 2/6] dt-bindings: memory: mtk-smi: Fix the larb clock/clock-names dtbs warning Content-Language: en-US To: Yong Wu , Rob Herring , Matthias Brugger Cc: Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, anan.sun@mediatek.com, lc.kan@mediatek.com, yi.kuo@mediatek.com, anthony.huang@mediatek.com, AngeloGioacchino Del Regno References: <20220111063904.7583-1-yong.wu@mediatek.com> <20220111063904.7583-3-yong.wu@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220111063904.7583-3-yong.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220112_021812_098318_B837DC8E X-CRM114-Status: GOOD ( 22.26 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 11/01/2022 07:39, Yong Wu wrote: > Mute the warning from "make dtbs_check": > > larb@14017000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > ... > > larb@16010000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > > larb@17010000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > > If a platform's larb supports gals, there will be some larbs have one > more "gals" clock while the others still only need "apb"/"smi" clocks, > then the minItems for clock and clock-names are 2. > > Fixes: 27bb0e42855a ("dt-bindings: memory: mediatek: Convert SMI to DT schema") > Signed-off-by: Yong Wu > --- > .../bindings/memory-controllers/mediatek,smi-larb.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > index 80907e357892..884c0c74e5e4 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > @@ -80,10 +80,10 @@ allOf: > then: > properties: > clock: Separate patch: This should be clocks. The same in second if. Now it is simply not working... > - items: Putting min/maxItems under items is wrong. The second if also needs the fixing. Please make it a separate patch before this one. The schema was clearly not tested before... > - minItems: 3 > - maxItems: 3 > + minItems: 2 > + maxItems: 3 > clock-names: > + minItems: 2 > items: > - const: apb > - const: smi > Best regards, Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FF72C433EF for ; Wed, 12 Jan 2022 10:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ckdDKrTZa/sU86ifwqBb7EimMHbhUL5ul+qZ0p7aZmo=; b=mirP3PIuw+N1EH 8umoFJ6Pb7VeS1ETDtGNg52zV2ji/zvRfWcT1Mnu+TRcksp/hLDnVphjO6wS+I8E9N8WSqOT3Q4wg sIHA2nOYgGIPO2U1ans2BC3KizuOtKJlHSnAM4AP3C6CkYyRLBUqkB5H61zsXJ1mzhSw2a456FmY/ x3WD5rq5yTRHNRjHIRgmw8b0M3XIlr9iVDOKM58Z+mCHNtDnXwTECWhWXO1fFpIU73t3AyD6YYa7R CxFzuzLo2tMPtQkCwL5ULxpp6R7WsqBG53SIv0CzZB7mRaXyL79KVtGG9iLQr2ppZ5BNOnzrUVTzs wnesIg1IfKFv8Em779/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7aiw-0023DH-8q; Wed, 12 Jan 2022 10:19:23 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7ahn-0022i1-LP for linux-arm-kernel@lists.infradead.org; Wed, 12 Jan 2022 10:18:13 +0000 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 71C4E402DF for ; Wed, 12 Jan 2022 10:18:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1641982686; bh=aPXjXruDq54PeYQ9iMhjoDG9FDgbk3AB64hbIMorCCc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZTrjUzUcNPQHYTA0VnqAFc5Mp+WdID8hg3+ypr68JZbAcNIgRfxNgS+5jamS1ZWFD pqBy5Ht5E6DycXbt007XSgovfUrRPNfUGEwZcUdd6/Q3tSLeRYDulWU/vryibetTHe AQwaX4jg1V7Br7UEwkyDhdAFipfwdC7UBDOgE73NeiCDJcohNstOmB524c1ouhBPZN yCHuRzZfKxw3sGV9ecImvCyF9btp6RGsQwYBEEy1ECsbf6sUtEs1nyBw/CLxVDk0WT F4EeFA4OvRfaBH8qH2sxTJaJ3MHcMvTxLGiA1AywtZBdiHWuzyXuNxzQqDEpIeuo0C AVyQZOHNnFeJA== Received: by mail-ed1-f69.google.com with SMTP id h1-20020aa7cdc1000000b0040042dd2fe4so570713edw.17 for ; Wed, 12 Jan 2022 02:18:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=aPXjXruDq54PeYQ9iMhjoDG9FDgbk3AB64hbIMorCCc=; b=w2feA5nCSGQT1E74376ZG7OxJOItPbhCvoKKqqKIpPwt7BIBeoqdMkWXu3lcgTmhIE S6doNWaTIbJQ5lMDZ+o4McyLGxTtRAmPR4QarwSQtnkb8UBcNdyP1wdNp15d+biFgyMO D4U3XGzKx/bENGM1RnRBEb+W2Hcr+JTBTEtg/uCi5jqf+aiNii6gFXeu/YJ23RRPlLK3 dDOukv3/Jnr6QsM149SVV+9FE2/TZ6ns+36T5T0dtOAMWZB9CdjoWxUh/GMWoC1JDFFT 6yWYVku0D0PvtMoQhlzozR7HMTJ8ICXr4TujjFznAnYafzOuk96CpyBFdSUMCGDTO1Wn ml8g== X-Gm-Message-State: AOAM531dVYGOvy3JunnEJFrmFV8X4cjbLQFVIuZmIBtITRVf3cucT1IY moYGxoTieg6IzZUjAme/hKvfCd7hNS6Egv+GVl6SQSqnmEX0IP6l6PfzqwhMUcrKKIB8zcWpdSX T89DjIXK9xzA9miyFLJOHN6dN50LQZjVDyPbI6IHHgAKUKl5kdAfz X-Received: by 2002:a17:906:ecee:: with SMTP id qt14mr471015ejb.133.1641982685614; Wed, 12 Jan 2022 02:18:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxkDLUnDXncfLM2SjyZMmYMSSgiKcr4RLjw+16eEj0TVwkNqMlPbJfgszDEo6F90TMvDr8RGQ== X-Received: by 2002:a17:906:ecee:: with SMTP id qt14mr470995ejb.133.1641982685404; Wed, 12 Jan 2022 02:18:05 -0800 (PST) Received: from [192.168.0.29] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id eb14sm6047322edb.16.2022.01.12.02.18.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 02:18:05 -0800 (PST) Message-ID: Date: Wed, 12 Jan 2022 11:18:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v2 2/6] dt-bindings: memory: mtk-smi: Fix the larb clock/clock-names dtbs warning Content-Language: en-US To: Yong Wu , Rob Herring , Matthias Brugger Cc: Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, anan.sun@mediatek.com, lc.kan@mediatek.com, yi.kuo@mediatek.com, anthony.huang@mediatek.com, AngeloGioacchino Del Regno References: <20220111063904.7583-1-yong.wu@mediatek.com> <20220111063904.7583-3-yong.wu@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220111063904.7583-3-yong.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220112_021812_046419_894A77F4 X-CRM114-Status: GOOD ( 23.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/01/2022 07:39, Yong Wu wrote: > Mute the warning from "make dtbs_check": > > larb@14017000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > ... > > larb@16010000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > > larb@17010000: clock-names: ['apb', 'smi'] is too short > arch/arm64/boot/dts/mediatek/mt8183-evb.dt.yaml > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dt.yaml > > If a platform's larb supports gals, there will be some larbs have one > more "gals" clock while the others still only need "apb"/"smi" clocks, > then the minItems for clock and clock-names are 2. > > Fixes: 27bb0e42855a ("dt-bindings: memory: mediatek: Convert SMI to DT schema") > Signed-off-by: Yong Wu > --- > .../bindings/memory-controllers/mediatek,smi-larb.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > index 80907e357892..884c0c74e5e4 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > @@ -80,10 +80,10 @@ allOf: > then: > properties: > clock: Separate patch: This should be clocks. The same in second if. Now it is simply not working... > - items: Putting min/maxItems under items is wrong. The second if also needs the fixing. Please make it a separate patch before this one. The schema was clearly not tested before... > - minItems: 3 > - maxItems: 3 > + minItems: 2 > + maxItems: 3 > clock-names: > + minItems: 2 > items: > - const: apb > - const: smi > Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel