From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 11 Feb 2021 10:33:01 +0100 Subject: [PATCH 1/2] mtd: nand: spi: Only one dummy byte in QUADIO In-Reply-To: <20210210183620.20952-1-code@reto-schneider.ch> References: <20210210183620.20952-1-code@reto-schneider.ch> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10.02.21 19:36, Reto Schneider wrote: > From: Reto Schneider > > The datasheet only lists one dummy byte in the 0xEH operation for the > following chips: > * GD5F1GQ4xBxxG > * GD5F1GQ4xExxG > * GD5F1GQ4xFxxG > * GD5F1GQ4UAYIG > * GD5F4GQ4UAYIG > > This patch and its commit message reflects what has been done in Linux > and has not been tested by me. > > Signed-off-by: Reto Schneider > CC: Stefan Roese AFAICT, you are posting a Linux patch ported to U-Boot here. Which is good of course. But if you didn't do substantial changes to this patch, then please keep the original (Linux) authorship of Hauke for this patch (From: ...). You might want to add something like: Reto Schneider: Linux patch ported to U-Boot to the end of the commit text and add your Sob of course. Other than this: Reviewed-by: Stefan Roese Thanks, Stefan > --- > drivers/mtd/nand/spi/gigadevice.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/spi/gigadevice.c b/drivers/mtd/nand/spi/gigadevice.c > index 0b228dcb5b..5de0ebbb7b 100644 > --- a/drivers/mtd/nand/spi/gigadevice.c > +++ b/drivers/mtd/nand/spi/gigadevice.c > @@ -20,7 +20,7 @@ > #define GD5FXGQ4XEXXG_REG_STATUS2 0xf0 > > static SPINAND_OP_VARIANTS(read_cache_variants, > - SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(0, 2, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_QUADIO_OP(0, 1, NULL, 0), > SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0), > SPINAND_PAGE_READ_FROM_CACHE_DUALIO_OP(0, 1, NULL, 0), > SPINAND_PAGE_READ_FROM_CACHE_X2_OP(0, 1, NULL, 0), > Viele Gr??e, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de