From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE52C31E51 for ; Tue, 18 Jun 2019 06:47:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BE9C205F4 for ; Tue, 18 Jun 2019 06:47:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=neuling.org header.i=@neuling.org header.b="AMlvJ74l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728783AbfFRGr0 (ORCPT ); Tue, 18 Jun 2019 02:47:26 -0400 Received: from ozlabs.org ([203.11.71.1]:46175 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728195AbfFRGrZ (ORCPT ); Tue, 18 Jun 2019 02:47:25 -0400 Received: from neuling.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 45Sd4w30GDz9sDX; Tue, 18 Jun 2019 16:11:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=neuling.org; s=201811; t=1560838288; bh=uLeN3JvliJrrWmBBPBEg+QalZIGnGRnRT7IRnPElTPo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=AMlvJ74llgIPBvEBzG1nNMm7QQtDD7fDcC6V8gqITcdfNDndxaXnsrlAuPixXs29a 0nIFFLgtySP4DzClUAseH5nloiXZ4wg/wPXBHV77xN9aZwKBkm0UPlA3O1ediVxRD3 bZMCWcZWyWQeGxoXV/by1cIA1/T75CbIhX3E2TmxsUue9HHqo7VhWr96lv7ueHWcQI e5d1chyRCxCbdF6Sx/pQ9VjH5nj8hMpgUxV1rHWk1Lk937v5f/D8dKJjpG28UjCsrg B09oWpbxAK9StLsRmkp7yMvErJBxxm2UFPQdEgBAJ7ZvYSvZDtdtB51Y0WcObcCdDc kNWUorW49OC4w== Received: by neuling.org (Postfix, from userid 1000) id 512FA2A2538; Tue, 18 Jun 2019 16:11:28 +1000 (AEST) Message-ID: Subject: Re: [PATCH 3/5] Powerpc/hw-breakpoint: Refactor set_dawr() From: Michael Neuling To: Ravi Bangoria , mpe@ellerman.id.au Cc: benh@kernel.crashing.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, npiggin@gmail.com, christophe.leroy@c-s.fr, naveen.n.rao@linux.vnet.ibm.com Date: Tue, 18 Jun 2019 16:11:28 +1000 In-Reply-To: <20190618042732.5582-4-ravi.bangoria@linux.ibm.com> References: <20190618042732.5582-1-ravi.bangoria@linux.ibm.com> <20190618042732.5582-4-ravi.bangoria@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.32.2 (3.32.2-1.fc30) MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is going to collide with this patch=20 https://patchwork.ozlabs.org/patch/1109594/ Mikey On Tue, 2019-06-18 at 09:57 +0530, Ravi Bangoria wrote: > Remove unnecessary comments. Code itself is self explanatory. > And, ISA already talks about MRD field. I Don't think we need > to re-describe it. >=20 > Signed-off-by: Ravi Bangoria > --- > arch/powerpc/kernel/process.c | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) >=20 > diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.= c > index f0fbbf6a6a1f..f002d2ffff86 100644 > --- a/arch/powerpc/kernel/process.c > +++ b/arch/powerpc/kernel/process.c > @@ -799,18 +799,11 @@ int set_dawr(struct arch_hw_breakpoint *brk) > =20 > dawr =3D brk->address; > =20 > - dawrx =3D (brk->type & (HW_BRK_TYPE_READ | HW_BRK_TYPE_WRITE)) \ > - << (63 - 58); //* read/write bits */ > - dawrx |=3D ((brk->type & (HW_BRK_TYPE_TRANSLATE)) >> 2) \ > - << (63 - 59); //* translate */ > - dawrx |=3D (brk->type & (HW_BRK_TYPE_PRIV_ALL)) \ > - >> 3; //* PRIM bits */ > - /* dawr length is stored in field MDR bits 48:53. Matches range in > - doublewords (64 bits) baised by -1 eg. 0b000000=3D1DW and > - 0b111111=3D64DW. > - brk->len is in bytes. > - This aligns up to double word size, shifts and does the bias. > - */ > + dawrx =3D (brk->type & HW_BRK_TYPE_RDWR) << (63 - 58); > + dawrx |=3D ((brk->type & HW_BRK_TYPE_TRANSLATE) >> 2) << (63 - 59); > + dawrx |=3D (brk->type & HW_BRK_TYPE_PRIV_ALL) >> 3; > + > + /* brk->len is in bytes. */ > mrd =3D ((brk->len + 7) >> 3) - 1; > dawrx |=3D (mrd & 0x3f) << (63 - 53); > =20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10789C31E51 for ; Tue, 18 Jun 2019 06:13:17 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D4C0214AF for ; Tue, 18 Jun 2019 06:13:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=neuling.org header.i=@neuling.org header.b="AMlvJ74l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D4C0214AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=neuling.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 45Sd6y3kf2zDq9Z for ; Tue, 18 Jun 2019 16:13:14 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45Sd4x2RjXzDq6q for ; Tue, 18 Jun 2019 16:11:29 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=neuling.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=neuling.org header.i=@neuling.org header.b="AMlvJ74l"; dkim-atps=neutral Received: from neuling.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 45Sd4w30GDz9sDX; Tue, 18 Jun 2019 16:11:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=neuling.org; s=201811; t=1560838288; bh=uLeN3JvliJrrWmBBPBEg+QalZIGnGRnRT7IRnPElTPo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=AMlvJ74llgIPBvEBzG1nNMm7QQtDD7fDcC6V8gqITcdfNDndxaXnsrlAuPixXs29a 0nIFFLgtySP4DzClUAseH5nloiXZ4wg/wPXBHV77xN9aZwKBkm0UPlA3O1ediVxRD3 bZMCWcZWyWQeGxoXV/by1cIA1/T75CbIhX3E2TmxsUue9HHqo7VhWr96lv7ueHWcQI e5d1chyRCxCbdF6Sx/pQ9VjH5nj8hMpgUxV1rHWk1Lk937v5f/D8dKJjpG28UjCsrg B09oWpbxAK9StLsRmkp7yMvErJBxxm2UFPQdEgBAJ7ZvYSvZDtdtB51Y0WcObcCdDc kNWUorW49OC4w== Received: by neuling.org (Postfix, from userid 1000) id 512FA2A2538; Tue, 18 Jun 2019 16:11:28 +1000 (AEST) Message-ID: Subject: Re: [PATCH 3/5] Powerpc/hw-breakpoint: Refactor set_dawr() From: Michael Neuling To: Ravi Bangoria , mpe@ellerman.id.au Date: Tue, 18 Jun 2019 16:11:28 +1000 In-Reply-To: <20190618042732.5582-4-ravi.bangoria@linux.ibm.com> References: <20190618042732.5582-1-ravi.bangoria@linux.ibm.com> <20190618042732.5582-4-ravi.bangoria@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.32.2 (3.32.2-1.fc30) MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, npiggin@gmail.com, paulus@samba.org, naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" This is going to collide with this patch=20 https://patchwork.ozlabs.org/patch/1109594/ Mikey On Tue, 2019-06-18 at 09:57 +0530, Ravi Bangoria wrote: > Remove unnecessary comments. Code itself is self explanatory. > And, ISA already talks about MRD field. I Don't think we need > to re-describe it. >=20 > Signed-off-by: Ravi Bangoria > --- > arch/powerpc/kernel/process.c | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) >=20 > diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.= c > index f0fbbf6a6a1f..f002d2ffff86 100644 > --- a/arch/powerpc/kernel/process.c > +++ b/arch/powerpc/kernel/process.c > @@ -799,18 +799,11 @@ int set_dawr(struct arch_hw_breakpoint *brk) > =20 > dawr =3D brk->address; > =20 > - dawrx =3D (brk->type & (HW_BRK_TYPE_READ | HW_BRK_TYPE_WRITE)) \ > - << (63 - 58); //* read/write bits */ > - dawrx |=3D ((brk->type & (HW_BRK_TYPE_TRANSLATE)) >> 2) \ > - << (63 - 59); //* translate */ > - dawrx |=3D (brk->type & (HW_BRK_TYPE_PRIV_ALL)) \ > - >> 3; //* PRIM bits */ > - /* dawr length is stored in field MDR bits 48:53. Matches range in > - doublewords (64 bits) baised by -1 eg. 0b000000=3D1DW and > - 0b111111=3D64DW. > - brk->len is in bytes. > - This aligns up to double word size, shifts and does the bias. > - */ > + dawrx =3D (brk->type & HW_BRK_TYPE_RDWR) << (63 - 58); > + dawrx |=3D ((brk->type & HW_BRK_TYPE_TRANSLATE) >> 2) << (63 - 59); > + dawrx |=3D (brk->type & HW_BRK_TYPE_PRIV_ALL) >> 3; > + > + /* brk->len is in bytes. */ > mrd =3D ((brk->len + 7) >> 3) - 1; > dawrx |=3D (mrd & 0x3f) << (63 - 53); > =20