From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:33663 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933221AbdEWG6i (ORCPT ); Tue, 23 May 2017 02:58:38 -0400 Subject: Re: [PATCH blktests v2 3/3] sg/001: add regression test for syzcaller generated GPF in sg_read path To: Omar Sandoval Cc: Linux Block Layer Mailinglist , Linux SCSI Mailinglist References: <79600648b662bc8b9e701ff6627986887384585b.1495201975.git.jthumshirn@suse.de> <20170522175905.GA17738@vader.DHCP.thefacebook.com> From: Johannes Thumshirn Message-ID: Date: Tue, 23 May 2017 08:58:32 +0200 MIME-Version: 1.0 In-Reply-To: <20170522175905.GA17738@vader.DHCP.thefacebook.com> Content-Type: text/plain; charset=utf-8 Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On 05/22/2017 07:59 PM, Omar Sandoval wrote: > This looks much better, thanks! One question for you: is there any value > in running this on specific test devices (i.e., changing test() to > test_device() and using "$TEST_DEV" instead of a scsi-debug device), or > would it be a waste of time since it's just exercising generic code? That's just generic code. All I need is a SCSI device so I get a /dev/sg device node. One could do a check if $TEST_DEV is a SCSI device and have a fall-back to scsi_debug if it isn't, but I'm not sure if this isn't just a waste of time. Byte, Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850