From: Harry Wentland <hwentlan@amd.com>
To: Alex Deucher <alexander.deucher@amd.com>, amd-gfx@lists.freedesktop.org
Cc: kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 1/2] drm/amdgpu/display: drop set but unused variable
Date: Thu, 23 Jun 2022 17:36:05 -0400 [thread overview]
Message-ID: <b8f6395a-0f24-6fc3-020f-b753b7daf4f4@amd.com> (raw)
In-Reply-To: <20220623164113.1503249-1-alexander.deucher@amd.com>
On 6/23/22 12:41, Alex Deucher wrote:
> No longer used so drop it.
>
> Fixes: ec457f837890 ("drm/amd/display: Drop unnecessary detect link code")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index 1206a3dd746f..86a553757d14 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -1022,7 +1022,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,
> struct dc_sink *prev_sink = NULL;
> struct dpcd_caps prev_dpcd_caps;
> enum dc_connection_type new_connection_type = dc_connection_none;
> - enum dc_connection_type pre_connection_type = dc_connection_none;
> const uint32_t post_oui_delay = 30; // 30ms
>
> DC_LOGGER_INIT(link->ctx->logger);
> @@ -1059,7 +1058,6 @@ static bool detect_link_and_local_sink(struct dc_link *link,
>
> link_disconnect_sink(link);
> if (new_connection_type != dc_connection_none) {
> - pre_connection_type = link->type;
> link->type = new_connection_type;
> link->link_state_valid = false;
>
prev parent reply other threads:[~2022-06-23 21:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 16:41 [PATCH 1/2] drm/amdgpu/display: drop set but unused variable Alex Deucher
2022-06-23 16:41 ` [PATCH 2/2] drm/amdgpu: fix documentation warning Alex Deucher
2022-06-27 21:40 ` Alex Deucher
2022-06-28 13:34 ` Russell, Kent
2022-06-23 21:36 ` Harry Wentland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8f6395a-0f24-6fc3-020f-b753b7daf4f4@amd.com \
--to=hwentlan@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.